[libvirt] [dbus PATCH 6/8] Implement GetXMLDesc method for NWFilter Interface

Katerina Koukiou posted 8 patches 7 years ago
[libvirt] [dbus PATCH 6/8] Implement GetXMLDesc method for NWFilter Interface
Posted by Katerina Koukiou 7 years ago
Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
---
 data/org.libvirt.NWFilter.xml |  6 ++++++
 src/nwfilter.c                | 28 ++++++++++++++++++++++++++++
 2 files changed, 34 insertions(+)

diff --git a/data/org.libvirt.NWFilter.xml b/data/org.libvirt.NWFilter.xml
index fae61dc..69e3357 100644
--- a/data/org.libvirt.NWFilter.xml
+++ b/data/org.libvirt.NWFilter.xml
@@ -13,5 +13,11 @@
         value="See https://libvirt.org/html/libvirt-libvirt-nwfilter.html#virNWFilterGetUUIDString"/>
       <annotation name="org.freedesktop.DBus.Property.EmitsChangedSignal" value="const"/>
     </property>
+    <method name="GetXMLDesc">
+      <annotation name="org.gtk.GDBus.DocString"
+        value="See https://libvirt.org/html/libvirt-libvirt-nwfilter.html#virNWFilterGetXMLDesc"/>
+      <arg name="flags" type="u" direction="in"/>
+      <arg name="xml" type="s" direction="out"/>
+    </method>
   </interface>
 </node>
diff --git a/src/nwfilter.c b/src/nwfilter.c
index 90183a7..acfbdd5 100644
--- a/src/nwfilter.c
+++ b/src/nwfilter.c
@@ -65,6 +65,33 @@ virtDBusNWFilterGetUUID(const gchar *objectPath,
     *value = g_variant_new("s", uuid);
 }
 
+static void
+virtDBusNWFilterGetXMLDesc(GVariant *inArgs,
+                           GUnixFDList *inFDs G_GNUC_UNUSED,
+                           const gchar *objectPath,
+                           gpointer userData,
+                           GVariant **outArgs,
+                           GUnixFDList **outFDs G_GNUC_UNUSED,
+                           GError **error)
+{
+    virtDBusConnect *connect = userData;
+    g_autoptr(virNWFilter) nwfilter = NULL;
+    g_autofree gchar *xml = NULL;
+    guint flags;
+
+    g_variant_get(inArgs, "(u)", &flags);
+
+    nwfilter = virtDBusNWFilterGetVirNWFilter(connect, objectPath, error);
+    if (!nwfilter)
+        return;
+
+    xml = virNWFilterGetXMLDesc(nwfilter, flags);
+    if (!xml)
+        return virtDBusUtilSetLastVirtError(error);
+
+    *outArgs = g_variant_new("(s)", xml);
+}
+
 static virtDBusGDBusPropertyTable virtDBusNWFilterPropertyTable[] = {
     { "Name", virtDBusNWFilterGetName, NULL },
     { "UUID", virtDBusNWFilterGetUUID, NULL },
@@ -72,6 +99,7 @@ static virtDBusGDBusPropertyTable virtDBusNWFilterPropertyTable[] = {
 };
 
 static virtDBusGDBusMethodTable virtDBusNWFilterMethodTable[] = {
+    { "GetXMLDesc", virtDBusNWFilterGetXMLDesc },
     { 0 }
 };
 
-- 
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [dbus PATCH 6/8] Implement GetXMLDesc method for NWFilter Interface
Posted by Ján Tomko 6 years, 11 months ago
On Fri, May 11, 2018 at 01:57:49PM +0200, Katerina Koukiou wrote:
>Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
>---
> data/org.libvirt.NWFilter.xml |  6 ++++++
> src/nwfilter.c                | 28 ++++++++++++++++++++++++++++
> 2 files changed, 34 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list