[libvirt] [dbus PATCH v2 1/3] virtDBusNetworkGetDHCPLeases: fix lease type

Katerina Koukiou posted 3 patches 7 years ago
[libvirt] [dbus PATCH v2 1/3] virtDBusNetworkGetDHCPLeases: fix lease type
Posted by Katerina Koukiou 7 years ago
Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
---
 src/network.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/network.c b/src/network.c
index 1763eca..7596687 100644
--- a/src/network.c
+++ b/src/network.c
@@ -228,7 +228,7 @@ virtDBusNetworkGetDHCPLeases(GVariant *inArgs,
     if (nleases < 0)
         return virtDBusUtilSetLastVirtError(error);
 
-    g_variant_builder_init(&builder, G_VARIANT_TYPE("a(stssssuss)"));
+    g_variant_builder_init(&builder, G_VARIANT_TYPE("a(stusssuss)"));
     for (gint i = 0; i < nleases; i++) {
         virNetworkDHCPLeasePtr lease = leases[i];
 
-- 
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [dbus PATCH v2 1/3] virtDBusNetworkGetDHCPLeases: fix lease type
Posted by Pavel Hrdina 7 years ago
On Fri, May 11, 2018 at 06:16:54PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
> ---
>  src/network.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Some explanation would be nice, something like:

Commit 8eac355f3e removed *TypedToString conversion but missed to
update this one place.

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list