From nobody Thu May 15 14:07:26 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1526296567899678.0438159301821; Mon, 14 May 2018 04:16:07 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8BB073006A93; Mon, 14 May 2018 11:16:06 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4D07660BE7; Mon, 14 May 2018 11:16:06 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E2773180124C; Mon, 14 May 2018 11:16:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4EBFowg009789 for ; Mon, 14 May 2018 07:15:50 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1295498F43; Mon, 14 May 2018 11:15:50 +0000 (UTC) Received: from mx1.redhat.com (ext-mx08.extmail.prod.ext.phx2.redhat.com [10.5.110.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5D70098F41; Mon, 14 May 2018 11:15:48 +0000 (UTC) Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com [209.85.192.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3F3C3C0B7408; Mon, 14 May 2018 11:15:37 +0000 (UTC) Received: by mail-pf0-f196.google.com with SMTP id a20-v6so1921472pfo.0; Mon, 14 May 2018 04:15:37 -0700 (PDT) Received: from ps-f25-dev.eng.nutanix.com ([205.209.132.2]) by smtp.gmail.com with ESMTPSA id d4-v6sm13292667pgv.73.2018.05.14.04.15.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 May 2018 04:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=P+4ipeJAHQCUtEqjLv5W8b8uyfdw3EIUuZ+bmpr6qVs=; b=S5rXdUjQa79iu56MdhUPOyBcIHTgn9uLR8JG2S54YyXAGJi7pUBkIedBAK+TrHeAAm RdkdoUcANebWJiJnVlY+hb7qIdGKLex647CevEPDsn2tLeHV6iOUJtYb1yCuFWneHqud sL3FNFOI36bwQXzPKlbtyuZSsRpBQKRTHP+99EqFrE6y9mlOJLgcWXGglEtTrEtZbz+h 7dMCbLoyafF5inGtMwDhRyyWl69cyzCte2rFRo1je/JKW7JxkJMcMRxD7wTBr7zt/jAo 7KuCMTzpHI5dG3C7GPUXoHlRJW940SPTXqC57760alMsf+qYU8xwsXJmqkvbXi8tJO59 dXZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=P+4ipeJAHQCUtEqjLv5W8b8uyfdw3EIUuZ+bmpr6qVs=; b=m3yKXkrOzyfnhCjw0PR3EWkFjweLoCgeCyVo8VbKJ8sh3BAoC5XwIRdf+1HuKJJEll EVUNlFHfxjXWEvq2BxLRi7XUtWutTYPJj944TWYkaN1C3VtmZBBQJKvV61zDYVHTgXSS A9WHgT19adi4ydUhwzyt1ZbP5LxT+MIg1ULT+ci2IsvP6Nsz4EkxgPdYGFwgvTFa3N25 8bfhLoGZf3rHzLC82MhawYfXDJU2tY5IjAWO7mmtu/pzZwCLUIXakJjrPP0Y0hxYjwXf fXXZsEIXS91GRYw6msN8dnIdebleHAJjJPvsrj8LbInbDP94OzJ+BUUbRcqEAq2VajYk FNew== X-Gm-Message-State: ALKqPweh18COsZ/VAMx+9gI7T92fp2+tPZ3PsYICtKMYWxUHu8/Bcas/ B8Rg8QhE+C1YC7Jxc/+WsJ1w3g== X-Google-Smtp-Source: AB8JxZptc1gfPHcg1VWBNQiYey01Jeyjkj0Yn2+aT7HpC5b0QIMTidwwy/jb5Wz44ryp6NGbYJcL4Q== X-Received: by 2002:a63:7f18:: with SMTP id a24-v6mr8132959pgd.312.1526296536579; Mon, 14 May 2018 04:15:36 -0700 (PDT) From: Prerna Saxena To: libvir-list@redhat.com Date: Mon, 14 May 2018 04:15:17 -0700 Message-Id: <20180514111522.4363-8-saxenap.ltc@gmail.com> In-Reply-To: <20180514111522.4363-1-saxenap.ltc@gmail.com> References: <20180514111522.4363-1-saxenap.ltc@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 14 May 2018 11:15:37 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 14 May 2018 11:15:37 +0000 (UTC) for IP:'209.85.192.196' DOMAIN:'mail-pf0-f196.google.com' HELO:'mail-pf0-f196.google.com' FROM:'saxenap.ltc@gmail.com' RCPT:'' X-RedHat-Spam-Score: 0.696 (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_PASS, T_DKIM_INVALID) 209.85.192.196 mail-pf0-f196.google.com 209.85.192.196 mail-pf0-f196.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.32 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.27 X-loop: libvir-list@redhat.com Cc: pkrempa@redhat.com, mprivozn@redhat.com Subject: [libvirt] [PATCH 07/12] Bhyve: Fix command line generation to correctly pick up local loader path. X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Mon, 14 May 2018 11:16:07 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Prerna Saxena --- src/bhyve/bhyve_command.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index 9413ae5..2b67014 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@ -518,10 +518,12 @@ virBhyveProcessBuildBhyveCmd(virConnectPtr conn, virCommandAddArgList(cmd, "-s", "0:0,hostbridge", NULL); =20 if (def->os.bootloader =3D=3D NULL && - def->os.loader) { + def->os.loader && + def->os.loader->src && + def->os.loader->src->type =3D=3D VIR_STORAGE_TYPE_FILE) { if ((bhyveDriverGetCaps(conn) & BHYVE_CAP_LPC_BOOTROM)) { virCommandAddArg(cmd, "-l"); - virCommandAddArgFormat(cmd, "bootrom,%s", def->os.loader->path= ); + virCommandAddArgFormat(cmd, "bootrom,%s", def->os.loader->src-= >path); add_lpc =3D true; } else { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", --=20 1.8.1.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list