[libvirt] [jenkins-ci PATCH 1/8] guests: Fix PERL5LIB on Debian sid

Andrea Bolognani posted 8 patches 6 years, 12 months ago
[libvirt] [jenkins-ci PATCH 1/8] guests: Fix PERL5LIB on Debian sid
Posted by Andrea Bolognani 6 years, 12 months ago
Debian sid is shipping Perl 5.26.2 now.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/host_vars/libvirt-debian-sid/main.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guests/host_vars/libvirt-debian-sid/main.yml b/guests/host_vars/libvirt-debian-sid/main.yml
index f5eb52c..bc711f5 100644
--- a/guests/host_vars/libvirt-debian-sid/main.yml
+++ b/guests/host_vars/libvirt-debian-sid/main.yml
@@ -1,5 +1,5 @@
 ---
-PERL5LIB: $VIRT_PREFIX/lib/x86_64-linux-gnu/perl/5.26.1
+PERL5LIB: $VIRT_PREFIX/lib/x86_64-linux-gnu/perl/5.26.2
 PYTHONPATH: $VIRT_PREFIX/lib/python3.6/site-packages
 
 projects:
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH 1/8] guests: Fix PERL5LIB on Debian sid
Posted by Pavel Hrdina 6 years, 12 months ago
On Tue, May 15, 2018 at 04:40:02PM +0200, Andrea Bolognani wrote:
> Debian sid is shipping Perl 5.26.2 now.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  guests/host_vars/libvirt-debian-sid/main.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/guests/host_vars/libvirt-debian-sid/main.yml b/guests/host_vars/libvirt-debian-sid/main.yml
> index f5eb52c..bc711f5 100644
> --- a/guests/host_vars/libvirt-debian-sid/main.yml
> +++ b/guests/host_vars/libvirt-debian-sid/main.yml
> @@ -1,5 +1,5 @@
>  ---
> -PERL5LIB: $VIRT_PREFIX/lib/x86_64-linux-gnu/perl/5.26.1
> +PERL5LIB: $VIRT_PREFIX/lib/x86_64-linux-gnu/perl/5.26.2
>  PYTHONPATH: $VIRT_PREFIX/lib/python3.6/site-packages

I guess that this is somehow needed otherwise the perl build fails
but we can use $(perl -e 'print substr($^V, 1)') to get the current
version.

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH 1/8] guests: Fix PERL5LIB on Debian sid
Posted by Andrea Bolognani 6 years, 12 months ago
On Wed, 2018-05-16 at 10:39 +0200, Pavel Hrdina wrote:
> On Tue, May 15, 2018 at 04:40:02PM +0200, Andrea Bolognani wrote:
> > -PERL5LIB: $VIRT_PREFIX/lib/x86_64-linux-gnu/perl/5.26.1
> > +PERL5LIB: $VIRT_PREFIX/lib/x86_64-linux-gnu/perl/5.26.2
> >  PYTHONPATH: $VIRT_PREFIX/lib/python3.6/site-packages
> 
> I guess that this is somehow needed otherwise the perl build fails
> but we can use $(perl -e 'print substr($^V, 1)') to get the current
> version.

Good idea! I'll push the patch as-is for now, but I'll look into
integrating your suggestion and finding a Python equivalent so
that we can remove this last bit of per-host information from the
inventory.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list