Even though the packages are technically only needed when
performing a MinGW build, it doesn't hurt to have them
installed when performing native build, and keeping the
native packages all in one place is cleaner.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/vars/projects/libosinfo+mingw.yml   | 1 -
 guests/vars/projects/libosinfo.yml         | 1 +
 guests/vars/projects/virt-viewer+mingw.yml | 1 -
 guests/vars/projects/virt-viewer.yml       | 1 +
 4 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/guests/vars/projects/libosinfo+mingw.yml b/guests/vars/projects/libosinfo+mingw.yml
index 0eb27af..8bf8622 100644
--- a/guests/vars/projects/libosinfo+mingw.yml
+++ b/guests/vars/projects/libosinfo+mingw.yml
@@ -8,4 +8,3 @@ packages:
   - mingw64-glib2
   - mingw64-libxml2
   - mingw64-libxslt
-  - wget
diff --git a/guests/vars/projects/libosinfo.yml b/guests/vars/projects/libosinfo.yml
index 4297110..dfbd004 100644
--- a/guests/vars/projects/libosinfo.yml
+++ b/guests/vars/projects/libosinfo.yml
@@ -13,4 +13,5 @@ packages:
   - pci-ids
   - usb-ids
   - vala
+  - wget
   - xmllint
diff --git a/guests/vars/projects/virt-viewer+mingw.yml b/guests/vars/projects/virt-viewer+mingw.yml
index 5499dfe..c6aafd8 100644
--- a/guests/vars/projects/virt-viewer+mingw.yml
+++ b/guests/vars/projects/virt-viewer+mingw.yml
@@ -1,6 +1,5 @@
 ---
 packages:
-  - icoutils
   - mingw32-glib2
   - mingw32-glib-networking
   - mingw32-gstreamer1-plugins-bad-free
diff --git a/guests/vars/projects/virt-viewer.yml b/guests/vars/projects/virt-viewer.yml
index cd32176..f9a2e78 100644
--- a/guests/vars/projects/virt-viewer.yml
+++ b/guests/vars/projects/virt-viewer.yml
@@ -3,6 +3,7 @@ packages:
   - glib2
   - gtk-vnc2
   - gtk3
+  - icoutils
   - intltool
   - libgovirt
   - libxml2
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Tue, May 15, 2018 at 04:40:09PM +0200, Andrea Bolognani wrote:
> Even though the packages are technically only needed when
> performing a MinGW build, it doesn't hurt to have them
> installed when performing native build, and keeping the
> native packages all in one place is cleaner.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  guests/vars/projects/libosinfo+mingw.yml   | 1 -
>  guests/vars/projects/libosinfo.yml         | 1 +
>  guests/vars/projects/virt-viewer+mingw.yml | 1 -
>  guests/vars/projects/virt-viewer.yml       | 1 +
>  4 files changed, 2 insertions(+), 2 deletions(-)

And I'm not sure about this one as well.  Yes, it might make things
cleaner that the mingw dependencies are only mingw-* packages but it's
not correct.  They are required only by the mingw build and not by the
regular build so it will pollute systems where we don't run mingw
builds.

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Wed, 2018-05-16 at 10:53 +0200, Pavel Hrdina wrote:
> On Tue, May 15, 2018 at 04:40:09PM +0200, Andrea Bolognani wrote:
> > Even though the packages are technically only needed when
> > performing a MinGW build, it doesn't hurt to have them
> > installed when performing native build, and keeping the
> > native packages all in one place is cleaner.
> > 
> > Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> > ---
> >  guests/vars/projects/libosinfo+mingw.yml   | 1 -
> >  guests/vars/projects/libosinfo.yml         | 1 +
> >  guests/vars/projects/virt-viewer+mingw.yml | 1 -
> >  guests/vars/projects/virt-viewer.yml       | 1 +
> >  4 files changed, 2 insertions(+), 2 deletions(-)
> 
> And I'm not sure about this one as well.  Yes, it might make things
> cleaner that the mingw dependencies are only mingw-* packages but it's
> not correct.  They are required only by the mingw build and not by the
> regular build so it will pollute systems where we don't run mingw
> builds.

I agree with your argument, to the point where I had basically
already acknowledged it in the commit message :)

Given how tiny the packages involved are, though, I think the
trade-off is worth it, especially in light of the stuff I
mentioned in the comments to the previous patch.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Wed, May 16, 2018 at 11:20:26AM +0200, Andrea Bolognani wrote:
> On Wed, 2018-05-16 at 10:53 +0200, Pavel Hrdina wrote:
> > On Tue, May 15, 2018 at 04:40:09PM +0200, Andrea Bolognani wrote:
> > > Even though the packages are technically only needed when
> > > performing a MinGW build, it doesn't hurt to have them
> > > installed when performing native build, and keeping the
> > > native packages all in one place is cleaner.
> > > 
> > > Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> > > ---
> > >  guests/vars/projects/libosinfo+mingw.yml   | 1 -
> > >  guests/vars/projects/libosinfo.yml         | 1 +
> > >  guests/vars/projects/virt-viewer+mingw.yml | 1 -
> > >  guests/vars/projects/virt-viewer.yml       | 1 +
> > >  4 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > And I'm not sure about this one as well.  Yes, it might make things
> > cleaner that the mingw dependencies are only mingw-* packages but it's
> > not correct.  They are required only by the mingw build and not by the
> > regular build so it will pollute systems where we don't run mingw
> > builds.
> 
> I agree with your argument, to the point where I had basically
> already acknowledged it in the commit message :)
> 
> Given how tiny the packages involved are, though, I think the
> trade-off is worth it, especially in light of the stuff I
> mentioned in the comments to the previous patch.

For me this is different issue than the previous patch.  This actually
moves the dependency into project that doesn't require it out of project
that requires it.  It's not like both will use it so it's safe and good
enough to have it in the parent project.

The only benefit that I can see is to have only mingw-* packages as
dependency of mingw builds, which might look nice and neat in the
configuration file but IMHO it's wrong.  If we move them, it would be
nice to mention, that these packages are required by mingw build only
and that would feel weird, like why they are not only in the mingw
projects?

I would rather have it technically correct than having the configuration
files look nice :).

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Wed, 2018-05-16 at 12:34 +0200, Pavel Hrdina wrote:
> On Wed, May 16, 2018 at 11:20:26AM +0200, Andrea Bolognani wrote:
> > Given how tiny the packages involved are, though, I think the
> > trade-off is worth it, especially in light of the stuff I
> > mentioned in the comments to the previous patch.
> 
> For me this is different issue than the previous patch.  This actually
> moves the dependency into project that doesn't require it out of project
> that requires it.  It's not like both will use it so it's safe and good
> enough to have it in the parent project.
> 
> The only benefit that I can see is to have only mingw-* packages as
> dependency of mingw builds, which might look nice and neat in the
> configuration file but IMHO it's wrong.  If we move them, it would be
> nice to mention, that these packages are required by mingw build only
> and that would feel weird, like why they are not only in the mingw
> projects?
> 
> I would rather have it technically correct than having the configuration
> files look nice :).

As I said, it's a trade-off. But you clearly feel strongly on the
topic, and I kinda don't, so I'll just drop this patch :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list