Module::Build requires Archive::Tar in order to create
distribution archives, but on some operating systems there
is no explicit dependency dragging it the latter when
installing the former, so we need to handle it ourselves.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/vars/mappings.yml              | 5 +++++
 guests/vars/projects/libvirt-perl.yml | 1 +
 guests/vars/projects/libvirt-tck.yml  | 1 +
 3 files changed, 7 insertions(+)

diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index cfba51c..f809e24 100644
--- a/guests/vars/mappings.yml
+++ b/guests/vars/mappings.yml
@@ -514,6 +514,11 @@ mappings:
     default: perl
     FreeBSD: perl5
 
+  perl-Archive-Tar:
+    deb: perl
+    pkg: perl5
+    rpm: perl-Archive-Tar
+
   perl-CPAN-Changes:
     deb: libcpan-changes-perl
     pkg: p5-CPAN-Changes
diff --git a/guests/vars/projects/libvirt-perl.yml b/guests/vars/projects/libvirt-perl.yml
index a19e232..2eb14f2 100644
--- a/guests/vars/projects/libvirt-perl.yml
+++ b/guests/vars/projects/libvirt-perl.yml
@@ -1,5 +1,6 @@
 ---
 packages:
+  - perl-Archive-Tar
   - perl-CPAN-Changes
   - perl-Module-Build
   - perl-Test-Pod
diff --git a/guests/vars/projects/libvirt-tck.yml b/guests/vars/projects/libvirt-tck.yml
index 8d29c1c..dcccc0f 100644
--- a/guests/vars/projects/libvirt-tck.yml
+++ b/guests/vars/projects/libvirt-tck.yml
@@ -1,5 +1,6 @@
 ---
 packages:
+  - perl-Archive-Tar
   - perl-Config-Record
   - perl-Digest
   - perl-Digest-MD5
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Tue, May 15, 2018 at 08:27:35PM +0200, Andrea Bolognani wrote:
> Module::Build requires Archive::Tar in order to create
> distribution archives, but on some operating systems there
> is no explicit dependency dragging it the latter when
> installing the former, so we need to handle it ourselves.

Hmm, any idea why we didn't see a failure already with libvirt-tck
then ?

> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  guests/vars/mappings.yml              | 5 +++++
>  guests/vars/projects/libvirt-perl.yml | 1 +
>  guests/vars/projects/libvirt-tck.yml  | 1 +
>  3 files changed, 7 insertions(+)
> 
> diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
> index cfba51c..f809e24 100644
> --- a/guests/vars/mappings.yml
> +++ b/guests/vars/mappings.yml
> @@ -514,6 +514,11 @@ mappings:
>      default: perl
>      FreeBSD: perl5
>  
> +  perl-Archive-Tar:
> +    deb: perl
> +    pkg: perl5
> +    rpm: perl-Archive-Tar
> +
>    perl-CPAN-Changes:
>      deb: libcpan-changes-perl
>      pkg: p5-CPAN-Changes
> diff --git a/guests/vars/projects/libvirt-perl.yml b/guests/vars/projects/libvirt-perl.yml
> index a19e232..2eb14f2 100644
> --- a/guests/vars/projects/libvirt-perl.yml
> +++ b/guests/vars/projects/libvirt-perl.yml
> @@ -1,5 +1,6 @@
>  ---
>  packages:
> +  - perl-Archive-Tar
>    - perl-CPAN-Changes
>    - perl-Module-Build
>    - perl-Test-Pod
> diff --git a/guests/vars/projects/libvirt-tck.yml b/guests/vars/projects/libvirt-tck.yml
> index 8d29c1c..dcccc0f 100644
> --- a/guests/vars/projects/libvirt-tck.yml
> +++ b/guests/vars/projects/libvirt-tck.yml
> @@ -1,5 +1,6 @@
>  ---
>  packages:
> +  - perl-Archive-Tar
>    - perl-Config-Record
>    - perl-Digest
>    - perl-Digest-MD5

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Wed, 2018-05-16 at 13:39 +0100, Daniel P. Berrangé wrote:
> On Tue, May 15, 2018 at 08:27:35PM +0200, Andrea Bolognani wrote:
> > Module::Build requires Archive::Tar in order to create
> > distribution archives, but on some operating systems there
> > is no explicit dependency dragging it the latter when
> > installing the former, so we need to handle it ourselves.
> 
> Hmm, any idea why we didn't see a failure already with libvirt-tck
> then ?

I thought it was because we were not building libvirt-tck on the
machines where libvirt-perl RPM build was failing, but it looks
like that's not the case, so it might have been a red herring.

I'll take another look.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Wed, 2018-05-16 at 15:56 +0200, Andrea Bolognani wrote:
> On Wed, 2018-05-16 at 13:39 +0100, Daniel P. Berrangé wrote:
> > On Tue, May 15, 2018 at 08:27:35PM +0200, Andrea Bolognani wrote:
> > > Module::Build requires Archive::Tar in order to create
> > > distribution archives, but on some operating systems there
> > > is no explicit dependency dragging it the latter when
> > > installing the former, so we need to handle it ourselves.
> > 
> > Hmm, any idea why we didn't see a failure already with libvirt-tck
> > then ?
> 
> I thought it was because we were not building libvirt-tck on the
> machines where libvirt-perl RPM build was failing, but it looks
> like that's not the case, so it might have been a red herring.
> 
> I'll take another look.

Okay, the thing is that on Fedora Module::Build drags in
Archive::Tar but on CentOS it doesn't; the reason we didn't see
any breakages is that we don't build libvirt-tck on CentOS.

tl;dr this patch is needed; the other one (Package::Constants)
      can be safely skipped.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list