[libvirt] [jenkins-ci PATCH 3/3] guests: Blacklist perl-ExtUtils-MakeMaker

Andrea Bolognani posted 3 patches 6 years, 12 months ago
[libvirt] [jenkins-ci PATCH 3/3] guests: Blacklist perl-ExtUtils-MakeMaker
Posted by Andrea Bolognani 6 years, 12 months ago
We no longer need it, so blacklist it to make sure existing
guests, where it was installed in the past, are cleaned up.

We'll be able to drop it from the blacklist, along with the
corresponding mapping, after a reasonable amount of time.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/vars/mappings.yml           | 1 -
 guests/vars/projects/blacklist.yml | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index f809e24..211440a 100644
--- a/guests/vars/mappings.yml
+++ b/guests/vars/mappings.yml
@@ -544,7 +544,6 @@ mappings:
     Ubuntu14:
 
   perl-ExtUtils-MakeMaker:
-    deb: perl-modules
     pkg: p5-ExtUtils-MakeMaker
     rpm: perl-ExtUtils-MakeMaker
 
diff --git a/guests/vars/projects/blacklist.yml b/guests/vars/projects/blacklist.yml
index e5f369c..ab76e0e 100644
--- a/guests/vars/projects/blacklist.yml
+++ b/guests/vars/projects/blacklist.yml
@@ -1,3 +1,4 @@
 ---
 packages:
   - nano
+  - perl-ExtUtils-MakeMaker
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH 3/3] guests: Blacklist perl-ExtUtils-MakeMaker
Posted by Daniel P. Berrangé 6 years, 12 months ago
On Tue, May 15, 2018 at 08:27:36PM +0200, Andrea Bolognani wrote:
> We no longer need it, so blacklist it to make sure existing
> guests, where it was installed in the past, are cleaned up.
> 
> We'll be able to drop it from the blacklist, along with the
> corresponding mapping, after a reasonable amount of time.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  guests/vars/mappings.yml           | 1 -
>  guests/vars/projects/blacklist.yml | 1 +
>  2 files changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH 3/3] guests: Blacklist perl-ExtUtils-MakeMaker
Posted by Andrea Bolognani 6 years, 12 months ago
On Wed, 2018-05-16 at 13:40 +0100, Daniel P. Berrangé wrote:
> On Tue, May 15, 2018 at 08:27:36PM +0200, Andrea Bolognani wrote:
> > We no longer need it, so blacklist it to make sure existing
> > guests, where it was installed in the past, are cleaned up.
> > 
> > We'll be able to drop it from the blacklist, along with the
> > corresponding mapping, after a reasonable amount of time.
> > 
> > Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> > ---
> >  guests/vars/mappings.yml           | 1 -
> >  guests/vars/projects/blacklist.yml | 1 +
> >  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Uff, Module::Build actually drags in ExtUtils::MakeMaker on
Fedora and CentOS, so all this does is introducing churn every
time guests are updated.

SNACK; an alternative patch is

  https://www.redhat.com/archives/libvir-list/2018-May/msg01298.html

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list