On Wed, May 16, 2018 at 10:52:38AM +0200, Andrea Bolognani wrote:
> Module::Build requires Package::Constants in order to create
> distribution archives, but on some operating systems there
> is no explicit dependency dragging it the latter when
> installing the former, so we need to handle it ourselves.
>
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
> It looks like this packages is not strictly necessary, but
> it gets dragged in on same operating systems so it might be
> a good idea to install it.
>
> guests/vars/mappings.yml | 6 ++++++
> guests/vars/projects/libvirt-perl.yml | 1 +
> guests/vars/projects/libvirt-tck.yml | 1 +
> 3 files changed, 8 insertions(+)
Again, curious why this isn't causing build failures already if it
is needed ?
>
> diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
> index 14e0150..8b4c018 100644
> --- a/guests/vars/mappings.yml
> +++ b/guests/vars/mappings.yml
> @@ -574,6 +574,12 @@ mappings:
> pkg: p5-Module-Build
> rpm: perl-Module-Build
>
> + perl-Package-Constants:
> + deb: libpackage-constants-perl
> + pkg: p5-Package-Constants
> + rpm: perl-Package-Constants
> + Ubuntu14:
> +
> perl-Sub-Uplevel:
> deb: libsub-uplevel-perl
> pkg: p5-Sub-Uplevel
> diff --git a/guests/vars/projects/libvirt-perl.yml b/guests/vars/projects/libvirt-perl.yml
> index 2eb14f2..043c2c7 100644
> --- a/guests/vars/projects/libvirt-perl.yml
> +++ b/guests/vars/projects/libvirt-perl.yml
> @@ -3,6 +3,7 @@ packages:
> - perl-Archive-Tar
> - perl-CPAN-Changes
> - perl-Module-Build
> + - perl-Package-Constants
> - perl-Test-Pod
> - perl-Test-Pod-Coverage
> - perl-Time-HiRes
> diff --git a/guests/vars/projects/libvirt-tck.yml b/guests/vars/projects/libvirt-tck.yml
> index dcccc0f..c0a2fa8 100644
> --- a/guests/vars/projects/libvirt-tck.yml
> +++ b/guests/vars/projects/libvirt-tck.yml
> @@ -8,6 +8,7 @@ packages:
> - perl-IO-Compress-Bzip2
> - perl-IO-String
> - perl-Module-Build
> + - perl-Package-Constants
> - perl-Sub-Uplevel
> - perl-TAP-Formatter-HTML
> - perl-TAP-Formatter-JUnit
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list