From nobody Mon Dec 15 03:24:47 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 15267277588351012.9324085581851; Sat, 19 May 2018 04:02:38 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1537E6A560; Sat, 19 May 2018 11:02:37 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 77CF41001F3C; Sat, 19 May 2018 11:02:36 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9EFB31801254; Sat, 19 May 2018 11:02:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4JB2Wsq028640 for ; Sat, 19 May 2018 07:02:32 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9C3485D9CA; Sat, 19 May 2018 11:02:32 +0000 (UTC) Received: from mx1.redhat.com (ext-mx19.extmail.prod.ext.phx2.redhat.com [10.5.110.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2C2B95D9C5; Sat, 19 May 2018 11:02:29 +0000 (UTC) Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DDA9C300343D; Sat, 19 May 2018 11:02:17 +0000 (UTC) Received: by mail-wr0-f193.google.com with SMTP id w18-v6so7818961wrn.6; Sat, 19 May 2018 04:02:17 -0700 (PDT) Received: from localhost.localdomain ([2a02:ab04:16c0:f00:a11:96ff:feef:3088]) by smtp.googlemail.com with ESMTPSA id c27-v6sm13545976wrg.75.2018.05.19.04.02.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 May 2018 04:02:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NvyKGQmh5FOltcY8BmALfwwqvXvvE582+J3bBW3JDiE=; b=pdnZFUbw/1IYFeWVeANLt5eO8hl7zvutIuBT3uLFwsauseQ4CNiPsMNuburVtheyMs AxhzY5AXafr5OZDhb2j9zWw9JDO5/DQfcq0kJZYh31481fG2DNLZCVTgePHc+QAzWNJ0 1b+gtoRFg4mpmBf4GZUpdvp6RzqM2JX0xjKtp+MgIuw62HG3XqXWslflpKg8Dz9xEesS uBrdA69HT+agnjIG2TLBJ8avAldFl875+HGBAEdYJLQJjr0srEyLspC9oMme0fLfjpRi 4YmSNAeDIm4yF9kHKVN7VGAjBXVEKFJ0zdGRtVVL3OoguHzVxe7BoQR5dNP05eUIDDmY 41Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NvyKGQmh5FOltcY8BmALfwwqvXvvE582+J3bBW3JDiE=; b=XZO+hUqJ4icQHWbNl3cLLwwlSsLAPUXL49xJ0lhui6WiG8To/Q9Z8Fenuj3EGCfdvH Jvy8gnwQJhKrd01yTgKfZx6U1OBBrV/fph/HUIVJy3mGU1hCI0IyixkQM5aY2VlSUCKO H0BBFSxbswR1KO6hWh3MhnJypgxFWUAjQJUgAmeq5EWEL/6osr1U5F08aLhH5WAMYYN0 H6C1lFzTuc2ivwcwYvRRZx6/KrorOWLmH9FEJv7MPrgFsxZQtMQCoRSYVNC/ssqEcDlb rJ4NcZlB53Buy5Xed9sfbRUCQnifN+xPUsGb5HSWtwgMU9YFVLRSOPN2vkYh1Diaomuo zRkQ== X-Gm-Message-State: ALKqPwcERyfX0nDOwN2TecB3h+OibQUyIWNLggtfWZJSgkCMxxWOOdVn Ame/hCM9Q9NcjHolj+mRl9k5d/sU X-Google-Smtp-Source: AB8JxZocTX5TcUX0Rcy4eFCPQKv2frXKk09KLFzJwVH9Fd53JEnWTubSneFG3ib7novmbZ6J7hKyqw== X-Received: by 2002:adf:a9e6:: with SMTP id b93-v6mr11464860wrd.234.1526727736273; Sat, 19 May 2018 04:02:16 -0700 (PDT) From: Filip Alac To: libvir-list@redhat.com Date: Sat, 19 May 2018 13:01:48 +0200 Message-Id: <20180519110151.5957-2-filipalac@gmail.com> In-Reply-To: <20180519110151.5957-1-filipalac@gmail.com> References: <20180519110151.5957-1-filipalac@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Sat, 19 May 2018 11:02:18 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Sat, 19 May 2018 11:02:18 +0000 (UTC) for IP:'209.85.128.193' DOMAIN:'mail-wr0-f193.google.com' HELO:'mail-wr0-f193.google.com' FROM:'filipalac@gmail.com' RCPT:'' X-RedHat-Spam-Score: 0.698 (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_PASS, T_DKIM_INVALID) 209.85.128.193 mail-wr0-f193.google.com 209.85.128.193 mail-wr0-f193.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.48 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Cc: phrdina@redhat.com, Filip Alac , eskultet@redhat.com Subject: [libvirt] [PATCH v2 1/4] Add 'output' codec in docs, conf and xml2xmltest X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Sat, 19 May 2018 11:02:37 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Add documentation for 'output' codec. Extend domain_conf with 'output' codec. Extend xml2xmltest for testing 'output' codec. Signed-off-by: Filip Alac --- Sorry for not the best mail subject. docs/formatdomain.html.in | 15 ++++++++++++--- docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 3 ++- src/conf/domain_conf.h | 1 + .../migration-in-params-in.xml | 1 + .../migration-out-nbd-in.xml | 1 + .../migration-out-nbd-out.xml | 1 + .../migration-out-params-in.xml | 1 + tests/qemustatusxml2xmldata/modern-in.xml | 1 + tests/qemuxml2xmloutdata/sound-device.xml | 2 ++ 10 files changed, 23 insertions(+), 4 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 0d0fd3b..665d0f2 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -7387,9 +7387,18 @@ qemu-kvm -net nic,model=3D? /dev/null with ich6 model can have optional sub-elements <codec> to attach various audio codecs to the audio device. If not specified, a default codec - will be attached to allow playback and recording. Valid values - are 'duplex' (advertise a line-in and a line-out) and 'micro' - (advertise a speaker and a microphone). + will be attached to allow playback and recording. +

+

+ Valid values are: +

+

+

    +
  • 'duplex' - advertise a line-in and a line-out
    • +
  • 'micro' - advertise a speaker and a microphone
    • +
  • 'output' - advertise a line-out + Since 4.4.0
    • +

=20 
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index 71ac3d0..f16e157 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -3824,6 +3824,7 @@
         
           duplex
           micro
+          output
         
       
     
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 3689ac0..f12c87d 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -529,7 +529,8 @@ VIR_ENUM_IMPL(virDomainSmartcard, VIR_DOMAIN_SMARTCARD_=
TYPE_LAST,
=20
 VIR_ENUM_IMPL(virDomainSoundCodec, VIR_DOMAIN_SOUND_CODEC_TYPE_LAST,
               "duplex",
-              "micro")
+              "micro",
+              "output")
=20
 VIR_ENUM_IMPL(virDomainSoundModel, VIR_DOMAIN_SOUND_MODEL_LAST,
               "sb16",
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index a78fdee..ee3285a 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -1335,6 +1335,7 @@ struct _virDomainInputDef {
 typedef enum {
     VIR_DOMAIN_SOUND_CODEC_TYPE_DUPLEX,
     VIR_DOMAIN_SOUND_CODEC_TYPE_MICRO,
+    VIR_DOMAIN_SOUND_CODEC_TYPE_OUTPUT,
=20
     VIR_DOMAIN_SOUND_CODEC_TYPE_LAST
 } virDomainSoundCodecType;
diff --git a/tests/qemustatusxml2xmldata/migration-in-params-in.xml b/tests=
/qemustatusxml2xmldata/migration-in-params-in.xml
index b0caa34..03f18b4 100644
--- a/tests/qemustatusxml2xmldata/migration-in-params-in.xml
+++ b/tests/qemustatusxml2xmldata/migration-in-params-in.xml
@@ -236,6 +236,7 @@
     
     
     
+    
   
   
     
diff --git a/tests/qemustatusxml2xmldata/migration-out-nbd-in.xml b/tests/q=
emustatusxml2xmldata/migration-out-nbd-in.xml
index 6d87c1e..636accf 100644
--- a/tests/qemustatusxml2xmldata/migration-out-nbd-in.xml
+++ b/tests/qemustatusxml2xmldata/migration-out-nbd-in.xml
@@ -229,6 +229,7 @@
     
     
     
+    
   
   
     
diff --git a/tests/qemustatusxml2xmldata/migration-out-nbd-out.xml b/tests/=
qemustatusxml2xmldata/migration-out-nbd-out.xml
index 05da1f8..315d8e4 100644
--- a/tests/qemustatusxml2xmldata/migration-out-nbd-out.xml
+++ b/tests/qemustatusxml2xmldata/migration-out-nbd-out.xml
@@ -229,6 +229,7 @@
     
     
     
+    
   
   
     
diff --git a/tests/qemustatusxml2xmldata/migration-out-params-in.xml b/test=
s/qemustatusxml2xmldata/migration-out-params-in.xml
index 1764979..ae20648 100644
--- a/tests/qemustatusxml2xmldata/migration-out-params-in.xml
+++ b/tests/qemustatusxml2xmldata/migration-out-params-in.xml
@@ -236,6 +236,7 @@
     
     
     
+    
   
   
     
diff --git a/tests/qemustatusxml2xmldata/modern-in.xml b/tests/qemustatusxm=
l2xmldata/modern-in.xml
index d63fcf7..5b7e2a3 100644
--- a/tests/qemustatusxml2xmldata/modern-in.xml
+++ b/tests/qemustatusxml2xmldata/modern-in.xml
@@ -232,6 +232,7 @@
     
     
     
+    
   
   
     
diff --git a/tests/qemuxml2xmloutdata/sound-device.xml b/tests/qemuxml2xmlo=
utdata/sound-device.xml
index 62336a8..cbf4d17 100644
--- a/tests/qemuxml2xmloutdata/sound-device.xml
+++ b/tests/qemuxml2xmloutdata/sound-device.xml
@@ -43,6 +43,7 @@
     
       
       
+      
       

     
     
@@ -51,6 +52,7 @@
     
       
       
+      
       

     
     
--=20
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list