From nobody Mon Dec 15 03:24:47 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1526727794054475.3184493601608; Sat, 19 May 2018 04:03:14 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7F0E9C0601EB; Sat, 19 May 2018 11:03:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 47DF030B7787; Sat, 19 May 2018 11:03:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 057784BB78; Sat, 19 May 2018 11:03:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4JB2bRm028656 for ; Sat, 19 May 2018 07:02:37 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4740C60181; Sat, 19 May 2018 11:02:37 +0000 (UTC) Received: from mx1.redhat.com (ext-mx16.extmail.prod.ext.phx2.redhat.com [10.5.110.45]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 60C0A600C4; Sat, 19 May 2018 11:02:34 +0000 (UTC) Received: from mail-wr0-f172.google.com (mail-wr0-f172.google.com [209.85.128.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 24F5F30D62C6; Sat, 19 May 2018 11:02:23 +0000 (UTC) Received: by mail-wr0-f172.google.com with SMTP id j1-v6so607435wrm.1; Sat, 19 May 2018 04:02:23 -0700 (PDT) Received: from localhost.localdomain ([2a02:ab04:16c0:f00:a11:96ff:feef:3088]) by smtp.googlemail.com with ESMTPSA id c27-v6sm13545976wrg.75.2018.05.19.04.02.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 May 2018 04:02:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Er59aT6XXnWNDON1qDTO5pJevKBDG+pfuDmmgzMZT/M=; b=Tqo1ABO1kYp1HBIgorx6XX+AC6SrsYlVezLnhX75o9Mln7Y14Y/t6QXurkNCGqHWIA SiY+hQg+lFxS6Byow3sF8TzyNj8mOf92xaNanDry4Q42V8JvwXGrg6ZhK/Zw1BK5YwGt BhEfk+aA8bVKdIsH46izHIP8wTGQHUVK/gXqNMG8QDne7LT25NWNs1Oi4Wbuc8cOeuma fVZ+8JcY4MZMXUs5w8Bo5SbIrRUo4ybrqppMkPA1Kkemh+9Nra/T5j+5ANXA4SAC8242 HEdbAvY98DOymRszD6fCb4cKPjsPGI/duRxLw0iZuP/PbuvrbpE+x64cTg1WE7lI0foW c2Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Er59aT6XXnWNDON1qDTO5pJevKBDG+pfuDmmgzMZT/M=; b=C6C2C7JQhsFnTQh1cGaWFlsVOzwExcByxM7JmxzeqGaM2puCqM60KnGcCCtZiSmlw3 qM/PjMZw/xeanIZuTX0YuKRzkxdA22Tr49vagq+pqJbI4TTCEWwWxEKi/RcQHllhFGsr kk89fiKXvRcXMb/s1tl2hirUmUHKp4XQfwPBV/h+L5D+sq9v5zZu/IenDMDxOtZIOosF Hl2fmX0JssiFnNiVnaGHza6TZ0flnVhFHdmemZFVKQmUEENyP1fiUf4Ppq82roBy9UY/ F5cPNrkenEFisZgmFJs2E4DCxpwJkLddPy5oBrhWqfDTq+h3T9kriFnWpKSKYGZhQ9k+ Y2iw== X-Gm-Message-State: ALKqPwcQ+8BIFP7dD74yv9R/YqkuctHiOF3WwUcTRdM3e1nZeJfDDgHz rJMYi+dCuQUwmF4KVaonZPM3L0/4 X-Google-Smtp-Source: AB8JxZrnZgJRKXCynOrTMIcZ3DFBgGDzF/EqS8C+hvRXy2zS1mmVcMD3S1ojbe3ANrqq0TYXcdfACw== X-Received: by 2002:adf:f652:: with SMTP id x18-v6mr1799344wrp.214.1526727741438; Sat, 19 May 2018 04:02:21 -0700 (PDT) From: Filip Alac To: libvir-list@redhat.com Date: Sat, 19 May 2018 13:01:50 +0200 Message-Id: <20180519110151.5957-4-filipalac@gmail.com> In-Reply-To: <20180519110151.5957-1-filipalac@gmail.com> References: <20180519110151.5957-1-filipalac@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Sat, 19 May 2018 11:02:23 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Sat, 19 May 2018 11:02:23 +0000 (UTC) for IP:'209.85.128.172' DOMAIN:'mail-wr0-f172.google.com' HELO:'mail-wr0-f172.google.com' FROM:'filipalac@gmail.com' RCPT:'' X-RedHat-Spam-Score: 0.698 (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_PASS, T_DKIM_INVALID) 209.85.128.172 mail-wr0-f172.google.com 209.85.128.172 mail-wr0-f172.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.45 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: phrdina@redhat.com, Filip Alac , eskultet@redhat.com Subject: [libvirt] [PATCH v2 3/4] qemu: Extend qemu_command with 'hda-output' X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Sat, 19 May 2018 11:03:13 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Extend qemu_command with 'hda-output' codec support. Extend xml2argvtest for testing 'output' codec. Signed-off-by: Filip Alac --- src/qemu/qemu_command.c | 5 ++++- tests/qemuxml2argvdata/sound-device.args | 2 ++ tests/qemuxml2argvdata/sound-device.xml | 2 ++ tests/qemuxml2argvtest.c | 1 + 4 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index f3724a7..2ddf128 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -139,7 +139,8 @@ VIR_ENUM_DECL(qemuSoundCodec) =20 VIR_ENUM_IMPL(qemuSoundCodec, VIR_DOMAIN_SOUND_CODEC_TYPE_LAST, "hda-duplex", - "hda-micro"); + "hda-micro", + "hda-output"); =20 VIR_ENUM_DECL(qemuControllerModelUSB) =20 @@ -4142,6 +4143,8 @@ qemuSoundCodecTypeToCaps(int type) return QEMU_CAPS_HDA_DUPLEX; case VIR_DOMAIN_SOUND_CODEC_TYPE_MICRO: return QEMU_CAPS_HDA_MICRO; + case VIR_DOMAIN_SOUND_CODEC_TYPE_OUTPUT: + return QEMU_CAPS_HDA_OUTPUT; default: return -1; } diff --git a/tests/qemuxml2argvdata/sound-device.args b/tests/qemuxml2argvd= ata/sound-device.args index ee8313b..f97050a 100644 --- a/tests/qemuxml2argvdata/sound-device.args +++ b/tests/qemuxml2argvdata/sound-device.args @@ -33,10 +33,12 @@ server,nowait \ -device intel-hda,id=3Dsound5,bus=3Dpci.0,addr=3D0x6 \ -device hda-micro,id=3Dsound5-codec0,bus=3Dsound5.0,cad=3D0 \ -device hda-duplex,id=3Dsound5-codec1,bus=3Dsound5.0,cad=3D1 \ +-device hda-output,id=3Dsound5-codec2,bus=3Dsound5.0,cad=3D2 \ -device ich9-intel-hda,id=3Dsound6,bus=3Dpci.0,addr=3D0x7 \ -device hda-duplex,id=3Dsound6-codec0,bus=3Dsound6.0,cad=3D0 \ -device ich9-intel-hda,id=3Dsound7,bus=3Dpci.0,addr=3D0x8 \ -device hda-micro,id=3Dsound7-codec0,bus=3Dsound7.0,cad=3D0 \ -device hda-duplex,id=3Dsound7-codec1,bus=3Dsound7.0,cad=3D1 \ +-device hda-output,id=3Dsound7-codec2,bus=3Dsound7.0,cad=3D2 \ -device usb-audio,id=3Dsound8,bus=3Dusb.0,port=3D1 \ -device virtio-balloon-pci,id=3Dballoon0,bus=3Dpci.0,addr=3D0x9 diff --git a/tests/qemuxml2argvdata/sound-device.xml b/tests/qemuxml2argvda= ta/sound-device.xml index bceb9d1..c544e93 100644 --- a/tests/qemuxml2argvdata/sound-device.xml +++ b/tests/qemuxml2argvdata/sound-device.xml @@ -32,11 +32,13 @@ + + diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 78454ac..e2eec96 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1515,6 +1515,7 @@ mymain(void) DO_TEST("sound", NONE); DO_TEST("sound-device", QEMU_CAPS_HDA_DUPLEX, QEMU_CAPS_HDA_MICRO, + QEMU_CAPS_HDA_OUTPUT, QEMU_CAPS_DEVICE_ICH9_INTEL_HDA, QEMU_CAPS_OBJECT_USB_AUDIO); DO_TEST("fs9p", NONE); --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list