[libvirt] [PATCH v2 1/8] schema: Add physical sizing grammer for storagevol grammar

John Ferlan posted 8 patches 7 years, 6 months ago
[libvirt] [PATCH v2 1/8] schema: Add physical sizing grammer for storagevol grammar
Posted by John Ferlan 7 years, 6 months ago
https://bugzilla.redhat.com/show_bug.cgi?id=1572491

Commit id '78661cb' added a physical output, but failed to update
the schema resulting in a failure from virt-xml-validate.

While at it - update the storagevolschemadata for the output.

Signed-off-by: John Ferlan <jferlan@redhat.com>
---
 docs/schemas/storagevol.rng                    | 5 +++++
 tests/storagevolschemadata/qcow2-no-source.xml | 1 +
 2 files changed, 6 insertions(+)

diff --git a/docs/schemas/storagevol.rng b/docs/schemas/storagevol.rng
index 7450547ffa..96d6b3e6d0 100644
--- a/docs/schemas/storagevol.rng
+++ b/docs/schemas/storagevol.rng
@@ -56,6 +56,11 @@
           <ref name='scaledInteger'/>
         </element>
       </optional>
+      <optional>
+        <element name='physical'>
+          <ref name='scaledInteger'/>
+        </element>
+      </optional>
     </interleave>
   </define>
 
diff --git a/tests/storagevolschemadata/qcow2-no-source.xml b/tests/storagevolschemadata/qcow2-no-source.xml
index 777294ec14..4958845594 100644
--- a/tests/storagevolschemadata/qcow2-no-source.xml
+++ b/tests/storagevolschemadata/qcow2-no-source.xml
@@ -3,6 +3,7 @@
   <key>/var/lib/libvirt/images/OtherDemo.img</key>
   <capacity unit="G">5</capacity>
   <allocation>294912</allocation>
+  <physical unit="G">5</physical>
   <target>
     <path>/var/lib/libvirt/images/OtherDemo.img</path>
     <format type='qcow2'/>
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 1/8] schema: Add physical sizing grammer for storagevol grammar
Posted by Ján Tomko 7 years, 6 months ago
s/grammer/element/ ?

On Mon, May 21, 2018 at 08:40:38AM -0400, John Ferlan wrote:
>https://bugzilla.redhat.com/show_bug.cgi?id=1572491
>
>Commit id '78661cb' added a physical output, but failed to update
>the schema resulting in a failure from virt-xml-validate.
>
>While at it - update the storagevolschemadata for the output.
>
>Signed-off-by: John Ferlan <jferlan@redhat.com>
>---
> docs/schemas/storagevol.rng                    | 5 +++++
> tests/storagevolschemadata/qcow2-no-source.xml | 1 +
> 2 files changed, 6 insertions(+)
>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list