From nobody Wed May 14 02:03:26 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1526913916287325.72140399450416; Mon, 21 May 2018 07:45:16 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D7B8630C2D28; Mon, 21 May 2018 14:45:13 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6855010018F9; Mon, 21 May 2018 14:45:13 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6A1144BB78; Mon, 21 May 2018 14:45:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4LEj9fT016084 for ; Mon, 21 May 2018 10:45:09 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9851B977A1; Mon, 21 May 2018 14:45:09 +0000 (UTC) Received: from mx1.redhat.com (ext-mx10.extmail.prod.ext.phx2.redhat.com [10.5.110.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 385BC977DC; Mon, 21 May 2018 14:45:07 +0000 (UTC) Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 78E01235399; Mon, 21 May 2018 14:44:55 +0000 (UTC) Received: by mail-wm0-f67.google.com with SMTP id f8-v6so27098269wmc.4; Mon, 21 May 2018 07:44:55 -0700 (PDT) Received: from filip.redhat.com ([213.175.37.12]) by smtp.googlemail.com with ESMTPSA id z63-v6sm19879946wrb.34.2018.05.21.07.44.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 May 2018 07:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+BzK1Ur3DdeOYrj/tqJ48NLfLMTJgUxWMbv5V+wY71A=; b=lBb7HWA4GtFBuqLmFV/zrXb+WqAG1b3R/RIJNzJG7XdBZF2ad0JFmc5etSzrqcKSr+ mVm0EncPP+/55FGwtHRGNrSeV3QzDsY40vTy1a3dURObOjW270q7apr1RiIrvHQOZYXJ 0Nb1jqH3sJlHN5iJ0l9pGoffbCmdu2mLI/ILJYFNppHTdSpM+JimQMci1lnS/CjaQJoQ Wbego6F0SP7AETmP78e9R4M9/HVX+0Nvd2SEiLFP1EawhHrcqCUL9bQBeU4zor6Rq8nT YB8Vz2DtoQU9pPg/v+nsZNFPfb8Kw3sFG1fYZ83pSN1gbWC3W0lIS5H0vhob4DelOSJs st1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+BzK1Ur3DdeOYrj/tqJ48NLfLMTJgUxWMbv5V+wY71A=; b=Y/6Qm4CsY9Plfov0YB20gqlnPd9uQbCeyksaCSY01t7rQ3QgzCLw/d8sw3J1JSD5S9 wOJ2aI3ioSRnw7HzvmniWsoFoiXFFIBY+WPZDf49Se1wjfpfTyJ5n/YmoaZ/d+i0uf3s KNLfI1P9k36bJEMsVRlsZaBBPhI01MpHyo4mVIkUFhl02Z6q5dMdyt0X4Yud1rX4Pgku Mqs8cm2Farg+gAAahxt2i24ex2cBAMpHJAgKxqlvOSByI+P0JJSGsOhiZ8Vk/XjgaR/o gpS/cnfh7bCclhNc2Tc6MgO14lPdYxHLUVxI1RiI/AYtEuD1EBNhX7B3X3Zrv5sCWIIQ sfAw== X-Gm-Message-State: ALKqPwe/Ah2aRvQTVsTEZIotOqpj7dzMCN9Yr4Tl9M4+6jCYyAFlPtv9 FVjUULhYhBZcBPyz6Uzy7usMcKSI X-Google-Smtp-Source: AB8JxZqZnqNRl7VSvYhBOmCTrMDcxHi+2MMbT6hDD7IwyWjT/8euDdKv0lMRLYzmGznWHYy355YX7Q== X-Received: by 2002:a1c:c2d5:: with SMTP id s204-v6mr10724134wmf.40.1526913893789; Mon, 21 May 2018 07:44:53 -0700 (PDT) From: Filip Alac To: libvir-list@redhat.com Date: Mon, 21 May 2018 16:44:25 +0200 Message-Id: <20180521144428.19256-2-filipalac@gmail.com> In-Reply-To: <20180521144428.19256-1-filipalac@gmail.com> References: <20180521144428.19256-1-filipalac@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 21 May 2018 14:44:56 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 21 May 2018 14:44:56 +0000 (UTC) for IP:'74.125.82.67' DOMAIN:'mail-wm0-f67.google.com' HELO:'mail-wm0-f67.google.com' FROM:'filipalac@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.281 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS, T_DKIM_INVALID) 74.125.82.67 mail-wm0-f67.google.com 74.125.82.67 mail-wm0-f67.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.39 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.27 X-loop: libvir-list@redhat.com Cc: phrdina@redhat.com, Filip Alac , eskultet@redhat.com Subject: [libvirt] [PATCH v3 1/4] Add 'output' codec in docs, qemu_command and qemu_capabilities X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Mon, 21 May 2018 14:45:14 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Add documentation for 'output' codec. Extend qemu_command with 'hda-output' codec support. Extend qemu_capabilities with 'hda-output' codec support. Signed-off-by: Filip Alac --- src/qemu/qemu_command.c | 5 ++++- docs/formatdomain.html.in | 15 ++++++++++++--- docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 3 ++- src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + 7 files changed, 24 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index f3724a7..2ddf128 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -139,7 +139,8 @@ VIR_ENUM_DECL(qemuSoundCodec) =20 VIR_ENUM_IMPL(qemuSoundCodec, VIR_DOMAIN_SOUND_CODEC_TYPE_LAST, "hda-duplex", - "hda-micro"); + "hda-micro", + "hda-output"); =20 VIR_ENUM_DECL(qemuControllerModelUSB) =20 @@ -4142,6 +4143,8 @@ qemuSoundCodecTypeToCaps(int type) return QEMU_CAPS_HDA_DUPLEX; case VIR_DOMAIN_SOUND_CODEC_TYPE_MICRO: return QEMU_CAPS_HDA_MICRO; + case VIR_DOMAIN_SOUND_CODEC_TYPE_OUTPUT: + return QEMU_CAPS_HDA_OUTPUT; default: return -1; } diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 0d0fd3b..665d0f2 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -7387,9 +7387,18 @@ qemu-kvm -net nic,model=3D? /dev/null with ich6 model can have optional sub-elements <codec> to attach various audio codecs to the audio device. If not specified, a default codec - will be attached to allow playback and recording. Valid values - are 'duplex' (advertise a line-in and a line-out) and 'micro' - (advertise a speaker and a microphone). + will be attached to allow playback and recording. +

+

+ Valid values are: +

+

+

    +
  • 'duplex' - advertise a line-in and a line-out
    • +
  • 'micro' - advertise a speaker and a microphone
    • +
  • 'output' - advertise a line-out + Since 4.4.0
    • +

=20 
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index 71ac3d0..f16e157 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -3824,6 +3824,7 @@
         
           duplex
           micro
+          output
         
       
     
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 3689ac0..f12c87d 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -529,7 +529,8 @@ VIR_ENUM_IMPL(virDomainSmartcard, VIR_DOMAIN_SMARTCARD_=
TYPE_LAST,
=20
 VIR_ENUM_IMPL(virDomainSoundCodec, VIR_DOMAIN_SOUND_CODEC_TYPE_LAST,
               "duplex",
-              "micro")
+              "micro",
+              "output")
=20
 VIR_ENUM_IMPL(virDomainSoundModel, VIR_DOMAIN_SOUND_MODEL_LAST,
               "sb16",
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index a78fdee..ee3285a 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -1335,6 +1335,7 @@ struct _virDomainInputDef {
 typedef enum {
     VIR_DOMAIN_SOUND_CODEC_TYPE_DUPLEX,
     VIR_DOMAIN_SOUND_CODEC_TYPE_MICRO,
+    VIR_DOMAIN_SOUND_CODEC_TYPE_OUTPUT,
=20
     VIR_DOMAIN_SOUND_CODEC_TYPE_LAST
 } virDomainSoundCodecType;
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index bface72..fda1630 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -487,6 +487,7 @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST,
               /* 300 */
               "sdl-gl",
               "screendump_device",
+              "hda-output",
     );
=20
=20
@@ -1117,6 +1118,7 @@ struct virQEMUCapsStringFlags virQEMUCapsObjectTypes[=
] =3D {
     { "pr-manager-helper", QEMU_CAPS_PR_MANAGER_HELPER },
     { "virtual-css-bridge", QEMU_CAPS_CCW },
     { "vfio-ccw", QEMU_CAPS_DEVICE_VFIO_CCW },
+    { "hda-output", QEMU_CAPS_HDA_OUTPUT },
 };
=20
 static struct virQEMUCapsStringFlags virQEMUCapsDevicePropsVirtioBalloon[]=
 =3D {
diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
index 6f99534..c0b497a 100644
--- a/src/qemu/qemu_capabilities.h
+++ b/src/qemu/qemu_capabilities.h
@@ -471,6 +471,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for =
syntax-check */
     /* 300 */
     QEMU_CAPS_SDL_GL, /* -sdl gl */
     QEMU_CAPS_SCREENDUMP_DEVICE, /* screendump command accepts device & he=
ad */
+    QEMU_CAPS_HDA_OUTPUT, /* -device hda-output */
=20
     QEMU_CAPS_LAST /* this must always be the last item */
 } virQEMUCapsFlags;
--=20
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list