Make sure all tests pass

[libvirt] [tck PATCH v2 08/13] scripts: skip luks test entirely for now

Posted by Daniel P. Berrangé 6 years, 11 months ago

Libvirt support for luks-inside-qcow2 is not quite ready yet.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 scripts/qemu/100-disk-encryption.t | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/qemu/100-disk-encryption.t b/scripts/qemu/100-disk-encryption.t
index 3b1651a..32e2adf 100644
--- a/scripts/qemu/100-disk-encryption.t
+++ b/scripts/qemu/100-disk-encryption.t
@@ -42,6 +42,7 @@ END { $tck->cleanup if $tck; }
 
 SKIP: {
     skip "Only relevant to QEMU driver", 8 unless $conn->get_type() eq "QEMU";
+    skip "Libvirt LUKS support isn't ready", 8;
 
 my $dir = $tck->bucket_dir("300-disk-encryption");
 my $disk = catfile($dir, "demo.qcow2");
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [tck PATCH v2 08/13] scripts: skip luks test entirely for now

Posted by Laine Stump 6 years, 11 months ago

On 05/21/2018 12:46 PM, Daniel P. Berrangé wrote:
> Libvirt support for luks-inside-qcow2 is not quite ready yet.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Reviewed-by: Laine Stump <laine@laine.org>

> ---
>  scripts/qemu/100-disk-encryption.t | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/scripts/qemu/100-disk-encryption.t b/scripts/qemu/100-disk-encryption.t
> index 3b1651a..32e2adf 100644
> --- a/scripts/qemu/100-disk-encryption.t
> +++ b/scripts/qemu/100-disk-encryption.t
> @@ -42,6 +42,7 @@ END { $tck->cleanup if $tck; }
>  
>  SKIP: {
>      skip "Only relevant to QEMU driver", 8 unless $conn->get_type() eq "QEMU";
> +    skip "Libvirt LUKS support isn't ready", 8;
>  
>  my $dir = $tck->bucket_dir("300-disk-encryption");
>  my $disk = catfile($dir, "demo.qcow2");


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list