From nobody Wed May 14 01:10:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1526921238708852.0920882626712; Mon, 21 May 2018 09:47:18 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CC8E319D2B1; Mon, 21 May 2018 16:47:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7F7BF30001D7; Mon, 21 May 2018 16:47:16 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 06D95180BACD; Mon, 21 May 2018 16:47:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4LGkh2D002724 for ; Mon, 21 May 2018 12:46:43 -0400 Received: by smtp.corp.redhat.com (Postfix) id 484362023582; Mon, 21 May 2018 16:46:43 +0000 (UTC) Received: from t460.redhat.com (unknown [10.33.36.105]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8FE2B2024506; Mon, 21 May 2018 16:46:42 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Mon, 21 May 2018 17:46:27 +0100 Message-Id: <20180521164631.7288-10-berrange@redhat.com> In-Reply-To: <20180521164631.7288-1-berrange@redhat.com> References: <20180521164631.7288-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [tck PATCH v2 09/13] scripts: fix the various hotplug tests X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 21 May 2018 16:47:17 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 PCI device hotunplug requires a running guest OS that cooperates with the ACPI unplug request. We must thus boot a real guest and wait for it to be ready before running the tests. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Laine Stump --- scripts/domain/200-disk-hotplug.t | 4 +++- scripts/domain/205-disk-hotplug-ordering.t | 5 ++++- scripts/domain/210-nic-hotplug.t | 5 ++++- scripts/domain/215-nic-hotplug-many.t | 5 ++++- 4 files changed, 15 insertions(+), 4 deletions(-) diff --git a/scripts/domain/200-disk-hotplug.t b/scripts/domain/200-disk-ho= tplug.t index 4c54b6b..87c0e53 100644 --- a/scripts/domain/200-disk-hotplug.t +++ b/scripts/domain/200-disk-hotplug.t @@ -41,12 +41,14 @@ END { } =20 =20 -my $xml =3D $tck->generic_domain(name =3D> "tck")->as_xml; +my $xml =3D $tck->generic_domain(name =3D> "tck", fullos =3D> 1)->as_xml; =20 diag "Creating a new transient domain"; my $dom; ok_domain(sub { $dom =3D $conn->create_domain($xml) }, "created transient = domain object"); =20 +diag "Waiting 30 seconds for guest to finish booting"; +sleep(30); =20 my $path =3D $tck->create_sparse_disk("200-disk-hotplug", "extra.img", 100= ); =20 diff --git a/scripts/domain/205-disk-hotplug-ordering.t b/scripts/domain/20= 5-disk-hotplug-ordering.t index bc4990f..b76cd54 100644 --- a/scripts/domain/205-disk-hotplug-ordering.t +++ b/scripts/domain/205-disk-hotplug-ordering.t @@ -41,12 +41,15 @@ END { } =20 =20 -my $xml =3D $tck->generic_domain(name =3D> "tck")->as_xml; +my $xml =3D $tck->generic_domain(name =3D> "tck", fullos =3D> 1)->as_xml; =20 diag "Creating a new transient domain"; my $dom; ok_domain(sub { $dom =3D $conn->create_domain($xml) }, "created transient = domain object"); =20 +diag "Waiting 30 seconds for guest to finish booting"; +sleep(30); + my $supported =3D 1; foreach my $dev (qw/vdb sdb/) { my $path =3D $tck->create_sparse_disk("200-disk-hotplug", "extra-$dev.= img", 100); diff --git a/scripts/domain/210-nic-hotplug.t b/scripts/domain/210-nic-hotp= lug.t index ac9048e..7106fd0 100644 --- a/scripts/domain/210-nic-hotplug.t +++ b/scripts/domain/210-nic-hotplug.t @@ -41,12 +41,15 @@ END { } =20 =20 -my $xml =3D $tck->generic_domain(name =3D> "tck")->as_xml; +my $xml =3D $tck->generic_domain(name =3D> "tck", fullos =3D> 1)->as_xml; =20 diag "Creating a new transient domain"; my $dom; ok_domain(sub { $dom =3D $conn->create_domain($xml) }, "created transient = domain object"); =20 +diag "Waiting 30 seconds for guest to finish booting"; +sleep(30); + my $mac =3D "00:11:22:33:44:55"; my $model =3D "virtio"; =20 diff --git a/scripts/domain/215-nic-hotplug-many.t b/scripts/domain/215-nic= -hotplug-many.t index eaa282a..558e6e7 100644 --- a/scripts/domain/215-nic-hotplug-many.t +++ b/scripts/domain/215-nic-hotplug-many.t @@ -41,12 +41,15 @@ END { } =20 =20 -my $xml =3D $tck->generic_domain(name =3D> "tck")->as_xml; +my $xml =3D $tck->generic_domain(name =3D> "tck", fullos =3D> 1)->as_xml; =20 diag "Creating a new transient domain"; my $dom; ok_domain(sub { $dom =3D $conn->create_domain($xml) }, "created transient = domain object"); =20 +diag "Waiting 30 seconds for guest to finish booting"; +sleep(30); + my $mac1 =3D "02:11:22:33:44:55"; my $mac2 =3D "02:12:22:33:44:55"; my $mac3 =3D "02:13:22:33:44:55"; --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list