From nobody Wed May 14 01:10:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1526921225981674.073957811016; Mon, 21 May 2018 09:47:05 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6BED3154B9F; Mon, 21 May 2018 16:47:04 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 31D182D026; Mon, 21 May 2018 16:47:04 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C01A04CAA0; Mon, 21 May 2018 16:47:03 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4LGkcNN002677 for ; Mon, 21 May 2018 12:46:38 -0400 Received: by smtp.corp.redhat.com (Postfix) id BB3092024CC7; Mon, 21 May 2018 16:46:37 +0000 (UTC) Received: from t460.redhat.com (unknown [10.33.36.105]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0B2C52024CCD; Mon, 21 May 2018 16:46:36 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Mon, 21 May 2018 17:46:22 +0100 Message-Id: <20180521164631.7288-5-berrange@redhat.com> In-Reply-To: <20180521164631.7288-1-berrange@redhat.com> References: <20180521164631.7288-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [tck PATCH v2 04/13] scripts: remove testing of 'cow' format X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 21 May 2018 16:47:05 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Support for the 'cow' format was delete from QEMU so will always throw an error if tried in libvirt with modern QEMU commit 550830f9351291c585c963204ad9127998b1c1ce Author: Stefan Hajnoczi Date: Tue Sep 16 15:24:24 2014 +0100 block: delete cow block driver Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Laine Stump --- scripts/storage/100-create-vol-dir.t | 19 +------------------ scripts/storage/200-clone-vol-dir.t | 4 ++-- 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/scripts/storage/100-create-vol-dir.t b/scripts/storage/100-cre= ate-vol-dir.t index 574e61a..952012c 100644 --- a/scripts/storage/100-create-vol-dir.t +++ b/scripts/storage/100-create-vol-dir.t @@ -28,7 +28,7 @@ with a filesystem pool. use strict; use warnings; =20 -use Test::More tests =3D> 33; +use Test::More tests =3D> 29; =20 use Sys::Virt::TCK; use Test::Exception; @@ -56,7 +56,6 @@ lives_ok(sub { $pool->create }, "started storage pool"); =20 my $volsparsexml =3D $tck->generic_volume("tck1", "raw", 1024*1024*50)->al= location(0)->as_xml; my $volallocxml =3D $tck->generic_volume("tck2", "raw", 1024*1024*50)->all= ocation(1024*1024*50)->as_xml; -my $volcowxml =3D $tck->generic_volume("tck3", "cow", 1024*1024*50)->as_xm= l; my $volqcow1xml =3D $tck->generic_volume("tck4", "qcow", 1024*1024*50)->as= _xml; my $volqcow2xml =3D $tck->generic_volume("tck5", "qcow2", 1024*1024*50)->a= s_xml; my $volvmdkxml =3D $tck->generic_volume("tck6", "vmdk", 1024*1024*50)->as_= xml; @@ -100,22 +99,6 @@ lives_ok(sub { $vol->delete(0) }, "deleted volume"); =20 =20 =20 -ok_volume { $vol =3D $pool->create_volume($volcowxml) } "create cow volume= "; - -$path =3D xpath($vol, "string(/volume/target/path)"); -$st =3D stat($path); - -ok($st, "path $path exists"); - -# Don't know exactly how large a cow empty file is, but it -# should be quite small :-) -ok($st->size < 1024*1024, "basic cow header is allocated"); - -lives_ok(sub { $vol->delete(0) }, "deleted volume"); - - - - ok_volume(sub { $vol =3D $pool->create_volume($volqcow1xml) }, "create qco= w volume"); =20 $path =3D xpath($vol, "string(/volume/target/path)"); diff --git a/scripts/storage/200-clone-vol-dir.t b/scripts/storage/200-clon= e-vol-dir.t index 28043fb..cc0daba 100644 --- a/scripts/storage/200-clone-vol-dir.t +++ b/scripts/storage/200-clone-vol-dir.t @@ -31,7 +31,7 @@ checksummed and validated use strict; use warnings; =20 -use Test::More tests =3D> 61; +use Test::More tests =3D> 52; =20 use Sys::Virt::TCK; use Test::Exception; @@ -103,7 +103,7 @@ my $srcdigest =3D &digest($path); =20 diag "Now testing cloning of various formats"; =20 -my @formats =3D qw(raw cow qcow qcow2 vmdk vpc); +my @formats =3D qw(raw qcow qcow2 vmdk vpc); =20 foreach my $format (@formats) { diag "Cloning source volume to $format format"; --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list