From nobody Wed May 14 07:00:21 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1526987617249110.31508210086497; Tue, 22 May 2018 04:13:37 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 857D43145703; Tue, 22 May 2018 11:13:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4DAE51057FA5; Tue, 22 May 2018 11:13:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D52A4180B536; Tue, 22 May 2018 11:13:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4MBDIdY000742 for ; Tue, 22 May 2018 07:13:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4FA87601A6; Tue, 22 May 2018 11:13:18 +0000 (UTC) Received: from mx1.redhat.com (ext-mx04.extmail.prod.ext.phx2.redhat.com [10.5.110.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2318A6016F; Tue, 22 May 2018 11:13:15 +0000 (UTC) Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DA0E3FA292; Tue, 22 May 2018 11:12:58 +0000 (UTC) Received: by mail-wm0-f51.google.com with SMTP id n10-v6so32303589wmc.1; Tue, 22 May 2018 04:12:58 -0700 (PDT) Received: from filip.redhat.com ([213.175.37.12]) by smtp.googlemail.com with ESMTPSA id a129-v6sm11405392wme.3.2018.05.22.04.12.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 May 2018 04:12:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jUMS91fLQeIbV45xBqa4GpoGXMTUV/EbIEqDEOoJKPo=; b=Lek0Ddp94cF3+9qvYAnqV8oyJFeLv+NOvklFNHWFOSldmqeFgE+HpLgT9d/dMl16nU KOduPy3xI9odv4QkMd0eQWJbpMgJdVZjdgaD1UmoG9rm/Rp/WjQBLsBEfEd2EXfI2Gdx krsyCLgxlDxrMVKNy1hZ1QN3qFQxJBQrapEHyH5xmZbou73nH3bwJ+QX1xx5+oEwjler W4zLDjhSTdRsR5pYmSdh5CymRBO5v06gzaRFNS+GaBR+DHnTdVJStedOWeK42c+kWcl2 4QRB/C2LPlTRtA2XqgHxbEzFHQPMIGGLVxcKaSf4h+FX5QybrE4MelIAx/fJaLQj+SQl HYHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jUMS91fLQeIbV45xBqa4GpoGXMTUV/EbIEqDEOoJKPo=; b=LjmKYIjvWKd1OCmXb1QfygYtmzD58q1JxqSIvRX6r3wo5vVQHgWc0eG5FSQrtUd+wq yLGgpM5B95nCDLnf35376QzSzFZIBUN4pwwrTobIuY/MgDUsEI7KMNuMQcDQnVwYdA+C htOc3m8OeQoQ1zh/RhBLwe7mAcQdR76Q9WhoA57O7FbU+EZzfELGftngtlZ3//7ihMFO bCcjlCAksmYRMjPMxWFOOPX85EdPBlFJo0YkkJQoasX5aa6P03CYMaGCLA7Ij229SGfZ CTYAeDl8uHHngAKVpV+giSnnrXMtfijNnm21Ort0ZC7HamvSlgaDuvgKmENvAvxpB7VM S4fQ== X-Gm-Message-State: ALKqPweCs52ycQXCzQHjivisBuZxmclMfkzi+fmi4XTexP5CDm0xZDqS crfGwxR0qgksduugsSAgCIyRuTd5 X-Google-Smtp-Source: AB8JxZpksk4U+d9XBLo6MZRPH7PtAGW8qcgm8i9JHPJIS0YyZ3E7Ht6O1DrrdOP7PAisxUToqupgCQ== X-Received: by 2002:a1c:7309:: with SMTP id d9-v6mr890465wmb.60.1526987577191; Tue, 22 May 2018 04:12:57 -0700 (PDT) From: Filip Alac To: libvir-list@redhat.com Date: Tue, 22 May 2018 13:12:32 +0200 Message-Id: <20180522111235.17725-2-filipalac@gmail.com> In-Reply-To: <20180522111235.17725-1-filipalac@gmail.com> References: <20180522111235.17725-1-filipalac@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 22 May 2018 11:12:59 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 22 May 2018 11:12:59 +0000 (UTC) for IP:'74.125.82.51' DOMAIN:'mail-wm0-f51.google.com' HELO:'mail-wm0-f51.google.com' FROM:'filipalac@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.281 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS, T_DKIM_INVALID) 74.125.82.51 mail-wm0-f51.google.com 74.125.82.51 mail-wm0-f51.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.28 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: phrdina@redhat.com, Filip Alac , eskultet@redhat.com Subject: [libvirt] [PATCH v4 1/4] conf: Introduce codec type 'output' X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Tue, 22 May 2018 11:13:36 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Introduce 'output' codec for ich6 and ich9 sound devices, which allow us to disable line-in for guest. Available in qemu since version 0.14. Signed-off-by: Filip Alac --- docs/formatdomain.html.in | 15 ++++++++++++--- docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 3 ++- src/conf/domain_conf.h | 1 + src/qemu/qemu_command.c | 3 ++- 5 files changed, 18 insertions(+), 5 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 0d0fd3b..665d0f2 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -7387,9 +7387,18 @@ qemu-kvm -net nic,model=3D? /dev/null with ich6 model can have optional sub-elements <codec> to attach various audio codecs to the audio device. If not specified, a default codec - will be attached to allow playback and recording. Valid values - are 'duplex' (advertise a line-in and a line-out) and 'micro' - (advertise a speaker and a microphone). + will be attached to allow playback and recording. +

+

+ Valid values are: +

+

+

    +
  • 'duplex' - advertise a line-in and a line-out
    • +
  • 'micro' - advertise a speaker and a microphone
    • +
  • 'output' - advertise a line-out + Since 4.4.0
    • +

=20 
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index 71ac3d0..f16e157 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -3824,6 +3824,7 @@
         
           duplex
           micro
+          output
         
       
     
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 3689ac0..f12c87d 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -529,7 +529,8 @@ VIR_ENUM_IMPL(virDomainSmartcard, VIR_DOMAIN_SMARTCARD_=
TYPE_LAST,
=20
 VIR_ENUM_IMPL(virDomainSoundCodec, VIR_DOMAIN_SOUND_CODEC_TYPE_LAST,
               "duplex",
-              "micro")
+              "micro",
+              "output")
=20
 VIR_ENUM_IMPL(virDomainSoundModel, VIR_DOMAIN_SOUND_MODEL_LAST,
               "sb16",
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index a78fdee..ee3285a 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -1335,6 +1335,7 @@ struct _virDomainInputDef {
 typedef enum {
     VIR_DOMAIN_SOUND_CODEC_TYPE_DUPLEX,
     VIR_DOMAIN_SOUND_CODEC_TYPE_MICRO,
+    VIR_DOMAIN_SOUND_CODEC_TYPE_OUTPUT,
=20
     VIR_DOMAIN_SOUND_CODEC_TYPE_LAST
 } virDomainSoundCodecType;
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 9da2d60..3b929c5 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -139,7 +139,8 @@ VIR_ENUM_DECL(qemuSoundCodec)
=20
 VIR_ENUM_IMPL(qemuSoundCodec, VIR_DOMAIN_SOUND_CODEC_TYPE_LAST,
               "hda-duplex",
-              "hda-micro");
+              "hda-micro",
+              "hda-output");
=20
 VIR_ENUM_DECL(qemuControllerModelUSB)
=20
--=20
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list