Add support for TPM emulator (for 4.5)

[libvirt] [PATCH v8 18/18] conf: Use virDomainChrSourceDefClear() rather than VIR_FREE()

Posted by Stefan Berger 6 years, 11 months ago

Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
---
 src/conf/domain_conf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 0b244b2eac..2a7be083f9 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -2605,7 +2605,7 @@ void virDomainTPMDefFree(virDomainTPMDefPtr def)
 
     switch (def->type) {
     case VIR_DOMAIN_TPM_TYPE_PASSTHROUGH:
-        VIR_FREE(def->data.passthrough.source.data.file.path);
+        virDomainChrSourceDefClear(&def->data.passthrough.source);
         break;
     case VIR_DOMAIN_TPM_TYPE_EMULATOR:
         virDomainChrSourceDefClear(&def->data.emulator.source);
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v8 18/18] conf: Use virDomainChrSourceDefClear() rather than VIR_FREE()

Posted by Ján Tomko 6 years, 11 months ago

On Thu, May 24, 2018 at 04:26:14PM -0400, Stefan Berger wrote:
>Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
>---
> src/conf/domain_conf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list