[libvirt] [PATCH v2 2/2] docs: bhyve: document guest CPU topology feature

Roman Bogorodskiy posted 2 patches 6 years, 11 months ago
[libvirt] [PATCH v2 2/2] docs: bhyve: document guest CPU topology feature
Posted by Roman Bogorodskiy 6 years, 11 months ago
Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
---
 docs/drvbhyve.html.in | 16 ++++++++++++++++
 docs/news.xml         |  9 +++++++++
 2 files changed, 25 insertions(+)

diff --git a/docs/drvbhyve.html.in b/docs/drvbhyve.html.in
index 5b5513d3df..78a291c6bb 100644
--- a/docs/drvbhyve.html.in
+++ b/docs/drvbhyve.html.in
@@ -444,6 +444,22 @@ be wired and cannot be swapped out as follows:</p>
     &lt;/memoryBacking&gt;
     ...
 &lt;/domain&gt;
+</pre>
+
+<h3><a id="cputopology">CPU topology</a></h3>
+
+<p><span class="since">Since 4.4.0</span>, it's possible to specify guest CPU topology, if bhyve
+supports that. Support for specifying guest CPU topology was added to bhyve in
+<a href="http://svnweb.freebsd.org/changeset/base/332298">r332298</a> for <i>-CURRENT</i>.
+Example:</p>
+<pre>
+&lt;domain type="bhyve"&gt;
+    ...
+    &lt;cpu&gt;
+      &lt;topology sockets='1' cores='2' threads='1'/&gt;
+    &lt;/cpu&gt;
+    ...
+&lt;/domain&gt;
 </pre>
 
   </body>
diff --git a/docs/news.xml b/docs/news.xml
index c45850f625..318bca5de1 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -94,6 +94,15 @@
           both new APIs consider capabilities of a specific hypervisor.
         </description>
       </change>
+      <change>
+        <summary>
+          bhyve: Support specifying guest CPU topology
+        </summary>
+        <description>
+          Bhyve's guest CPU topology could be specified using the
+          <code>&lt;cpu&gt;&lt;topology ../&gt;&lt;/cpu&gt;</code> element.
+        </description>
+      </change>
     </section>
     <section title="Improvements">
       <change>
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 2/2] docs: bhyve: document guest CPU topology feature
Posted by John Ferlan 6 years, 11 months ago

On 05/29/2018 12:57 PM, Roman Bogorodskiy wrote:
> Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
> ---
>  docs/drvbhyve.html.in | 16 ++++++++++++++++
>  docs/news.xml         |  9 +++++++++
>  2 files changed, 25 insertions(+)
> 

This should be split to keep the news.xml in its own patch.  You could
move the drvbhyve.html.in to patch 1

> diff --git a/docs/drvbhyve.html.in b/docs/drvbhyve.html.in
> index 5b5513d3df..78a291c6bb 100644
> --- a/docs/drvbhyve.html.in
> +++ b/docs/drvbhyve.html.in
> @@ -444,6 +444,22 @@ be wired and cannot be swapped out as follows:</p>
>      &lt;/memoryBacking&gt;
>      ...
>  &lt;/domain&gt;
> +</pre>
> +
> +<h3><a id="cputopology">CPU topology</a></h3>
> +
> +<p><span class="since">Since 4.4.0</span>, it's possible to specify guest CPU topology, if bhyve

4.5.0

> +supports that. Support for specifying guest CPU topology was added to bhyve in
> +<a href="http://svnweb.freebsd.org/changeset/base/332298">r332298</a> for <i>-CURRENT</i>.
> +Example:</p>
> +<pre>
> +&lt;domain type="bhyve"&gt;
> +    ...
> +    &lt;cpu&gt;
> +      &lt;topology sockets='1' cores='2' threads='1'/&gt;
> +    &lt;/cpu&gt;
> +    ...
> +&lt;/domain&gt;
>  </pre>
>  
>    </body>

> diff --git a/docs/news.xml b/docs/news.xml
> index c45850f625..318bca5de1 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml

This one will obviously require a merge with the current top - just be
careful to ensure it's in the 4.5.0 section and that syntax-check passes
- news.xml can be onery ;-).

Reviewed-by: John Ferlan <jferlan@redhat.com>

John


> @@ -94,6 +94,15 @@
>            both new APIs consider capabilities of a specific hypervisor.
>          </description>
>        </change>
> +      <change>
> +        <summary>
> +          bhyve: Support specifying guest CPU topology
> +        </summary>
> +        <description>
> +          Bhyve's guest CPU topology could be specified using the
> +          <code>&lt;cpu&gt;&lt;topology ../&gt;&lt;/cpu&gt;</code> element.
> +        </description>
> +      </change>
>      </section>
>      <section title="Improvements">
>        <change>
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list