Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 perl-Sys-Virt.spec.PL | 32 ++++++++++++++++++++++++++------
 1 file changed, 26 insertions(+), 6 deletions(-)

diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL
index dd26412..451af27 100644
--- a/perl-Sys-Virt.spec.PL
+++ b/perl-Sys-Virt.spec.PL
@@ -34,15 +34,35 @@ License:        GPLv2+ or Artistic
 URL:            https://metacpan.org/release/Sys-Virt
 Source0:        https://cpan.metacpan.org/authors/id/D/DA/DANBERR/Sys-Virt-v%{version}.tar.gz
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+# Build
+BuildRequires:  coreutils
+BuildRequires:  findutils
+BuildRequires:  gcc
+BuildRequires:  libvirt-devel >= %{version}
+BuildRequires:  make
+BuildRequires:  perl-interpreter
+BuildRequires:  perl-devel
+BuildRequires:  perl-generators
 BuildRequires:  perl(ExtUtils::CBuilder)
 BuildRequires:  perl(Module::Build)
-BuildRequires:  perl(Test::Pod)
-BuildRequires:  perl(Test::Pod::Coverage)
-BuildRequires:  perl(Test::CPAN::Changes)
-BuildRequires:  perl(XML::XPath)
+BuildRequires:  sed
+# Runtime
+BuildRequires:  perl(overload)
+BuildRequires:  perl(strict)
+BuildRequires:  perl(warnings)
+BuildRequires:  perl(XSLoader)
+# Tests only
+BuildRequires:  perl(base)
+BuildRequires:  perl(Sys::Hostname)
+BuildRequires:  perl(Test::More)
 BuildRequires:  perl(Time::HiRes)
-BuildRequires:  libvirt-devel >= %{version}
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+BuildRequires:  perl(XML::XPath)
+BuildRequires:  perl(XML::XPath::XMLParser)
+# Optional tests only
+BuildRequires:  perl(Test::CPAN::Changes)
+BuildRequires:  perl(Test::Pod) >= 1.00
+BuildRequires:  perl(Test::Pod::Coverage) >= 1.00
+Requires:       perl(:MODULE_COMPAT_%(eval "$(perl -V:version)"; echo $version))
 
 %description
 The Sys::Virt module provides a Perl XS binding to the libvirt virtual
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Tue, Jun 05, 2018 at 06:44:01PM +0100, Daniel P. Berrangé wrote:
>Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>---
> perl-Sys-Virt.spec.PL | 32 ++++++++++++++++++++++++++------
> 1 file changed, 26 insertions(+), 6 deletions(-)
>
>diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL
>index dd26412..451af27 100644
>--- a/perl-Sys-Virt.spec.PL
>+++ b/perl-Sys-Virt.spec.PL
>@@ -34,15 +34,35 @@ License:        GPLv2+ or Artistic
> URL:            https://metacpan.org/release/Sys-Virt
> Source0:        https://cpan.metacpan.org/authors/id/D/DA/DANBERR/Sys-Virt-v%{version}.tar.gz
> BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
>+# Build
>+BuildRequires:  coreutils

The core isn't what it used to be...

>+BuildRequires:  findutils
>+BuildRequires:  gcc

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list