[v2] RISC-V Guest Support

[libvirt] [PATCH v2 09/11] tests/captest: check RISC-V capabilities lookup

Posted by Lubomir Rintel 7 years ago

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 tests/vircapstest.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/vircapstest.c b/tests/vircapstest.c
index 1df3fa091f..e016e466d2 100644
--- a/tests/vircapstest.c
+++ b/tests/vircapstest.c
@@ -180,6 +180,12 @@ test_virCapsDomainDataLookupQEMU(const void *data ATTRIBUTE_UNUSED)
     CAPSCOMP(-1, VIR_ARCH_NONE, VIR_DOMAIN_VIRT_NONE, "/usr/bin/qemu-system-ppc64", NULL,
         VIR_DOMAIN_OSTYPE_HVM, VIR_ARCH_PPC64,
         VIR_DOMAIN_VIRT_QEMU, "/usr/bin/qemu-system-ppc64", "pseries");
+    CAPSCOMP(-1, VIR_ARCH_RISCV32, VIR_DOMAIN_VIRT_NONE, NULL, NULL,
+        VIR_DOMAIN_OSTYPE_HVM, VIR_ARCH_RISCV32,
+        VIR_DOMAIN_VIRT_QEMU, "/usr/bin/qemu-system-riscv32", "spike_v1.10");
+    CAPSCOMP(-1, VIR_ARCH_RISCV64, VIR_DOMAIN_VIRT_NONE, NULL, NULL,
+        VIR_DOMAIN_OSTYPE_HVM, VIR_ARCH_RISCV64,
+        VIR_DOMAIN_VIRT_QEMU, "/usr/bin/qemu-system-riscv64", "spike_v1.10");
     CAPSCOMP(-1, VIR_ARCH_NONE, VIR_DOMAIN_VIRT_NONE, NULL, "s390-virtio",
         VIR_DOMAIN_OSTYPE_HVM, VIR_ARCH_S390X,
         VIR_DOMAIN_VIRT_QEMU, "/usr/bin/qemu-system-s390x",
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 09/11] tests/captest: check RISC-V capabilities lookup

Posted by Andrea Bolognani 7 years ago

On Thu, 2018-06-14 at 22:32 +0200, Lubomir Rintel wrote:
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
>  tests/vircapstest.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tests/vircapstest.c b/tests/vircapstest.c
> index 1df3fa091f..e016e466d2 100644
> --- a/tests/vircapstest.c
> +++ b/tests/vircapstest.c
> @@ -180,6 +180,12 @@ test_virCapsDomainDataLookupQEMU(const void *data ATTRIBUTE_UNUSED)
>      CAPSCOMP(-1, VIR_ARCH_NONE, VIR_DOMAIN_VIRT_NONE, "/usr/bin/qemu-system-ppc64", NULL,
>          VIR_DOMAIN_OSTYPE_HVM, VIR_ARCH_PPC64,
>          VIR_DOMAIN_VIRT_QEMU, "/usr/bin/qemu-system-ppc64", "pseries");
> +    CAPSCOMP(-1, VIR_ARCH_RISCV32, VIR_DOMAIN_VIRT_NONE, NULL, NULL,
> +        VIR_DOMAIN_OSTYPE_HVM, VIR_ARCH_RISCV32,
> +        VIR_DOMAIN_VIRT_QEMU, "/usr/bin/qemu-system-riscv32", "spike_v1.10");
> +    CAPSCOMP(-1, VIR_ARCH_RISCV64, VIR_DOMAIN_VIRT_NONE, NULL, NULL,
> +        VIR_DOMAIN_OSTYPE_HVM, VIR_ARCH_RISCV64,
> +        VIR_DOMAIN_VIRT_QEMU, "/usr/bin/qemu-system-riscv64", "spike_v1.10");

So spike_v1.10 is the default machine type, uh?

That's a bummer, I would very much have preferred an Arm-style
situation where there is no default and you have to be explicit
instead... I guess that's out of our hands though :)

Looks good, just squash this one into 07/11 as well.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list