[libvirt] [PATCH v2 05/11] qemu: no USB by default on RISC-V machines

Lubomir Rintel posted 11 patches 7 years ago
Only 10 patches received!
There is a newer version of this series
[libvirt] [PATCH v2 05/11] qemu: no USB by default on RISC-V machines
Posted by Lubomir Rintel 7 years ago
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 src/qemu/qemu_domain.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 275090fb58..72b72364d5 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -3198,6 +3198,11 @@ qemuDomainDefAddDefaultDevices(virDomainDefPtr def,
         addPCIRoot = true;
         break;
 
+    case VIR_ARCH_RISCV32:
+    case VIR_ARCH_RISCV64:
+        addDefaultUSB = false;
+        break;
+
     case VIR_ARCH_S390:
     case VIR_ARCH_S390X:
         addDefaultUSB = false;
@@ -3224,8 +3229,6 @@ qemuDomainDefAddDefaultDevices(virDomainDefPtr def,
     case VIR_ARCH_OR32:
     case VIR_ARCH_PARISC:
     case VIR_ARCH_PARISC64:
-    case VIR_ARCH_RISCV32:
-    case VIR_ARCH_RISCV64:
     case VIR_ARCH_PPCLE:
     case VIR_ARCH_UNICORE32:
     case VIR_ARCH_XTENSA:
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 05/11] qemu: no USB by default on RISC-V machines
Posted by Andrea Bolognani 7 years ago
On Thu, 2018-06-14 at 22:32 +0200, Lubomir Rintel wrote:
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
>  src/qemu/qemu_domain.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index 275090fb58..72b72364d5 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
> @@ -3198,6 +3198,11 @@ qemuDomainDefAddDefaultDevices(virDomainDefPtr def,
>          addPCIRoot = true;
>          break;
>  
> +    case VIR_ARCH_RISCV32:
> +    case VIR_ARCH_RISCV64:
> +        addDefaultUSB = false;
> +        break;
> +
>      case VIR_ARCH_S390:
>      case VIR_ARCH_S390X:
>          addDefaultUSB = false;
> @@ -3224,8 +3229,6 @@ qemuDomainDefAddDefaultDevices(virDomainDefPtr def,
>      case VIR_ARCH_OR32:
>      case VIR_ARCH_PARISC:
>      case VIR_ARCH_PARISC64:
> -    case VIR_ARCH_RISCV32:
> -    case VIR_ARCH_RISCV64:
>      case VIR_ARCH_PPCLE:
>      case VIR_ARCH_UNICORE32:
>      case VIR_ARCH_XTENSA:

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

I forgot to mention this earlier, but this patch should go after
the ones (actually one, due to squashing :) that add RISC-V
architecture support to the test suite.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list