Build system fixes, cleanups and tweaks

[libvirt] [dbus PATCH 09/15] configure: Enable libtool

Posted by Andrea Bolognani 6 years, 10 months ago

We're going to start using libtool convenience libraries
in a second.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 .gitignore   | 9 +++++++++
 configure.ac | 1 +
 2 files changed, 10 insertions(+)

diff --git a/.gitignore b/.gitignore
index b792bac..48e0411 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,3 +1,5 @@
+*.la
+*.lo
 *.log
 *.o
 *.pyc
@@ -6,6 +8,7 @@
 *Makefile.in
 *~
 .deps
+.libs
 __pycache__
 vgcore.*
 
@@ -19,9 +22,15 @@ vgcore.*
 /config.log
 /config.status
 /configure
+/libtool
 /libvirt-dbus-*.tar.gz
 /libvirt-dbus.spec
 /m4/aclocal.m4
+/m4/libtool.m4
+/m4/ltoptions.m4
+/m4/ltsugar.m4
+/m4/ltversion.m4
+/m4/lt~obsolete.m4
 /run
 /stamp-h1
 
diff --git a/configure.ac b/configure.ac
index d7820dd..eef0834 100644
--- a/configure.ac
+++ b/configure.ac
@@ -35,6 +35,7 @@ AC_PROG_CC
 AC_PROG_MKDIR_P
 AM_PROG_CC_C_O
 AC_PROG_CC_STDC
+AC_PROG_LIBTOOL
 
 PKG_CHECK_MODULES(GIO2, gio-unix-2.0 >= GLIB2_REQUIRED)
 PKG_CHECK_MODULES(GLIB2, glib-2.0 >= GLIB2_REQUIRED)
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [dbus PATCH 09/15] configure: Enable libtool

Posted by Pavel Hrdina 6 years, 10 months ago

On Fri, Jun 29, 2018 at 06:01:16PM +0200, Andrea Bolognani wrote:
> We're going to start using libtool convenience libraries
> in a second.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  .gitignore   | 9 +++++++++
>  configure.ac | 1 +
>  2 files changed, 10 insertions(+)

We should also update spec file to include:

BuildRequires: libtool

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [dbus PATCH 09/15] configure: Enable libtool

Posted by Andrea Bolognani 6 years, 10 months ago

On Fri, 2018-06-29 at 20:15 +0200, Pavel Hrdina wrote:
> On Fri, Jun 29, 2018 at 06:01:16PM +0200, Andrea Bolognani wrote:
> > We're going to start using libtool convenience libraries
> > in a second.
>
> We should also update spec file to include:
> 
> BuildRequires: libtool

Fair enough :)

I'll squash that in.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list