[v2] PCI passthrough support on s390

[libvirt] [PATCH v2 RESEND 04/12] qemu: Enable PCI multi bus for S390 guests

Posted by Yi Min Zhao 7 years, 7 months ago

QEMU on s390 supports PCI multibus since forever. But zPCI, as extension
of PCI device on s390, is the significant capability. Only when zPCI
capability is existing, we consider QEMU supports PCI multibus properly.
So let enable PCI multibus only if zPCI is supported.

Signed-off-by: Yi Min Zhao <zyimin@linux.ibm.com>
Reviewed-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
Reviewed-by: Stefan Zimmermann <stzi@linux.ibm.com>
Reviewed-by: Bjoern Walk <bwalk@linux.vnet.ibm.com>
---
 src/qemu/qemu_capabilities.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 07f58fd014..7cba7eecdc 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -1760,6 +1760,10 @@ bool virQEMUCapsHasPCIMultiBus(virQEMUCapsPtr qemuCaps,
         return false;
     }
 
+    /* S390 supports PCI-multibus. */
+    if (ARCH_IS_S390(def->os.arch))
+        return true;
+
     /* If 'virt' supports PCI, it supports multibus.
      * No extra conditions here for simplicity.
      */
-- 
Yi Min

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 RESEND 04/12] qemu: Enable PCI multi bus for S390 guests

Posted by Ján Tomko 7 years, 6 months ago

On Tue, Jul 10, 2018 at 04:02:18PM +0800, Yi Min Zhao wrote:
>QEMU on s390 supports PCI multibus since forever. But zPCI, as extension
>of PCI device on s390, is the significant capability. Only when zPCI
>capability is existing, we consider QEMU supports PCI multibus properly.
>So let enable PCI multibus only if zPCI is supported.
>

This comment is now outdated, since we assume multibus in all cases
(even though it only makes sense with ZPCI)

Jano

>Signed-off-by: Yi Min Zhao <zyimin@linux.ibm.com>
>Reviewed-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
>Reviewed-by: Stefan Zimmermann <stzi@linux.ibm.com>
>Reviewed-by: Bjoern Walk <bwalk@linux.vnet.ibm.com>
>---
> src/qemu/qemu_capabilities.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
>index 07f58fd014..7cba7eecdc 100644
>--- a/src/qemu/qemu_capabilities.c
>+++ b/src/qemu/qemu_capabilities.c
>@@ -1760,6 +1760,10 @@ bool virQEMUCapsHasPCIMultiBus(virQEMUCapsPtr qemuCaps,
>         return false;
>     }
>
>+    /* S390 supports PCI-multibus. */
>+    if (ARCH_IS_S390(def->os.arch))
>+        return true;
>+
>     /* If 'virt' supports PCI, it supports multibus.
>      * No extra conditions here for simplicity.
>      */
>-- 
>Yi Min
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 RESEND 04/12] qemu: Enable PCI multi bus for S390 guests

Posted by Yi Min Zhao 7 years, 6 months ago


在 2018/7/23 下午7:36, Ján Tomko 写道:
> On Tue, Jul 10, 2018 at 04:02:18PM +0800, Yi Min Zhao wrote:
>> QEMU on s390 supports PCI multibus since forever. But zPCI, as extension
>> of PCI device on s390, is the significant capability. Only when zPCI
>> capability is existing, we consider QEMU supports PCI multibus properly.
>> So let enable PCI multibus only if zPCI is supported.
>>
>
> This comment is now outdated, since we assume multibus in all cases
> (even though it only makes sense with ZPCI)
>
> Jano
>
Thanks! I forgot this.
>> Signed-off-by: Yi Min Zhao <zyimin@linux.ibm.com>
>> Reviewed-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
>> Reviewed-by: Stefan Zimmermann <stzi@linux.ibm.com>
>> Reviewed-by: Bjoern Walk <bwalk@linux.vnet.ibm.com>
>> ---
>> src/qemu/qemu_capabilities.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
>> index 07f58fd014..7cba7eecdc 100644
>> --- a/src/qemu/qemu_capabilities.c
>> +++ b/src/qemu/qemu_capabilities.c
>> @@ -1760,6 +1760,10 @@ bool virQEMUCapsHasPCIMultiBus(virQEMUCapsPtr 
>> qemuCaps,
>>         return false;
>>     }
>>
>> +    /* S390 supports PCI-multibus. */
>> +    if (ARCH_IS_S390(def->os.arch))
>> +        return true;
>> +
>>     /* If 'virt' supports PCI, it supports multibus.
>>      * No extra conditions here for simplicity.
>>      */
>> -- 
>> Yi Min
>>
>> -- 
>> libvir-list mailing list
>> libvir-list@redhat.com
>> https://www.redhat.com/mailman/listinfo/libvir-list

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list