[v1] Change virFileIsCDROM to check cdrom status

[libvirt] [PATCH 0/2] Change virFileIsCDROM to check cdrom status

Han Han posted 2 patches 5 years, 9 months ago

Diff against v2 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180711025207.12842-1-hhan@redhat.com

Test syntax-check passed

There is a newer version of this series

src/libvirt_private.syms   |  2 +-
src/qemu/qemu_domain.c     |  4 ++--
src/storage/storage_util.c | 15 ++++++++++++-
src/util/virfile.c         | 44 ++++++++++++++++++++++++++++++++------
src/util/virfile.h         | 11 +++++++++-
5 files changed, 65 insertions(+), 11 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/2] Change virFileIsCDROM to check cdrom status

Posted by Han Han 5 years, 9 months ago

Refactor virFileIsCDROM to virFileCheckCDROM and now it could be used to
store cdrom status.

In libvirt, it gives general Input/Output error when reading a not ready
cdrom backend vol. This error should be replaced with warning just like the
warning of lacking backing file.

Han Han (2):
  util: Refactor virFileIsCDROM to virFileCheckCDROM
  storage: Improve error handling on cdrom backend

 src/libvirt_private.syms   |  2 +-
 src/qemu/qemu_domain.c     |  4 ++--
 src/storage/storage_util.c | 15 ++++++++++++-
 src/util/virfile.c         | 44 ++++++++++++++++++++++++++++++++------
 src/util/virfile.h         | 11 +++++++++-
 5 files changed, 65 insertions(+), 11 deletions(-)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] Change virFileIsCDROM to check cdrom status

Posted by Han Han 5 years, 9 months ago

Sorry I forget to add the former patch link. Please ignore these mails.

On Wed, Jul 11, 2018 at 10:52 AM, Han Han <hhan@redhat.com> wrote:

> Refactor virFileIsCDROM to virFileCheckCDROM and now it could be used to
> store cdrom status.
>
> In libvirt, it gives general Input/Output error when reading a not ready
> cdrom backend vol. This error should be replaced with warning just like the
> warning of lacking backing file.
>
> Han Han (2):
>   util: Refactor virFileIsCDROM to virFileCheckCDROM
>   storage: Improve error handling on cdrom backend
>
>  src/libvirt_private.syms   |  2 +-
>  src/qemu/qemu_domain.c     |  4 ++--
>  src/storage/storage_util.c | 15 ++++++++++++-
>  src/util/virfile.c         | 44 ++++++++++++++++++++++++++++++++------
>  src/util/virfile.h         | 11 +++++++++-
>  5 files changed, 65 insertions(+), 11 deletions(-)
>
> --
> 2.17.1
>
>


-- 
Best regards,
-----------------------------------
Han Han
Quality Engineer
Redhat.

Email: hhan@redhat.com
Phone: +861065339333
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list