Users will probably want to only work with a subset of
guests but, like any other customization, that should be
handled with local tweaks.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/inventory | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/guests/inventory b/guests/inventory
index 6ea43d9..9838d7c 100644
--- a/guests/inventory
+++ b/guests/inventory
@@ -1,8 +1,12 @@
 libvirt-centos-7
 libvirt-debian-8
 libvirt-debian-9
+libvirt-debian-sid
 libvirt-fedora-27
 libvirt-fedora-28
 libvirt-fedora-rawhide
 libvirt-freebsd-10
 libvirt-freebsd-11
+libvirt-freebsd-current
+libvirt-ubuntu-16
+libvirt-ubuntu-18
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Wed, Jul 11, 2018 at 12:59:13PM +0200, Andrea Bolognani wrote:
> Users will probably want to only work with a subset of
> guests but, like any other customization, that should be
> handled with local tweaks.
>
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  guests/inventory | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/guests/inventory b/guests/inventory
> index 6ea43d9..9838d7c 100644
> --- a/guests/inventory
> +++ b/guests/inventory
> @@ -1,8 +1,12 @@
>  libvirt-centos-7
>  libvirt-debian-8
>  libvirt-debian-9
> +libvirt-debian-sid
>  libvirt-fedora-27
>  libvirt-fedora-28
>  libvirt-fedora-rawhide
>  libvirt-freebsd-10
>  libvirt-freebsd-11
> +libvirt-freebsd-current

what does ^this map to?

> +libvirt-ubuntu-16
> +libvirt-ubuntu-18

shouldn't ubuntu 14 be mentioned here too?

Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Fri, 2018-07-13 at 10:55 +0200, Erik Skultety wrote:
> On Wed, Jul 11, 2018 at 12:59:13PM +0200, Andrea Bolognani wrote:
[...]
> >  libvirt-freebsd-10
> >  libvirt-freebsd-11
> > +libvirt-freebsd-current
> 
> what does ^this map to?

It doesn't map to any other FreeBSD version: -CURRENT it's just
the name for the in-development version, just like sid for Debian
and Rawhide for Fedora.

Snapshots are published periodically at

  http://ftp.freebsd.org/pub/FreeBSD/snapshots/VM-IMAGES/12.0-CURRENT/

and can be used just like any other FreeBSD disk image.

> > +libvirt-ubuntu-16
> > +libvirt-ubuntu-18
> 
> shouldn't ubuntu 14 be mentioned here too?

We were able to drop Ubuntu 14.04 support, at long last, about a
month ago with commit 19a3626d1bab :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Fri, Jul 13, 2018 at 11:07:23AM +0200, Andrea Bolognani wrote:
> On Fri, 2018-07-13 at 10:55 +0200, Erik Skultety wrote:
> > On Wed, Jul 11, 2018 at 12:59:13PM +0200, Andrea Bolognani wrote:
> [...]
> > >  libvirt-freebsd-10
> > >  libvirt-freebsd-11
> > > +libvirt-freebsd-current
> >
> > what does ^this map to?
>
> It doesn't map to any other FreeBSD version: -CURRENT it's just
> the name for the in-development version, just like sid for Debian
> and Rawhide for Fedora.
>
> Snapshots are published periodically at
>
>   http://ftp.freebsd.org/pub/FreeBSD/snapshots/VM-IMAGES/12.0-CURRENT/
>
> and can be used just like any other FreeBSD disk image.
>
> > > +libvirt-ubuntu-16
> > > +libvirt-ubuntu-18
> >
> > shouldn't ubuntu 14 be mentioned here too?
>
> We were able to drop Ubuntu 14.04 support, at long last, about a
> month ago with commit 19a3626d1bab :)

If only I pulled the master before I start digging /o\. Anyway, thanks for your
input.

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Fri, 2018-07-13 at 11:14 +0200, Erik Skultety wrote:
> > > > +libvirt-ubuntu-16
> > > > +libvirt-ubuntu-18
> > > 
> > > shouldn't ubuntu 14 be mentioned here too?
> > 
> > We were able to drop Ubuntu 14.04 support, at long last, about a
> > month ago with commit 19a3626d1bab :)
> 
> If only I pulled the master before I start digging /o\. Anyway, thanks for your
> input.

Eheh, don't worry about it. Thank *you* for the review! :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list