virt-xml-validate: Add schema for nwfilterbinding

[libvirt] [PATCH] virt-xml-validate: Add schema for nwfilterbinding

Posted by Han Han 5 years, 9 months ago

Add nwfilterbinding schema in virt-xml-validate for autoprobing.
Add document of nwfilterbinding schema in tools/virt-xml-validate.pod.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1600330

Signed-off-by: Han Han <hhan@redhat.com>
---
 tools/virt-xml-validate.in  | 3 +++
 tools/virt-xml-validate.pod | 4 ++++
 2 files changed, 7 insertions(+)

diff --git a/tools/virt-xml-validate.in b/tools/virt-xml-validate.in
index 81fde4d832..7513413189 100644
--- a/tools/virt-xml-validate.in
+++ b/tools/virt-xml-validate.in
@@ -77,6 +77,9 @@ if [ -z "$TYPE" ]; then
      *device*)
         TYPE="nodedev"
         ;;
+     *filterbinding*)
+        TYPE="nwfilterbinding"
+        ;;
      *filter*)
         TYPE="nwfilter"
         ;;
diff --git a/tools/virt-xml-validate.pod b/tools/virt-xml-validate.pod
index f8e67503fd..a51a57002a 100644
--- a/tools/virt-xml-validate.pod
+++ b/tools/virt-xml-validate.pod
@@ -52,6 +52,10 @@ The schema for the XML format used to declare driver capabilities
 
 The schema for the XML format used by network traffic filters
 
+=item C<nwfilterbinding>
+
+The schema for XML format used by network filter bindings.
+
 =item C<secret>
 
 The schema for the XML format used by secrets descriptions
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] virt-xml-validate: Add schema for nwfilterbinding

Posted by John Ferlan 5 years, 9 months ago


On 07/12/2018 09:39 PM, Han Han wrote:
> Add nwfilterbinding schema in virt-xml-validate for autoprobing.
> Add document of nwfilterbinding schema in tools/virt-xml-validate.pod.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1600330
> 
> Signed-off-by: Han Han <hhan@redhat.com>
> ---
>  tools/virt-xml-validate.in  | 3 +++
>  tools/virt-xml-validate.pod | 4 ++++
>  2 files changed, 7 insertions(+)
> 

With a slight adjustment to the commit message, putting the bz first and
removing the Resolves: label

Reviewed-by: John Ferlan <jferlan@redhat.com>

(I'll push in a bit - trying to figure the best way to handle the
inadvertent .gnulib submodule push - revert or just get the latest).

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list