[libvirt] [jenkins-ci PATCH] lcitool: Update OS when building Docker images

Andrea Bolognani posted 1 patch 5 years, 8 months ago
Failed in applying to current master (apply log)
guests/lcitool | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
[libvirt] [jenkins-ci PATCH] lcitool: Update OS when building Docker images
Posted by Andrea Bolognani 5 years, 8 months ago
The last build of the Fedora Rawhide Docker image failed
with

  Transaction check error:
    file /usr/lib64/libgdbm_compat.so.4.0.0 from install
    of gdbm-libs-1:1.16-1.fc29.x86_64 conflicts with file
    from package gdbm-1:1.14.1-3.fc28.x86_64

caused by the gdbm package having recently been split.

Especially with fast-moving distribution such as Fedora
Rawhide and Debian Sid, we can't rely on the base OS not
changing over time, so merely installing the packages we
need on top of that is not enough.

Additionally, updating the OS brings the Docker images
closer to the guests running on CentOS CI, which are
updated daily.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/lcitool | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/guests/lcitool b/guests/lcitool
index 22b08dd..33c1afe 100755
--- a/guests/lcitool
+++ b/guests/lcitool
@@ -478,13 +478,15 @@ class Application:
         if package_format == "deb":
             sys.stdout.write(textwrap.dedent("""
                 RUN apt-get update && \\
+                    apt-get dist-upgrade -y && \\
                     apt-get install -y ${PACKAGES} && \\
                     apt-get autoremove -y && \\
                     apt-get autoclean -y
             """))
         elif package_format == "rpm":
             sys.stdout.write(textwrap.dedent("""
-                RUN yum install -y ${PACKAGES} && \\
+                RUN yum update -y && \\
+                    yum install -y ${PACKAGES} && \\
                     yum autoremove -y && \\
                     yum clean all -y
             """))
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH] lcitool: Update OS when building Docker images
Posted by Erik Skultety 5 years, 7 months ago
On Fri, Jul 20, 2018 at 04:35:53PM +0200, Andrea Bolognani wrote:
> The last build of the Fedora Rawhide Docker image failed
> with
>
>   Transaction check error:
>     file /usr/lib64/libgdbm_compat.so.4.0.0 from install
>     of gdbm-libs-1:1.16-1.fc29.x86_64 conflicts with file
>     from package gdbm-1:1.14.1-3.fc28.x86_64
>
> caused by the gdbm package having recently been split.
>
> Especially with fast-moving distribution such as Fedora
> Rawhide and Debian Sid, we can't rely on the base OS not
> changing over time, so merely installing the packages we
> need on top of that is not enough.
>
> Additionally, updating the OS brings the Docker images
> closer to the guests running on CentOS CI, which are
> updated daily.
>
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH] lcitool: Update OS when building Docker images
Posted by Andrea Bolognani 5 years, 8 months ago
On Fri, 2018-07-20 at 16:35 +0200, Andrea Bolognani wrote:
> The last build of the Fedora Rawhide Docker image failed
> with
> 
>   Transaction check error:
>     file /usr/lib64/libgdbm_compat.so.4.0.0 from install
>     of gdbm-libs-1:1.16-1.fc29.x86_64 conflicts with file
>     from package gdbm-1:1.14.1-3.fc28.x86_64
> 
> caused by the gdbm package having recently been split.
> 
> Especially with fast-moving distribution such as Fedora
> Rawhide and Debian Sid, we can't rely on the base OS not
> changing over time, so merely installing the packages we
> need on top of that is not enough.

Ping?

Our Fedora Rawhide Docker image is now one and a half months old,
which makes it not very representative of the current status of
such a fast-moving development branch, as evidenced by the recent
MinGW build issues that were only spotted by CentOS CI and not by
Travis, and I can't trigger a new (successful) build without
merging this.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH] lcitool: Update OS when building Docker images
Posted by Pavel Hrdina 5 years, 7 months ago
On Fri, Jul 20, 2018 at 04:35:53PM +0200, Andrea Bolognani wrote:
> The last build of the Fedora Rawhide Docker image failed
> with
> 
>   Transaction check error:
>     file /usr/lib64/libgdbm_compat.so.4.0.0 from install
>     of gdbm-libs-1:1.16-1.fc29.x86_64 conflicts with file
>     from package gdbm-1:1.14.1-3.fc28.x86_64
> 
> caused by the gdbm package having recently been split.
> 
> Especially with fast-moving distribution such as Fedora
> Rawhide and Debian Sid, we can't rely on the base OS not
> changing over time, so merely installing the packages we
> need on top of that is not enough.
> 
> Additionally, updating the OS brings the Docker images
> closer to the guests running on CentOS CI, which are
> updated daily.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  guests/lcitool | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list