[libvirt] [PATCH v2 0/3] iscsi-direct: first part

clem@lse.epita.fr posted 3 patches 5 years, 8 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
configure.ac                               |   9 +-
m4/virt-libiscsi.m4                        |  30 ++
m4/virt-storage-iscsi-direct.m4            |  44 ++
src/conf/domain_conf.c                     |   4 +
src/conf/storage_conf.c                    |  33 +-
src/conf/storage_conf.h                    |   1 +
src/conf/virstorageobj.c                   |   2 +
src/storage/Makefile.inc.am                |  24 ++
src/storage/storage_backend.c              |   6 +
src/storage/storage_backend_iscsi_direct.c | 460 +++++++++++++++++++++
src/storage/storage_backend_iscsi_direct.h |   6 +
src/storage/storage_driver.c               |   1 +
tools/virsh-pool.c                         |   3 +
13 files changed, 618 insertions(+), 5 deletions(-)
create mode 100644 m4/virt-libiscsi.m4
create mode 100644 m4/virt-storage-iscsi-direct.m4
create mode 100644 src/storage/storage_backend_iscsi_direct.c
create mode 100644 src/storage/storage_backend_iscsi_direct.h
[libvirt] [PATCH v2 0/3] iscsi-direct: first part
Posted by clem@lse.epita.fr 5 years, 8 months ago
From: Clementine Hayat <clem@lse.epita.fr>

Hello,

This is the implementation of the iscsi-direct backend storage pool
version 2.
The documentation, some API calls and tests are still missing and will
be comming in a second part.

Best Regards,

-- 
Clementine Hayat

Clementine Hayat (3):
  configure: Introduce libiscsi in build system
  storage: Introduce iscsi_direct pool type
  storage: Implement iscsi_direct pool backend

 configure.ac                               |   9 +-
 m4/virt-libiscsi.m4                        |  30 ++
 m4/virt-storage-iscsi-direct.m4            |  44 ++
 src/conf/domain_conf.c                     |   4 +
 src/conf/storage_conf.c                    |  33 +-
 src/conf/storage_conf.h                    |   1 +
 src/conf/virstorageobj.c                   |   2 +
 src/storage/Makefile.inc.am                |  24 ++
 src/storage/storage_backend.c              |   6 +
 src/storage/storage_backend_iscsi_direct.c | 460 +++++++++++++++++++++
 src/storage/storage_backend_iscsi_direct.h |   6 +
 src/storage/storage_driver.c               |   1 +
 tools/virsh-pool.c                         |   3 +
 13 files changed, 618 insertions(+), 5 deletions(-)
 create mode 100644 m4/virt-libiscsi.m4
 create mode 100644 m4/virt-storage-iscsi-direct.m4
 create mode 100644 src/storage/storage_backend_iscsi_direct.c
 create mode 100644 src/storage/storage_backend_iscsi_direct.h

-- 
2.18.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 0/3] iscsi-direct: first part
Posted by Michal Privoznik 5 years, 8 months ago
On 07/23/2018 08:42 PM, clem@lse.epita.fr wrote:
> From: Clementine Hayat <clem@lse.epita.fr>
> 
> Hello,
> 
> This is the implementation of the iscsi-direct backend storage pool
> version 2.
> The documentation, some API calls and tests are still missing and will
> be comming in a second part.
> 
> Best Regards,
> 

When posting patches to the list, always make sure they are rebased onto
current HEAD. Fortunately, the merge conflict was small so I could
resolve it instantly.

Usually, the cover letter for any new version of patches looks like this:

There is a link to previous version (at least),
there is a diff to previous version.

A good example looks something like this:

https://www.redhat.com/archives/libvir-list/2018-July/msg01343.html

Also, no need to put extra -- at the end of the cover letter - MTAs
usually interpret it as end of git commit message.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list