From nobody Wed May 8 21:32:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1532444511486138.6483040893993; Tue, 24 Jul 2018 08:01:51 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7A5443082A3F; Tue, 24 Jul 2018 15:01:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 23A1ACD070; Tue, 24 Jul 2018 15:01:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3830E18037ED; Tue, 24 Jul 2018 15:01:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w6OF1hXh024082 for ; Tue, 24 Jul 2018 11:01:43 -0400 Received: by smtp.corp.redhat.com (Postfix) id B8CA42708C; Tue, 24 Jul 2018 15:01:43 +0000 (UTC) Received: from mx1.redhat.com (ext-mx17.extmail.prod.ext.phx2.redhat.com [10.5.110.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B186716BE7 for ; Tue, 24 Jul 2018 15:01:41 +0000 (UTC) Received: from mail-qt0-f174.google.com (mail-qt0-f174.google.com [209.85.216.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4578130E6851 for ; Tue, 24 Jul 2018 15:01:30 +0000 (UTC) Received: by mail-qt0-f174.google.com with SMTP id b15-v6so4386157qtp.11 for ; Tue, 24 Jul 2018 08:01:30 -0700 (PDT) Received: from localhost.localdomain (177.207.219.111.static.gvt.net.br. [177.207.219.111]) by smtp.gmail.com with ESMTPSA id b62-v6sm9209099qkj.48.2018.07.24.08.01.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Jul 2018 08:01:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=m0DwUR+2AOq9ufCaXZYNSVwsw01q2KL9EvCnSxtD5fw=; b=PXRuUoNAeidrOz/jXnJKfsUbmbHBBfYUiNzxD0dqJac9zqGrvCGRBasI5R/5OWTlv3 8PUa/97m/A/XkBAXGv6DcUyKpKhUrSXvxjigJrEjA0+ZCzeJWF5H03U6TEB1noACgLX4 z3hblZCh8+QaXW70y7LxamOJZUXKYw0WYa+l0x4h1vhiSvJ8Z0Jey9WBuE7j/YXXLL0b V0xbl0ZDdO2ObpsQFbwxls7AIJHWbHjsXCLRNBqdzakONPJ/NpjL8+EPfTxt5yI04tMz RQ1TJDBHFq20GgoajirXLhWiEbuoL1OVMsHbH80sOuomdIoXU2bzwT+Ax2iEX7HKbQ8l ZVRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=m0DwUR+2AOq9ufCaXZYNSVwsw01q2KL9EvCnSxtD5fw=; b=XGKB87Vjg3bJCZSanIq1c+Jnf763ojE7zzL8X34pxa79oBO9CSnVgrjeRyAFtjUcc3 9NM+/DwKbq4AQTXNvaWuQWIc6GTMm5CmeMhRCLwZfvq+o3dZ8OXvLgivVk6xjoWQx4kr Oxu4BGPeXvO6RZLeCsX4b2C3B5i5CIfw+6JpSU4aXMash8sR1se9klMvHwpWb41TqKju on7vGntlcbspTGM4332HJoaf91IRZtucFgui/s7y/bNHEjQiFykL0rPV7CTAE02ovwbO ZeMwjf/FFtFvQM+5lQRJ8+2K2+UvuFsyZKoaUlzm9zdqq1EMV1eYS4TxpsHMPdb8R4UF kTSA== X-Gm-Message-State: AOUpUlHmRWRKZUrSb3Oo40fdRFSDaTTs5dmDdSdLH1EhOMZ+R7cJzk+J Vkfjh1+t5MRIsokVXGWnKYck84BS X-Google-Smtp-Source: AAOMgpekvIiOz6aSywcwAbyRsk+NIiXikg/Re1z9zlk9EpGl/H5waM1OJqzUAMM4ljx+Kixu8Yuw/g== X-Received: by 2002:aed:2a4a:: with SMTP id k10-v6mr16823562qtf.102.1532444488858; Tue, 24 Jul 2018 08:01:28 -0700 (PDT) From: Marcos Paulo de Souza To: libvir-list@redhat.com Date: Tue, 24 Jul 2018 00:15:51 +0000 Message-Id: <20180724001551.10446-1-marcos.souza.org@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 24 Jul 2018 15:01:30 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 24 Jul 2018 15:01:30 +0000 (UTC) for IP:'209.85.216.174' DOMAIN:'mail-qt0-f174.google.com' HELO:'mail-qt0-f174.google.com' FROM:'marcos.souza.org@gmail.com' RCPT:'' X-RedHat-Spam-Score: 2.085 ** (DATE_IN_PAST_12_24, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS, T_DKIM_INVALID) 209.85.216.174 mail-qt0-f174.google.com 209.85.216.174 mail-qt0-f174.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.46 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: Marcos Paulo de Souza Subject: [libvirt] [PATCH] esx storage: Fix typo lsilogic -> lsiLogic X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Tue, 24 Jul 2018 15:01:47 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Commit 77298458d027db4d3e082213355e2d792f65158d changed the esx storage adapter from busLogic to lsilogic, introducing a typo. Changing it back to lsiLogic (with capital L) solves the issue. With this change, libvirt ca= n now create volumes in ESX again. Thanks to Jaroslav Suchanek who figured out what was the issue in the first place. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=3D1571759 Signed-off-by: Marcos Paulo de Souza --- src/esx/esx_storage_backend_vmfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/esx/esx_storage_backend_vmfs.c b/src/esx/esx_storage_backe= nd_vmfs.c index 630a6aa8c9..bb2de4b69f 100644 --- a/src/esx/esx_storage_backend_vmfs.c +++ b/src/esx/esx_storage_backend_vmfs.c @@ -967,9 +967,9 @@ esxStorageVolCreateXML(virStoragePoolPtr pool, /* * FIXME: The adapter type is a required parameter, but there is no * way to let the user specify it in the volume XML config. Theref= ore, - * default to 'lsilogic' here. + * default to 'lsiLogic' here. */ - virtualDiskSpec->adapterType =3D (char *)"lsilogic"; + virtualDiskSpec->adapterType =3D (char *)"lsiLogic"; =20 virtualDiskSpec->capacityKb->value =3D VIR_DIV_UP(def->target.capacity, 1024); /* Scale from byte to ki= lobyte */ --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list