travis: update some of the test matrix versions to moderize coverage

[libvirt] [go PATCH] travis: update some of the test matrix versions to moderize coverage

Posted by Daniel P. Berrangé 5 years, 8 months ago

Add latest go 1.10 to matrix and (arbitrarily) trim out 1.6 and 1.8

Add libvirt 4.5.0 and (arbitrarily) trim out 1.2.10

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 .travis.yml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 1bdb48f..7cd7587 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -5,17 +5,16 @@ sudo: require
 
 go:
   - 1.5
-  - 1.6
   - 1.7
-  - 1.8
   - 1.9
+  - 1.10
 
 env:
   - LIBVIRT=1.2.0  EXT=gz
-  - LIBVIRT=1.2.10 EXT=gz
   - LIBVIRT=1.2.20 EXT=gz
   - LIBVIRT=2.5.0  EXT=xz
   - LIBVIRT=3.6.0  EXT=xz
+  - LIBVIRT=4.5.0  EXT=xz
 
 install:
   - sudo apt-get -qqy build-dep libvirt
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [go PATCH] travis: update some of the test matrix versions to moderize coverage

Posted by Andrea Bolognani 5 years, 8 months ago

On Wed, 2018-07-25 at 12:58 +0100, Daniel P. Berrangé wrote:
> Add latest go 1.10 to matrix and (arbitrarily) trim out 1.6 and 1.8
> 
> Add libvirt 4.5.0 and (arbitrarily) trim out 1.2.10
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  .travis.yml | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 1bdb48f..7cd7587 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -5,17 +5,16 @@ sudo: require
>  
>  go:
>    - 1.5
> -  - 1.6
>    - 1.7
> -  - 1.8
>    - 1.9
> +  - 1.10
>  
>  env:
>    - LIBVIRT=1.2.0  EXT=gz
> -  - LIBVIRT=1.2.10 EXT=gz
>    - LIBVIRT=1.2.20 EXT=gz
>    - LIBVIRT=2.5.0  EXT=xz
>    - LIBVIRT=3.6.0  EXT=xz
> +  - LIBVIRT=4.5.0  EXT=xz

Looks sane enough, so I'll (arbitrarily) give it a

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [go PATCH] travis: update some of the test matrix versions to moderize coverage

Posted by Daniel P. Berrangé 5 years, 8 months ago

On Wed, Jul 25, 2018 at 02:12:26PM +0200, Andrea Bolognani wrote:
> On Wed, 2018-07-25 at 12:58 +0100, Daniel P. Berrangé wrote:
> > Add latest go 1.10 to matrix and (arbitrarily) trim out 1.6 and 1.8
> > 
> > Add libvirt 4.5.0 and (arbitrarily) trim out 1.2.10
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >  .travis.yml | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/.travis.yml b/.travis.yml
> > index 1bdb48f..7cd7587 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -5,17 +5,16 @@ sudo: require
> >  
> >  go:
> >    - 1.5
> > -  - 1.6
> >    - 1.7
> > -  - 1.8
> >    - 1.9
> > +  - 1.10

Sigh, this gets interpreted as a number, which is 1.1, so I need to
add quotes to force it to be a string.

> >  
> >  env:
> >    - LIBVIRT=1.2.0  EXT=gz
> > -  - LIBVIRT=1.2.10 EXT=gz
> >    - LIBVIRT=1.2.20 EXT=gz
> >    - LIBVIRT=2.5.0  EXT=xz
> >    - LIBVIRT=3.6.0  EXT=xz
> > +  - LIBVIRT=4.5.0  EXT=xz
> 
> Looks sane enough, so I'll (arbitrarily) give it a
> 
>   Reviewed-by: Andrea Bolognani <abologna@redhat.com>
> 
> -- 
> Andrea Bolognani / Red Hat / Virtualization
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [go PATCH] travis: update some of the test matrix versions to moderize coverage

Posted by Andrea Bolognani 5 years, 8 months ago

On Wed, 2018-07-25 at 13:26 +0100, Daniel P. Berrangé wrote:
> > >  go:
> > >    - 1.5
> > > -  - 1.6
> > >    - 1.7
> > > -  - 1.8
> > >    - 1.9
> > > +  - 1.10
> 
> Sigh, this gets interpreted as a number, which is 1.1, so I need to
> add quotes to force it to be a string.

Fair enough... Please add quotes around all of them for consistency's
sake while at it.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list