[libvirt] [dbus PATCH 0/4] Fix 'make check' with libvirt 3.0.0

Andrea Bolognani posted 4 patches 5 years, 8 months ago
Failed in applying to current master (apply log)
tests/libvirttest.py  | 17 ++++++++++++++++-
tests/test_connect.py | 27 ---------------------------
tests/test_nodedev.py | 26 +++++++++++++++++++++++++-
tests/xmldata.py      |  2 +-
4 files changed, 42 insertions(+), 30 deletions(-)
[libvirt] [dbus PATCH 0/4] Fix 'make check' with libvirt 3.0.0
Posted by Andrea Bolognani 5 years, 8 months ago
Andrea Bolognani (4):
  tests: Drop pytest.mark.usefixtures from test_nodedev
  tests: Move some test cases to test_nodedev
  tests: Don't open-code node_device_create()
  tests: Make node_device_create() work with libvirt 3.0.0

 tests/libvirttest.py  | 17 ++++++++++++++++-
 tests/test_connect.py | 27 ---------------------------
 tests/test_nodedev.py | 26 +++++++++++++++++++++++++-
 tests/xmldata.py      |  2 +-
 4 files changed, 42 insertions(+), 30 deletions(-)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [dbus PATCH 0/4] Fix 'make check' with libvirt 3.0.0
Posted by Katerina Koukiou 5 years, 8 months ago
On Fri, Jul 27, 2018 at 02:37:37PM +0200, Andrea Bolognani wrote:
> Andrea Bolognani (4):
>   tests: Drop pytest.mark.usefixtures from test_nodedev
>   tests: Move some test cases to test_nodedev
>   tests: Don't open-code node_device_create()
>   tests: Make node_device_create() work with libvirt 3.0.0
> 
>  tests/libvirttest.py  | 17 ++++++++++++++++-
>  tests/test_connect.py | 27 ---------------------------
>  tests/test_nodedev.py | 26 +++++++++++++++++++++++++-
>  tests/xmldata.py      |  2 +-
>  4 files changed, 42 insertions(+), 30 deletions(-)
> 
> -- 
> 2.17.1
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

Please remove the second patch moving the test file - see reasoning there.
So the third patch should be adjusted but in the original file, test_connect.py

With these fixed:
Reviewed-by: Katerina Koukiou <kkoukiou@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list