[libvirt] [jenkins-ci PATCH] projects: restrict virt-viewer RPMs to Fedora >= 28

Daniel P. Berrangé posted 1 patch 5 years, 9 months ago
Failed in applying to current master (apply log)
projects/virt-viewer.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
[libvirt] [jenkins-ci PATCH] projects: restrict virt-viewer RPMs to Fedora >= 28
Posted by Daniel P. Berrangé 5 years, 9 months ago
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 projects/virt-viewer.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/projects/virt-viewer.yaml b/projects/virt-viewer.yaml
index 12335f3..25474f2 100644
--- a/projects/virt-viewer.yaml
+++ b/projects/virt-viewer.yaml
@@ -13,7 +13,9 @@
           parent_jobs: 'virt-viewer-master-syntax-check'
       - autotools-rpm-job:
           parent_jobs: 'virt-viewer-master-check'
-          machines: '{rpm_machines}'
+          machines:
+	    - libvirt-fedora-28
+	    - libvirt-fedora-rawhide
       - autotools-build-job:
           parent_jobs: 'libvirt-glib-master-build-mingw32'
           variant: -mingw32
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH] projects: restrict virt-viewer RPMs to Fedora >= 28
Posted by Andrea Bolognani 5 years, 9 months ago
On Mon, 2018-07-30 at 11:47 +0100, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

A quick note in the commit message explaining why this change is
necessary would certainly be nice.

[...]
>        - autotools-rpm-job:
>            parent_jobs: 'virt-viewer-master-check'
> -          machines: '{rpm_machines}'
> +          machines:
> +	    - libvirt-fedora-28
> +	    - libvirt-fedora-rawhide

Please use spaces instead of tabs for indentation: in addition to
the usual consistency concerns, I don't think your version would
work at all.

With at least the indentation issues fixed,

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list