From nobody Wed May 8 00:42:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1533256110882546.3651195572655; Thu, 2 Aug 2018 17:28:30 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0E3BC8CA9; Fri, 3 Aug 2018 00:28:28 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C76411691A; Fri, 3 Aug 2018 00:28:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EE5A44A460; Fri, 3 Aug 2018 00:28:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w730SLT1008734 for ; Thu, 2 Aug 2018 20:28:21 -0400 Received: by smtp.corp.redhat.com (Postfix) id B857AD3CD3; Fri, 3 Aug 2018 00:28:21 +0000 (UTC) Received: from mx1.redhat.com (ext-mx13.extmail.prod.ext.phx2.redhat.com [10.5.110.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B1B38D3CF0 for ; Fri, 3 Aug 2018 00:28:20 +0000 (UTC) Received: from mail-qt0-f176.google.com (mail-qt0-f176.google.com [209.85.216.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 38B933082148 for ; Fri, 3 Aug 2018 00:28:19 +0000 (UTC) Received: by mail-qt0-f176.google.com with SMTP id z8-v6so4398259qto.9 for ; Thu, 02 Aug 2018 17:28:19 -0700 (PDT) Received: from bebop.8.8.8.8 ([2804:7f5:d180:27f9:da3e:68ff:d0f:a057]) by smtp.gmail.com with ESMTPSA id l188-v6sm1497519qke.83.2018.08.02.17.28.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Aug 2018 17:28:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hxFcl9KsRAlKevkYFzNC4nIDgGBF1L+ltsVtxRwQyb0=; b=rq2/dIU9oHA0vvNv5OVSk6OG+1P9/KMu+Nea12buKWhOG/BsGeo7EiqDLm+dZEJpCN pjX3l29zt3nV7Reg7XJOMvRZWUfwUF0ogSPWpzfEaBfeuwMkPGJQ9A87h989kp0CM/xu aQoukzP/hBq6TWfFSkI/dWpo9hxbtOByUfXC8rHllzVXr/6EQa+XCRmkwfSKMkXBvpXD MzJfoNzbf6DwGQU2Cxda+CCwCyxbMBX0HXT0c8IkdXERFLDau3al8eBvE6n4pqz6Pz86 PbCBqYsAR8Y7VsVBthskGOAPZxh+fHPTQpIttXXIiDTeXC1pUeBUdLx/vfnGvtuT7TE7 0svA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hxFcl9KsRAlKevkYFzNC4nIDgGBF1L+ltsVtxRwQyb0=; b=ZUnSn3+HIVU9oRUYcQFtVPICwGkmwcnkzyXDj5NKm1Cmz4TVQHpJ6WxQTOhmPg1v4R 3vUeb/QyYF4bJqKWawKrIrx4Mp1S7/27i4K1cCeE/UQKQ/2WMA+6KUuUSmKFRVO8fz1R J0eAqdMVkVR6vaFUugotDLlO5sLZ+sQxgy2hWVmL5i+tU6irIsWAB7LCvmtaS6LbnCU6 e6eet3arE+eAOLHRQMNMVTzF5yVe7h7I3wui/Cm39rxsNcg+hD9pTacsvOnyK0E+0hUk dtGVmG6rObBJfoeZG2BliTFEp1HPl97x31HTGt0sadrr9OyNjphtYl5b6h8B4tqdlwWr 5LHg== X-Gm-Message-State: AOUpUlGw/O73+JJfwE6nkqRYUejzXnaWLQZVGQDMnN3v5DMHAFYHZ3GT D/Och9xxHnXaur4UKbj+2lMPeMVG X-Google-Smtp-Source: AAOMgpe/yfJ0dHKeRSRowm30wHWASum+eK+n7FPhEjDnCH1Qq3mOl8QTapnAVVqZa6ZSwt26xY7ptQ== X-Received: by 2002:ac8:2fa1:: with SMTP id l30-v6mr1799754qta.150.1533256097985; Thu, 02 Aug 2018 17:28:17 -0700 (PDT) From: Marcos Paulo de Souza To: libvir-list@redhat.com Date: Thu, 2 Aug 2018 21:27:51 -0300 Message-Id: <20180803002755.7269-2-marcos.souza.org@gmail.com> In-Reply-To: <20180803002755.7269-1-marcos.souza.org@gmail.com> References: <20180803002755.7269-1-marcos.souza.org@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Fri, 03 Aug 2018 00:28:19 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Fri, 03 Aug 2018 00:28:19 +0000 (UTC) for IP:'209.85.216.176' DOMAIN:'mail-qt0-f176.google.com' HELO:'mail-qt0-f176.google.com' FROM:'marcos.souza.org@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.13 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 209.85.216.176 mail-qt0-f176.google.com 209.85.216.176 mail-qt0-f176.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.42 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.27 X-loop: libvir-list@redhat.com Cc: Marcos Paulo de Souza Subject: [libvirt] [PATCH 1/5] virauth.c: Check for valid auth callback X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 03 Aug 2018 00:28:28 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Instead of adding the same check for every drivers, execute the checks in virAuthGetUsername and virAuthGetPassword. These funtions are called when user is not set in the URI. Signed-off-by: Marcos Paulo de Souza --- src/util/virauth.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/util/virauth.c b/src/util/virauth.c index 8c450b6b31..759b8f0cd3 100644 --- a/src/util/virauth.c +++ b/src/util/virauth.c @@ -198,6 +198,12 @@ virAuthGetUsername(virConnectPtr conn, if (virAuthGetConfigFilePath(conn, &path) < 0) return NULL; =20 + if (!auth || !auth->cb) { + virReportError(VIR_ERR_INVALID_ARG, "%s", + _("Missing or invalid auth pointer")); + return NULL; + } + return virAuthGetUsernamePath(path, auth, servicename, defaultUsername, hostname); } @@ -262,5 +268,11 @@ virAuthGetPassword(virConnectPtr conn, if (virAuthGetConfigFilePath(conn, &path) < 0) return NULL; =20 + if (!auth || !auth->cb) { + virReportError(VIR_ERR_INVALID_ARG, "%s", + _("Missing or invalid auth pointer")); + return NULL; + } + return virAuthGetPasswordPath(path, auth, servicename, username, hostn= ame); } --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Wed May 8 00:42:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1533256136690206.64390476649658; Thu, 2 Aug 2018 17:28:56 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6633030832E8; Fri, 3 Aug 2018 00:28:54 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 214B77B15E; Fri, 3 Aug 2018 00:28:54 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CF76E18037F1; Fri, 3 Aug 2018 00:28:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w730SR3p008745 for ; Thu, 2 Aug 2018 20:28:27 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7CE032010CD0; Fri, 3 Aug 2018 00:28:27 +0000 (UTC) Received: from mx1.redhat.com (ext-mx01.extmail.prod.ext.phx2.redhat.com [10.5.110.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7310C2010CC6 for ; Fri, 3 Aug 2018 00:28:24 +0000 (UTC) Received: from mail-qt0-f195.google.com (mail-qt0-f195.google.com [209.85.216.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 081A281DE2 for ; Fri, 3 Aug 2018 00:28:24 +0000 (UTC) Received: by mail-qt0-f195.google.com with SMTP id n6-v6so4435653qtl.4 for ; Thu, 02 Aug 2018 17:28:23 -0700 (PDT) Received: from bebop.8.8.8.8 ([2804:7f5:d180:27f9:da3e:68ff:d0f:a057]) by smtp.gmail.com with ESMTPSA id l188-v6sm1497519qke.83.2018.08.02.17.28.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Aug 2018 17:28:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Sp8q59hufKvVteWxB90iiM6EGd376mM9sy6P81qXLrI=; b=K1ae7kd0O9m8S3ptj42yXG9RgIe8xn/CKxaOH6dlG3dDg+/bL67O4w9gua3fKiS1Qo hAXPhWgUEhqTFKh+RZI4QqcpdamG0H6388hx0sAsnOlRkL8tz30AlWqr+jnKTNZaFoY4 wbNJPTttIkjvAmAOKxoX47BQJC33BvNb9jHkw5wkEWalaTVCxEGrZRFnCbHz/3Mkbvd+ PmVFWdEfDuq5Lx9BS09U9rFwNQRzvPu9k9Aed/V6bVIYsOBzWaiNAX0mjNO5GXR4f+Q4 ej8iMI26hn79ckMCBVpT0LrJUj2oks0yFP+FbnjmImwySvJJ8yZjI9WDKTRr7j2635Qy Lfng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Sp8q59hufKvVteWxB90iiM6EGd376mM9sy6P81qXLrI=; b=UQeisMssc+EHJsmVX8KWsHeGgLIzk2yKzgIVyXoRvKq0u+BuRVgrsaSzPbedtvRdmA wj4XEJIEYh2mvGK9tiIMomsOmOHbQm4Zs77HMAfc8tWxBdckbyyMWZNFmZJuMqx61uDg Mo8dldrnKLDitjypnC2JM9Khfm/SOq0+vV2eDSP5kyOGKsvI4cAzRd7XAYHCaac/iVPR 0f8qLAbXo/8/JqalrG4p7v7lR82yXbOMH/WN/V4zN7XYZT3vmbc/awU3Y6Qya+prAA2M n+NWaFYMWf2vY41aXBynDBucjlnKbv60LUpGtsYsmoYR1vm5nx6A3Zcjl/FA9xaHQ9bB D0+Q== X-Gm-Message-State: AOUpUlE+MrhYTTSJm+mM6tKhCtYcR1BQ0vJYrW1aclIWOUU2WnvJqOXP YDLDHi2+ysJxFZgTx0L6LG3gYmlj X-Google-Smtp-Source: AAOMgpeGQEipmQwQjFB0sPhUnMNiWevDAiGK8Jfm4Orj6EL8zDRic1rousFM/+cf1q1roc4XlnTt1g== X-Received: by 2002:a0c:95ad:: with SMTP id s42-v6mr1659244qvs.18.1533256102843; Thu, 02 Aug 2018 17:28:22 -0700 (PDT) From: Marcos Paulo de Souza To: libvir-list@redhat.com Date: Thu, 2 Aug 2018 21:27:52 -0300 Message-Id: <20180803002755.7269-3-marcos.souza.org@gmail.com> In-Reply-To: <20180803002755.7269-1-marcos.souza.org@gmail.com> References: <20180803002755.7269-1-marcos.souza.org@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 03 Aug 2018 00:28:24 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 03 Aug 2018 00:28:24 +0000 (UTC) for IP:'209.85.216.195' DOMAIN:'mail-qt0-f195.google.com' HELO:'mail-qt0-f195.google.com' FROM:'marcos.souza.org@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.13 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 209.85.216.195 mail-qt0-f195.google.com 209.85.216.195 mail-qt0-f195.google.com X-Scanned-By: MIMEDefang 2.83 on 10.5.110.25 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-loop: libvir-list@redhat.com Cc: Marcos Paulo de Souza Subject: [libvirt] [PATCH 2/5] esx: Drop check for auth and auth->cb X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Fri, 03 Aug 2018 00:28:55 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Since they are done inside virAuthGetPassword and virAuthGetUsername when needed. Signed-off-by: Marcos Paulo de Souza --- src/esx/esx_driver.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index c2154799fa..15785858c6 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -854,13 +854,6 @@ esxConnectOpen(virConnectPtr conn, virConnectAuthPtr a= uth, conn->uri->path, conn->uri->scheme); } =20 - /* Require auth */ - if (!auth || !auth->cb) { - virReportError(VIR_ERR_INVALID_ARG, "%s", - _("Missing or invalid auth pointer")); - return VIR_DRV_OPEN_ERROR; - } - /* Allocate per-connection private data */ if (VIR_ALLOC(priv) < 0) goto cleanup; --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Wed May 8 00:42:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1533459135447960.411955792576; Sun, 5 Aug 2018 01:52:15 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C64903082152; Sun, 5 Aug 2018 08:52:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 841FB6092E; Sun, 5 Aug 2018 08:52:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2FD251800B6A; Sun, 5 Aug 2018 08:52:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w730SYIp008758 for ; Thu, 2 Aug 2018 20:28:34 -0400 Received: by smtp.corp.redhat.com (Postfix) id 12E02308BDB4; Fri, 3 Aug 2018 00:28:34 +0000 (UTC) Received: from mx1.redhat.com (ext-mx12.extmail.prod.ext.phx2.redhat.com [10.5.110.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 05656308BDA6 for ; Fri, 3 Aug 2018 00:28:30 +0000 (UTC) Received: from mail-qt0-f194.google.com (mail-qt0-f194.google.com [209.85.216.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 517F931500A0 for ; Fri, 3 Aug 2018 00:28:29 +0000 (UTC) Received: by mail-qt0-f194.google.com with SMTP id c15-v6so4471572qtp.0 for ; Thu, 02 Aug 2018 17:28:29 -0700 (PDT) Received: from bebop.8.8.8.8 ([2804:7f5:d180:27f9:da3e:68ff:d0f:a057]) by smtp.gmail.com with ESMTPSA id l188-v6sm1497519qke.83.2018.08.02.17.28.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Aug 2018 17:28:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GkY3wlnocSToxOpTsxrnvqY+Iw3hfS/Y1OgdL5Tmfd8=; b=Yor6FwSef9xS34DI09Yg4YI+vLkdx8sRaRPcQBwZb+YnbsmfczNo6vHGloYW+L7YOh qYggHU7SozdECeeG1x1DpCd6iY4VpMjt93IY4votS8i/iMNrqYPISkDjPKleDYe083ou 2VeVYFS5yZnWixF3nXa1VdVGpnM2A0WuekffV+4whv1UOVCvqtCArLl+rYSRdmgj7O1G FLoejez5Akar0lpGbCHeKqDOn8F1bbbTwxDfGxJ2u2OLF2vofi9geAhG9TZMCogBEiSv mxTOs2F5Q0hBTTvp6j139ELbDy21q2M0dqDaKXzWFpMb+fahqGjofsNGxmxulNhr6IEq Ri3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GkY3wlnocSToxOpTsxrnvqY+Iw3hfS/Y1OgdL5Tmfd8=; b=Kx25AMaztDaKJhjcaOQtJ08LYO1Wfp7b39FjePQLCdHrpLPyA9Fm5pY+18TwH6xIkS xaqaM+RnxJuyjTcr3bAAH/z2URmnfC/spgJYVhlOkYiCigjg5IGLxsnANmQtYt4wJ2p9 2dz5NEZGqB3dSKWxANpvTWkv/MjzHucAdvbt584DAOII6ES0MFDChOcrrKxbCKsbNIMM hNP8S0XWn8ORTf7kA2O2Oqu8V6oitrjujk1IOsEtWWZszJGKRU0X/aM0W2xnA8vv9uQf Qmwecv9HBkeV1/QURtjnGOZzvMSf5PG2wo2+AlySuCxKQ/hh5vlPjDEYMLHU3aHko0dS L71w== X-Gm-Message-State: AOUpUlEVtG2FRmgU6JcrCjOkQfnk3bMgJkgLE7uqu826koXoNg+jPFl+ iSVx8YQLkQseuWtjxFsEB5j7tFfU X-Google-Smtp-Source: AAOMgpd08UQK5ihmDpTXv6SerIeOovThZQQmX3gXQWIUIB06eq6Z18wSg7lFUrxZ2vW5kB5OadNS0g== X-Received: by 2002:a0c:81ae:: with SMTP id 43-v6mr1634573qvd.129.1533256108110; Thu, 02 Aug 2018 17:28:28 -0700 (PDT) From: Marcos Paulo de Souza To: libvir-list@redhat.com Date: Thu, 2 Aug 2018 21:27:53 -0300 Message-Id: <20180803002755.7269-4-marcos.souza.org@gmail.com> In-Reply-To: <20180803002755.7269-1-marcos.souza.org@gmail.com> References: <20180803002755.7269-1-marcos.souza.org@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Fri, 03 Aug 2018 00:28:29 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Fri, 03 Aug 2018 00:28:29 +0000 (UTC) for IP:'209.85.216.194' DOMAIN:'mail-qt0-f194.google.com' HELO:'mail-qt0-f194.google.com' FROM:'marcos.souza.org@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.13 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 209.85.216.194 mail-qt0-f194.google.com 209.85.216.194 mail-qt0-f194.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.41 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.24 X-loop: libvir-list@redhat.com Cc: Marcos Paulo de Souza Subject: [libvirt] [PATCH 3/5] hyperv: Drop check for auth and auth->cb X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Sun, 05 Aug 2018 08:52:13 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Since they are done inside virAuthGetPassword and virAuthGetUsername when needed. Signed-off-by: Marcos Paulo de Souza --- src/hyperv/hyperv_driver.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 6bc4c099e2..7ca145aef5 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@ -128,13 +128,6 @@ hypervConnectOpen(virConnectPtr conn, virConnectAuthPt= r auth, =20 virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR); =20 - /* Require auth */ - if (auth =3D=3D NULL || auth->cb =3D=3D NULL) { - virReportError(VIR_ERR_INVALID_ARG, "%s", - _("Missing or invalid auth pointer")); - return VIR_DRV_OPEN_ERROR; - } - /* Allocate per-connection private data */ if (VIR_ALLOC(priv) < 0) goto cleanup; --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Wed May 8 00:42:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1533459138880606.7605168324963; Sun, 5 Aug 2018 01:52:18 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2AA6030E6853; Sun, 5 Aug 2018 08:52:17 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CF6615E7AA; Sun, 5 Aug 2018 08:52:16 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7E5B91800B6D; Sun, 5 Aug 2018 08:52:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w730Sciq008768 for ; Thu, 2 Aug 2018 20:28:38 -0400 Received: by smtp.corp.redhat.com (Postfix) id 405B474E92; Fri, 3 Aug 2018 00:28:38 +0000 (UTC) Received: from mx1.redhat.com (ext-mx17.extmail.prod.ext.phx2.redhat.com [10.5.110.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 37A0774EA8 for ; Fri, 3 Aug 2018 00:28:35 +0000 (UTC) Received: from mail-qt0-f178.google.com (mail-qt0-f178.google.com [209.85.216.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E28DB30E6877 for ; Fri, 3 Aug 2018 00:28:34 +0000 (UTC) Received: by mail-qt0-f178.google.com with SMTP id t5-v6so4449178qtn.3 for ; Thu, 02 Aug 2018 17:28:34 -0700 (PDT) Received: from bebop.8.8.8.8 ([2804:7f5:d180:27f9:da3e:68ff:d0f:a057]) by smtp.gmail.com with ESMTPSA id l188-v6sm1497519qke.83.2018.08.02.17.28.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Aug 2018 17:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=uBiA/G+WZeUpsJvRuB0q3pMMVI9LklIbRaQeibXH32M=; b=Xt1wawDNEZes0GWkD1N115NQ8mqf9seL/Nm7RwpQAkbSSk62jjc6Jbf79lXnsHKV0n zGa24E8ny1kvSF+FkhVAvGQTTB1Fl1xxfftIRE4Mwrxf6Y2xjwxklq/4K5T05QVuclL0 VfSDBafg7Ku+X3KoRmQe7xkJgTo0ug8lAomBVNZMq27oFiKq+RX4KlcTUkipYdYFBi1N H1XBSIEjibhYi2XHCfqH2LZmflxcTwjps3sNb24G7tpve5XFWRrSTA7FFe1BWQKRlti/ HBS0SA8pwNATBFUbRSOpnleo2hqLT2WSGlyBuCSiZH9yjMLE70yXPkmx02k/4w41Jh1G p7Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=uBiA/G+WZeUpsJvRuB0q3pMMVI9LklIbRaQeibXH32M=; b=X6rjM5eMNy4rBF8cmXjnAYvb2g7WKeAiUhFm6bKXZqoCojhse9lR/Tp1VsNahfMtMv 2I0KqXfWd8em2CVknLH1THxqrMH4Au3VzhbfIfxz/SqyjoIkNeLwSzs4m+qI0LTbPXFJ SyB4cYzwMxcm6qhShq6AHuc/9mYoLUqDa35dSwp2EmYVB9Ke4iRlLSnpvN2VBV5tZYSg CP8EJkkZOOSL1wsmpPZfb2OPslIBafsS0k3xTKD4KZmaMBGcklf010wbErsmx0uVZ9CJ PVZ7II9hG84ju7QIGp11ytW4/T00/LWizJlil6uyOwUxnBViCGDiEBOZoYhQgx0THdcT I3rQ== X-Gm-Message-State: AOUpUlHg1d6X/JDLXATURt9V+QVz/etwOPAyvi05qYSFsyVyEdUrb/+V xto5WIVV15Bh4ckNE0A0Rgs3X2Io X-Google-Smtp-Source: AAOMgpewDEoSgWAN6Sd4T9mRsvD12PiW+xFqqmvonotiRy1Utuf3hdJZtSvP0FgCtzsyCIUQ+RUPWw== X-Received: by 2002:ac8:2bb3:: with SMTP id m48-v6mr1704713qtm.207.1533256113728; Thu, 02 Aug 2018 17:28:33 -0700 (PDT) From: Marcos Paulo de Souza To: libvir-list@redhat.com Date: Thu, 2 Aug 2018 21:27:54 -0300 Message-Id: <20180803002755.7269-5-marcos.souza.org@gmail.com> In-Reply-To: <20180803002755.7269-1-marcos.souza.org@gmail.com> References: <20180803002755.7269-1-marcos.souza.org@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Fri, 03 Aug 2018 00:28:35 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Fri, 03 Aug 2018 00:28:35 +0000 (UTC) for IP:'209.85.216.178' DOMAIN:'mail-qt0-f178.google.com' HELO:'mail-qt0-f178.google.com' FROM:'marcos.souza.org@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.13 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 209.85.216.178 mail-qt0-f178.google.com 209.85.216.178 mail-qt0-f178.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.46 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Marcos Paulo de Souza Subject: [libvirt] [PATCH 4/5] phyp: Drop check for auth and auth->cb X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Sun, 05 Aug 2018 08:52:17 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Since they are done inside virAuthGetPassword and virAuthGetUsername when needed. Signed-off-by: Marcos Paulo de Souza --- src/phyp/phyp_driver.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index d78de83231..5b17508dae 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@ -957,12 +957,6 @@ openSSHSession(virConnectPtr conn, virConnectAuthPtr a= uth, if (VIR_STRDUP(username, conn->uri->user) < 0) goto err; } else { - if (auth =3D=3D NULL || auth->cb =3D=3D NULL) { - virReportError(VIR_ERR_AUTH_FAILED, - "%s", _("No authentication callback provided.")= ); - goto err; - } - username =3D virAuthGetUsername(conn, auth, "ssh", NULL, conn->uri= ->server); =20 if (username =3D=3D NULL) { @@ -1039,11 +1033,6 @@ openSSHSession(virConnectPtr conn, virConnectAuthPtr= auth, if (rc =3D=3D LIBSSH2_ERROR_SOCKET_NONE || rc =3D=3D LIBSSH2_ERROR_PUBLICKEY_UNRECOGNIZED || rc =3D=3D LIBSSH2_ERROR_PUBLICKEY_UNVERIFIED) { - if (auth =3D=3D NULL || auth->cb =3D=3D NULL) { - virReportError(VIR_ERR_AUTH_FAILED, - "%s", _("No authentication callback provided.")= ); - goto disconnect; - } =20 password =3D virAuthGetPassword(conn, auth, "ssh", username, conn-= >uri->server); =20 --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Wed May 8 00:42:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1533256125597273.9831160338574; Thu, 2 Aug 2018 17:28:45 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 65F663086248; Fri, 3 Aug 2018 00:28:43 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2A05C18513; Fri, 3 Aug 2018 00:28:43 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7DDA218037ED; Fri, 3 Aug 2018 00:28:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w730SeMi008778 for ; Thu, 2 Aug 2018 20:28:40 -0400 Received: by smtp.corp.redhat.com (Postfix) id 84C882010CFA; Fri, 3 Aug 2018 00:28:40 +0000 (UTC) Received: from mx1.redhat.com (ext-mx02.extmail.prod.ext.phx2.redhat.com [10.5.110.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7A37E2010CF9 for ; Fri, 3 Aug 2018 00:28:40 +0000 (UTC) Received: from mail-qt0-f195.google.com (mail-qt0-f195.google.com [209.85.216.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A98A191D19 for ; Fri, 3 Aug 2018 00:28:39 +0000 (UTC) Received: by mail-qt0-f195.google.com with SMTP id n6-v6so4436127qtl.4 for ; Thu, 02 Aug 2018 17:28:39 -0700 (PDT) Received: from bebop.8.8.8.8 ([2804:7f5:d180:27f9:da3e:68ff:d0f:a057]) by smtp.gmail.com with ESMTPSA id l188-v6sm1497519qke.83.2018.08.02.17.28.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Aug 2018 17:28:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NtxKmL9IjOMzQT1Mz4sepMhaH8VYNP3lCDvfRqGFP8Y=; b=sGlfLvf7xvRqplqoH6lK2oyr4QD50UZB5XaPbIy1SNxF/mKbo8BOCXKvgJm7xkjtJD I7QGF2p5BZQqDMPBqUzR2GqkQHBsMnIU1H2JJBfH6qb0kBBC9IQ9gkVg85smQU5X1Dbk R6zcdzny+YTXPiJavT14QWvnwzXYPZ8iGroljy64Ri2MDjXGswvXm2sVodD8jMVgN+MU paIYIXOIVYixMGZM4//5f51oIoC3ksPVZ0SXBa+Ou1XsCGqgY0s712DvlYY411JXrIys Cb8yCwCuLgp285kL+3or4uB+/6t14+GdO/5qnBFe5RBZYbFpfaG7bpKm5hwiW2vW9YYf XENA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NtxKmL9IjOMzQT1Mz4sepMhaH8VYNP3lCDvfRqGFP8Y=; b=OABdd20tm2A+cUIizCJTWNJFRmXmcDr5/m2mdyBk1XhX0ow7o6vQI3yQDNbMQuKk7T zxBvBjx26WTywpUMBp5JZE7CQNrisXCH3Is1X8NayRdKNUpU81ItseuUbbeGv57JUK/o F161wOlknqY17M440KZYjckZIrF8yrx+bPlv1y0inLWJQ0xx7cW8lKQKdU/Bqe5xyPUh Hl4N+1250Du5zZXg8wI4dJi1KFPWTT0QVYM93408xnQle4haXq8MgYKs1h0CJMUy/bSp 4QkHHA5qPaBQ2o8XOridpiKhx1jsXoENYYOvh8ofmPT6ihc60bo+oQCGfJ2R3jdu2v44 fw1Q== X-Gm-Message-State: AOUpUlFtm2gMt39Xmkwi4KaLh7JEwVCBz+Fk1CKbxkU+xv2GrJV8VXRr gAAwvArUXSoj8IBEjCw/JGsrQlff X-Google-Smtp-Source: AAOMgpfiTVTTHFhJnB4eNItRe8QwEA7P47DSKWC7Fflz9df6805hdN5GUHXA7uzvHRo1FZbNr/2aGg== X-Received: by 2002:ac8:2ae:: with SMTP id p46-v6mr1695516qtg.306.1533256118513; Thu, 02 Aug 2018 17:28:38 -0700 (PDT) From: Marcos Paulo de Souza To: libvir-list@redhat.com Date: Thu, 2 Aug 2018 21:27:55 -0300 Message-Id: <20180803002755.7269-6-marcos.souza.org@gmail.com> In-Reply-To: <20180803002755.7269-1-marcos.souza.org@gmail.com> References: <20180803002755.7269-1-marcos.souza.org@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 03 Aug 2018 00:28:39 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 03 Aug 2018 00:28:39 +0000 (UTC) for IP:'209.85.216.195' DOMAIN:'mail-qt0-f195.google.com' HELO:'mail-qt0-f195.google.com' FROM:'marcos.souza.org@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.13 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 209.85.216.195 mail-qt0-f195.google.com 209.85.216.195 mail-qt0-f195.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.26 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-loop: libvir-list@redhat.com Cc: Marcos Paulo de Souza Subject: [libvirt] [PATCH 5/5] xenapi: Drop check for auth X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Fri, 03 Aug 2018 00:28:44 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Since they are done inside virAuthGetPassword and virAuthGetUsername when needed. Also, only auth is checked, but auth->cb, which that could lead to a crash if the callback is NULL. Signed-off-by: Marcos Paulo de Souza --- src/xenapi/xenapi_driver.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c index 34f9e2c717..3af5eeafcf 100644 --- a/src/xenapi/xenapi_driver.c +++ b/src/xenapi/xenapi_driver.c @@ -152,12 +152,6 @@ xenapiConnectOpen(virConnectPtr conn, virConnectAuthPt= r auth, goto error; } =20 - if (auth =3D=3D NULL) { - xenapiSessionErrorHandler(conn, VIR_ERR_AUTH_FAILED, - _("Authentication Credentials not found"= )); - goto error; - } - if (conn->uri->user !=3D NULL) { if (VIR_STRDUP(username, conn->uri->user) < 0) goto error; --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list