storage: tweak error message when skipping file

[libvirt] [PATCH] storage: tweak error message when skipping file

Daniel P. Berrangé posted 1 patch 5 years, 8 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180808154543.23976-1-berrange@redhat.com

Test syntax-check passed

src/storage/storage_util.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[libvirt] [PATCH] storage: tweak error message when skipping file

Posted by Daniel P. Berrangé 5 years, 8 months ago

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/storage/storage_util.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c
index 715d5c2f88..42a9b6abf0 100644
--- a/src/storage/storage_util.c
+++ b/src/storage/storage_util.c
@@ -3609,8 +3609,8 @@ virStorageBackendRefreshLocal(virStoragePoolObjPtr pool)
         int err;
 
         if (virStringHasControlChars(ent->d_name)) {
-            VIR_WARN("Ignoring file with control characters under '%s'",
-                     def->target.path);
+            VIR_WARN("Ignoring file '%s' with control characters under '%s'",
+                     ent->d_name, def->target.path);
             continue;
         }
 
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] storage: tweak error message when skipping file

Posted by Martin Kletzander 5 years, 8 months ago

On Wed, Aug 08, 2018 at 04:45:43PM +0100, Daniel P. Berrangé wrote:
>Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>---
> src/storage/storage_util.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

>diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c
>index 715d5c2f88..42a9b6abf0 100644
>--- a/src/storage/storage_util.c
>+++ b/src/storage/storage_util.c
>@@ -3609,8 +3609,8 @@ virStorageBackendRefreshLocal(virStoragePoolObjPtr pool)
>         int err;
>
>         if (virStringHasControlChars(ent->d_name)) {
>-            VIR_WARN("Ignoring file with control characters under '%s'",
>-                     def->target.path);
>+            VIR_WARN("Ignoring file '%s' with control characters under '%s'",
>+                     ent->d_name, def->target.path);
>             continue;
>         }
>
>-- 
>2.17.1
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list