We can drop some entries and tweak some others to be
less verbose without losing in functionality.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 jobs/defaults.yaml | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/jobs/defaults.yaml b/jobs/defaults.yaml
index e4d1f2c..bab5bc4 100644
--- a/jobs/defaults.yaml
+++ b/jobs/defaults.yaml
@@ -24,11 +24,9 @@
     global_env: |
     local_env: |
     strip_buildrequires: |
-      sed -i -e 's/BuildRequires: *libvirt.*devel.*//' *.spec*
-      sed -i -e 's/BuildRequires: *osinfo-db-tools.*//' *.spec*
+      sed -i -e 's/BuildRequires: *libvirt.*//' *.spec*
       sed -i -e 's/BuildRequires: *osinfo-db.*//' *.spec*
       sed -i -e 's/BuildRequires: *perl(Sys::Virt).*//' *.spec*
-      sed -i -e 's/BuildRequires: *perl-Sys-Virt.*//' *.spec*
       sed -i -e 's/BuildRequires: *pkgconfig(libvirt.*).*//' *.spec*
     mingw32_local_env: |
       export VIRT_PREFIX="$VIRT_PREFIX/i686-w64-mingw32/sys-root/mingw"
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Fri, Aug 10, 2018 at 03:37:44PM +0200, Andrea Bolognani wrote:
> We can drop some entries and tweak some others to be
> less verbose without losing in functionality.
>
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  jobs/defaults.yaml | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/jobs/defaults.yaml b/jobs/defaults.yaml
> index e4d1f2c..bab5bc4 100644
> --- a/jobs/defaults.yaml
> +++ b/jobs/defaults.yaml
> @@ -24,11 +24,9 @@
>      global_env: |
>      local_env: |
>      strip_buildrequires: |
> -      sed -i -e 's/BuildRequires: *libvirt.*devel.*//' *.spec*
> -      sed -i -e 's/BuildRequires: *osinfo-db-tools.*//' *.spec*
> +      sed -i -e 's/BuildRequires: *libvirt.*//' *.spec*
>        sed -i -e 's/BuildRequires: *osinfo-db.*//' *.spec*


>        sed -i -e 's/BuildRequires: *perl(Sys::Virt).*//' *.spec*
> -      sed -i -e 's/BuildRequires: *perl-Sys-Virt.*//' *.spec*

I assume because ^these 2 are somehow identical?

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Mon, 2018-08-20 at 16:11 +0200, Erik Skultety wrote:
> On Fri, Aug 10, 2018 at 03:37:44PM +0200, Andrea Bolognani wrote:
> >        sed -i -e 's/BuildRequires: *perl(Sys::Virt).*//' *.spec*
> > -      sed -i -e 's/BuildRequires: *perl-Sys-Virt.*//' *.spec*
> 
> I assume because ^these 2 are somehow identical?

Well, either one can be used to express the same dependency but
strictly speaking they're not identical... However, we only use
the first one in practice so the second one is unnecessary at the
moment - we can add it back the first time we get actual users.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list