From nobody Sat Apr 27 13:56:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1533998542424869.3652315406202; Sat, 11 Aug 2018 07:42:22 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F41378553D; Sat, 11 Aug 2018 14:42:18 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DECF018791; Sat, 11 Aug 2018 14:42:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DD0684A460; Sat, 11 Aug 2018 14:42:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w7BEefRY031198 for ; Sat, 11 Aug 2018 10:40:41 -0400 Received: by smtp.corp.redhat.com (Postfix) id 02C8C26DC9; Sat, 11 Aug 2018 14:40:41 +0000 (UTC) Received: from mx1.redhat.com (ext-mx12.extmail.prod.ext.phx2.redhat.com [10.5.110.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC6D126E71 for ; Sat, 11 Aug 2018 14:40:39 +0000 (UTC) Received: from mail-qk0-f181.google.com (mail-qk0-f181.google.com [209.85.220.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 00CCA31524EE for ; Sat, 11 Aug 2018 14:40:38 +0000 (UTC) Received: by mail-qk0-f181.google.com with SMTP id 27-v6so8333773qkv.0 for ; Sat, 11 Aug 2018 07:40:37 -0700 (PDT) Received: from localhost.localdomain ([2804:7f5:d180:ef89:63fc:5138:9bc2:9c64]) by smtp.gmail.com with ESMTPSA id 127-v6sm7611665qkn.78.2018.08.11.07.40.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 11 Aug 2018 07:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Jghpd79nBHsI1L7Nj+by3zFSRB1OgReazjSsmRfkiu8=; b=dYOBvLq9o0SHYtauAgR0ISLY9mLWrE3/NGixxDRKpY2bI0tGV1YFVjVxSIrrWj6yOY K+7eGcBssn5s3s4O/Glk5Xwb95D22Ub4NQo+1i1dZoMw23tqWAjNH91PRWwL6NNh9mUU UD/tjx9YIXs0bNEm3UKRallCZ+Oy3xbPqdd9bd/HRovKTz/MnnQFaxkxazNiAIOxLK9T DBEjxcNGZEn4ZsYJS3nvfK/397Z/eIFZdRR5Fx0FGLEebZeZLBEtzx3RVJXUpNXmpc2M 0DZ3MihlUrcx7kG58MGL+qNda0ZU9OGwE2YfV1owYO7wWbZqxY+heJR6vH6MADHCsRgm Ef2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Jghpd79nBHsI1L7Nj+by3zFSRB1OgReazjSsmRfkiu8=; b=JhZomHDJ6yPPsmTLA8Z4J7TK8j3lm+RC4WQbcmlN/wJfA/Nu7nvQ3O19N/JdYQ94Lz lbAeESYKgksdk9+0ygryiMDwlbFBnsBtIOqAQ0qn53QEsehgW5KJaj4/WPL2NUksYR03 8TgaRA53arJAHDRNgqH0JnS5wf7xvDJsntC/DeTXlUVA/rKuaUWm+LEAaEOfmim1lyXc 94tzJYTX7YOcN1Io9AhnKdvLAvBJt7SHe8A+VhPjv8PC+x4Li3joN2ZSV35jN5zCxGk8 2h7IeoQZX3WcDkCAta5e8cO/9wHvCvOyxgIxrrVVW7K8quKCt/Bpqwf9SuH0Lwsd4ujy oWuw== X-Gm-Message-State: AOUpUlGWdr4vsUV3sfnxlePsWwNFibaXb+wmAQZOG0AcsxL9hhA3GbBt oxo1fCtQK8zRGkLnSnik/EpxAH1C X-Google-Smtp-Source: AA+uWPzTEoGz1yHzmQrlEdVfntepq5v3OUVqVX7yyTKFu8hrYCugiWkPB7X+qCH8ck/mNWae73XCsg== X-Received: by 2002:a37:de1a:: with SMTP id h26-v6mr10020085qkj.442.1533998436683; Sat, 11 Aug 2018 07:40:36 -0700 (PDT) From: Marcos Paulo de Souza To: libvir-list@redhat.com Date: Sat, 11 Aug 2018 11:39:29 -0300 Message-Id: <20180811143929.20937-1-marcos.souza.org@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Sat, 11 Aug 2018 14:40:38 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Sat, 11 Aug 2018 14:40:38 +0000 (UTC) for IP:'209.85.220.181' DOMAIN:'mail-qk0-f181.google.com' HELO:'mail-qk0-f181.google.com' FROM:'marcos.souza.org@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.13 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 209.85.220.181 mail-qk0-f181.google.com 209.85.220.181 mail-qk0-f181.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.41 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: Marcos Paulo de Souza Subject: [libvirt] [PATCH] esx: Fix build when libcurl debug is enabled X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Sat, 11 Aug 2018 14:42:20 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" When building libvirt with libcurl debug enabled (with ESX_VI__CURL__ENABLE_DEBUG_OUTPUT set), the message bellow pops up: make[3]: Entering directory '/mnt/data/gitroot/libvirt/src' CC esx/libvirt_driver_esx_la-esx_vi.lo esx/esx_vi.c: In function 'esxVI_CURL_Debug': esx/esx_vi.c:191:5: error: enumeration value 'CURLINFO_SSL_DATA_IN' not han= dled in switch [-Werror=3Dswitch-enum] switch (type) { ^~~~~~ esx/esx_vi.c:191:5: error: enumeration value 'CURLINFO_SSL_DATA_OUT' not ha= ndled in switch [-Werror=3Dswitch-enum] esx/esx_vi.c:191:5: error: enumeration value 'CURLINFO_END' not handled in = switch [-Werror=3Dswitch-enum] Our build requires at least libcurl 7.18.0, which is pretty stable since it was release in 2008. Fix this problem by handling the mentioned enums in the code. Signed-off-by: Marcos Paulo de Souza --- src/esx/esx_vi.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c index a816c3a4f9..588670e137 100644 --- a/src/esx/esx_vi.c +++ b/src/esx/esx_vi.c @@ -163,7 +163,7 @@ esxVI_CURL_WriteBuffer(char *data, size_t size, size_t = nmemb, void *userdata) return 0; } =20 -#define ESX_VI__CURL__ENABLE_DEBUG_OUTPUT 0 +#define ESX_VI__CURL__ENABLE_DEBUG_OUTPUT 1 =20 #if ESX_VI__CURL__ENABLE_DEBUG_OUTPUT static int @@ -205,13 +205,19 @@ esxVI_CURL_Debug(CURL *curl ATTRIBUTE_UNUSED, curl_in= fotype type, break; =20 case CURLINFO_DATA_IN: + case CURLINFO_SSL_DATA_IN: VIR_DEBUG("CURLINFO_DATA_IN [[[[%s]]]]", buffer); break; =20 case CURLINFO_DATA_OUT: + case CURLINFO_SSL_DATA_OUT: VIR_DEBUG("CURLINFO_DATA_OUT [[[[%s]]]]", buffer); break; =20 + case CURLINFO_END: + VIR_DEBUG("CURLINFO_END [[[[%s]]]]", buffer); + break; + default: VIR_DEBUG("unknown"); break; --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list