From nobody Sat Apr 20 10:39:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1534161360431794.9567247075017; Mon, 13 Aug 2018 04:56:00 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8521D914EC; Mon, 13 Aug 2018 11:55:58 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 368D910694E0; Mon, 13 Aug 2018 11:55:58 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D5F9A3FCC1; Mon, 13 Aug 2018 11:55:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w7DBtXWi026154 for ; Mon, 13 Aug 2018 07:55:33 -0400 Received: by smtp.corp.redhat.com (Postfix) id A3988112D169; Mon, 13 Aug 2018 11:55:33 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 41472112D167 for ; Mon, 13 Aug 2018 11:55:33 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Mon, 13 Aug 2018 13:55:26 +0200 Message-Id: <20180813115527.16043-2-abologna@redhat.com> In-Reply-To: <20180813115527.16043-1-abologna@redhat.com> References: <20180813115527.16043-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 1/2] configure: Fix quoting X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 13 Aug 2018 11:55:59 +0000 (UTC) X-ZohoMail: RDMRC_0 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Macro arguments are supposed to be quoted. Signed-off-by: Andrea Bolognani Reviewed-by: J=EF=BF=BDn Tomko --- configure.ac | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/configure.ac b/configure.ac index 8917b37..22d80dd 100644 --- a/configure.ac +++ b/configure.ac @@ -1,6 +1,6 @@ AC_INIT([libvirt-dbus], [1.3.0], [libvir-list@redhat.com], [], [https://li= bvirt.org]) =20 -AC_CONFIG_SRCDIR(src/main.c) +AC_CONFIG_SRCDIR([src/main.c]) AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_HEADERS([config.h]) AC_CONFIG_MACRO_DIR([m4]) @@ -37,10 +37,10 @@ AM_PROG_CC_C_O AC_PROG_CC_STDC AC_PROG_LIBTOOL =20 -PKG_CHECK_MODULES(GIO2, gio-unix-2.0 >=3D GLIB2_REQUIRED) -PKG_CHECK_MODULES(GLIB2, glib-2.0 >=3D GLIB2_REQUIRED) -PKG_CHECK_MODULES(LIBVIRT, libvirt >=3D $LIBVIRT_REQUIRED) -PKG_CHECK_MODULES(LIBVIRT_GLIB, libvirt-glib-1.0 >=3D LIBVIRT_GLIB_REQUIRE= D) +PKG_CHECK_MODULES([GIO2], [gio-unix-2.0 >=3D GLIB2_REQUIRED]) +PKG_CHECK_MODULES([GLIB2], [glib-2.0 >=3D GLIB2_REQUIRED]) +PKG_CHECK_MODULES([LIBVIRT], [libvirt >=3D $LIBVIRT_REQUIRED]) +PKG_CHECK_MODULES([LIBVIRT_GLIB], [libvirt-glib-1.0 >=3D LIBVIRT_GLIB_REQU= IRED]) =20 LIBVIRT_COMPILE_WARNINGS LIBVIRT_LINKER_RELRO @@ -49,17 +49,17 @@ LIBVIRT_COMPILE_PIE LIBVIRT_ARG_WITH([DBUS_SERVICES], [where D-Bus session services direcotry = is], ['$(datadir)/dbus-1/services']) DBUS_SERVICES_DIR=3D"$with_dbus_services" -AC_SUBST(DBUS_SERVICES_DIR) +AC_SUBST([DBUS_SERVICES_DIR]) =20 LIBVIRT_ARG_WITH([DBUS_SYSTEM_SERVICES], [where D-Bus system services dire= ctory is], ['$(datadir)/dbus-1/system-services']) DBUS_SYSTEM_SERVICES_DIR=3D"$with_dbus_system_services" -AC_SUBST(DBUS_SYSTEM_SERVICES_DIR) +AC_SUBST([DBUS_SYSTEM_SERVICES_DIR]) =20 LIBVIRT_ARG_WITH([DBUS_SYSTEM_POLICIES], [where D-Bus system policies dire= ctory is], ['$(datadir)/dbus-1/system.d']) DBUS_SYSTEM_POLICIES_DIR=3D"$with_dbus_system_policies" -AC_SUBST(DBUS_SYSTEM_POLICIES_DIR) +AC_SUBST([DBUS_SYSTEM_POLICIES_DIR]) =20 LIBVIRT_ARG_WITH([DBUS_INTERFACES], [where D-Bus interfaces directory is], ['$(datadir)/dbus-1/interfaces']) @@ -69,7 +69,7 @@ AC_SUBST([DBUS_INTERFACES_DIR]) LIBVIRT_ARG_WITH([POLKIT_RULES], [directory for polkit rules], ['$(datadir)/polkit-1/rules.d']) POLKIT_RULES_DIR=3D"$with_polkit_rules" -AC_SUBST(POLKIT_RULES_DIR) +AC_SUBST([POLKIT_RULES_DIR]) =20 LIBVIRT_ARG_WITH([SYSTEM_USER], [username to run system instance as], ['libvirtdbus']) @@ -78,9 +78,9 @@ AC_SUBST([SYSTEM_USER]) =20 AC_CONFIG_FILES([run], [chmod +x,-w run]) -AC_OUTPUT(Makefile - data/Makefile - docs/Makefile - src/Makefile - tests/Makefile - libvirt-dbus.spec) +AC_OUTPUT([Makefile + data/Makefile + docs/Makefile + src/Makefile + tests/Makefile + libvirt-dbus.spec]) --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat Apr 20 10:39:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1534161365934757.8291477926446; Mon, 13 Aug 2018 04:56:05 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CE9D3914F6; Mon, 13 Aug 2018 11:56:03 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8D5EC2010D14; Mon, 13 Aug 2018 11:56:03 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 18AE03F7CB; Mon, 13 Aug 2018 11:56:03 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w7DBtYnd026167 for ; Mon, 13 Aug 2018 07:55:34 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4F505112D169; Mon, 13 Aug 2018 11:55:34 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E1EE3112D167 for ; Mon, 13 Aug 2018 11:55:33 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Mon, 13 Aug 2018 13:55:27 +0200 Message-Id: <20180813115527.16043-3-abologna@redhat.com> In-Reply-To: <20180813115527.16043-1-abologna@redhat.com> References: <20180813115527.16043-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 2/2] configure: Call PKG_CHECK_MODULES() correctly X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 13 Aug 2018 11:56:04 +0000 (UTC) X-ZohoMail: RDMRC_0 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Most of the calls where missing the dollar sign when referencing variables, which caused the corresponding version checks to be skipped. Signed-off-by: Andrea Bolognani Reviewed-by: J=EF=BF=BDn Tomko --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 22d80dd..1c0e246 100644 --- a/configure.ac +++ b/configure.ac @@ -37,10 +37,10 @@ AM_PROG_CC_C_O AC_PROG_CC_STDC AC_PROG_LIBTOOL =20 -PKG_CHECK_MODULES([GIO2], [gio-unix-2.0 >=3D GLIB2_REQUIRED]) -PKG_CHECK_MODULES([GLIB2], [glib-2.0 >=3D GLIB2_REQUIRED]) +PKG_CHECK_MODULES([GIO2], [gio-unix-2.0 >=3D $GLIB2_REQUIRED]) +PKG_CHECK_MODULES([GLIB2], [glib-2.0 >=3D $GLIB2_REQUIRED]) PKG_CHECK_MODULES([LIBVIRT], [libvirt >=3D $LIBVIRT_REQUIRED]) -PKG_CHECK_MODULES([LIBVIRT_GLIB], [libvirt-glib-1.0 >=3D LIBVIRT_GLIB_REQU= IRED]) +PKG_CHECK_MODULES([LIBVIRT_GLIB], [libvirt-glib-1.0 >=3D $LIBVIRT_GLIB_REQ= UIRED]) =20 LIBVIRT_COMPILE_WARNINGS LIBVIRT_LINKER_RELRO --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list