Commit 34a6962c41b4 added a BuildRequires for the
iscsi-direct backend, but we need the headers rather
than the runtime package to be available in order to
link against the library.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 libvirt.spec.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 788483cdd4..63834767dd 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -320,7 +320,7 @@ BuildRequires: lvm2
 # For pool type=iscsi
 BuildRequires: iscsi-initiator-utils
 # For pool type=iscsi-direct
-BuildRequires: libiscsi
+BuildRequires: libiscsi-devel
 # For disk driver
 BuildRequires: parted-devel
 # For Multipath support
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Tue, Aug 14, 2018 at 01:44:40PM +0200, Andrea Bolognani wrote:
> Commit 34a6962c41b4 added a BuildRequires for the
> iscsi-direct backend, but we need the headers rather
> than the runtime package to be available in order to
> link against the library.
>
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Tue, Aug 14, 2018 at 01:44:40PM +0200, Andrea Bolognani wrote:
> Commit 34a6962c41b4 added a BuildRequires for the
> iscsi-direct backend, but we need the headers rather
> than the runtime package to be available in order to
> link against the library.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  libvirt.spec.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 788483cdd4..63834767dd 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -320,7 +320,7 @@ BuildRequires: lvm2
>  # For pool type=iscsi
>  BuildRequires: iscsi-initiator-utils
>  # For pool type=iscsi-direct
> -BuildRequires: libiscsi
> +BuildRequires: libiscsi-devel
>  # For disk driver
>  BuildRequires: parted-devel
>  # For Multipath support

This change is correct but it's not good enough to fix all the issues in
specfile related to iscsi-direct, I'll post a patch in a minute that
fixes remaining issues including this one.

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Tue, 2018-08-14 at 14:18 +0200, Pavel Hrdina wrote:
> This change is correct but it's not good enough to fix all the issues in
> specfile related to iscsi-direct, I'll post a patch in a minute that
> fixes remaining issues including this one.

https://www.redhat.com/archives/libvir-list/2018-August/msg00831.html

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list