From nobody Thu Apr 25 16:27:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1534260658176220.94480911940673; Tue, 14 Aug 2018 08:30:58 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F3F4785550; Tue, 14 Aug 2018 15:30:55 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9750F608FA; Tue, 14 Aug 2018 15:30:55 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 35C8F18037ED; Tue, 14 Aug 2018 15:30:55 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w7EFUr1R020799 for ; Tue, 14 Aug 2018 11:30:53 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2C9C01C730; Tue, 14 Aug 2018 15:30:53 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C00CD1C731 for ; Tue, 14 Aug 2018 15:30:52 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Tue, 14 Aug 2018 17:30:44 +0200 Message-Id: <20180814153046.2911-2-abologna@redhat.com> In-Reply-To: <20180814153046.2911-1-abologna@redhat.com> References: <20180814153046.2911-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 1/3] tests: Point flake8 to the files it needs to check X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 14 Aug 2018 15:30:56 +0000 (UTC) X-ZohoMail: RDMRC_0 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Recent versions of the tool will look for Python scripts on their own, but when performing a VPATH build it's very likely the resulting list will be empty and nothing will actually be checked. Point flake8 to the files explicitly to avoid the issue. Signed-off-by: Andrea Bolognani Reviewed-by: J=EF=BF=BDn Tomko --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index cf7994e..a0696bf 100644 --- a/Makefile.am +++ b/Makefile.am @@ -46,6 +46,6 @@ gen-AUTHORS: # E501: (line too long) warning is ignored. .PHONY: flake8 flake8: - flake8 --show-source --ignore=3DE501 + flake8 --show-source --ignore=3DE501 $(srcdir)/tests/*.py =20 syntax-check: flake8 --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 16:27:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1534260666693325.18301267607546; Tue, 14 Aug 2018 08:31:06 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A9E25307D866; Tue, 14 Aug 2018 15:31:04 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 718725D6B4; Tue, 14 Aug 2018 15:31:04 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BC10618037F2; Tue, 14 Aug 2018 15:31:03 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w7EFUrm2020806 for ; Tue, 14 Aug 2018 11:30:54 -0400 Received: by smtp.corp.redhat.com (Postfix) id CCE2E1C730; Tue, 14 Aug 2018 15:30:53 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6BB721C731 for ; Tue, 14 Aug 2018 15:30:53 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Tue, 14 Aug 2018 17:30:45 +0200 Message-Id: <20180814153046.2911-3-abologna@redhat.com> In-Reply-To: <20180814153046.2911-1-abologna@redhat.com> References: <20180814153046.2911-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 2/3] configure: Detect flake8 automatically X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Tue, 14 Aug 2018 15:31:05 +0000 (UTC) X-ZohoMail: RDMRC_0 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" This also allows the user to run a custom flake8 by setting FLAKE8 in the environment. Signed-off-by: Andrea Bolognani Reviewed-by: J=EF=BF=BDn Tomko --- Makefile.am | 2 +- configure.ac | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index a0696bf..c6d09e6 100644 --- a/Makefile.am +++ b/Makefile.am @@ -46,6 +46,6 @@ gen-AUTHORS: # E501: (line too long) warning is ignored. .PHONY: flake8 flake8: - flake8 --show-source --ignore=3DE501 $(srcdir)/tests/*.py + $(FLAKE8) --show-source --ignore=3DE501 $(srcdir)/tests/*.py; =20 syntax-check: flake8 diff --git a/configure.ac b/configure.ac index 1c0e246..8722255 100644 --- a/configure.ac +++ b/configure.ac @@ -36,6 +36,7 @@ AC_PROG_MKDIR_P AM_PROG_CC_C_O AC_PROG_CC_STDC AC_PROG_LIBTOOL +AC_PATH_PROGS([FLAKE8], [flake8]) =20 PKG_CHECK_MODULES([GIO2], [gio-unix-2.0 >=3D $GLIB2_REQUIRED]) PKG_CHECK_MODULES([GLIB2], [glib-2.0 >=3D $GLIB2_REQUIRED]) --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 16:27:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1534260678156281.11421412587424; Tue, 14 Aug 2018 08:31:18 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7FBA530832D5; Tue, 14 Aug 2018 15:31:15 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 32F5C5DEDE; Tue, 14 Aug 2018 15:31:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B3E0A18037F4; Tue, 14 Aug 2018 15:31:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w7EFUs7O020815 for ; Tue, 14 Aug 2018 11:30:54 -0400 Received: by smtp.corp.redhat.com (Postfix) id 793CB1C730; Tue, 14 Aug 2018 15:30:54 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 17C441C735 for ; Tue, 14 Aug 2018 15:30:53 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Tue, 14 Aug 2018 17:30:46 +0200 Message-Id: <20180814153046.2911-4-abologna@redhat.com> In-Reply-To: <20180814153046.2911-1-abologna@redhat.com> References: <20180814153046.2911-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 3/3] configure: Find flake8 on FreeBSD X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Tue, 14 Aug 2018 15:31:16 +0000 (UTC) X-ZohoMail: RDMRC_0 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The newest version available from ports at the moment is built against Python 3.6 and is thus installed as flake8-3.6 on the platform. This makes syntax-check work out of the box on FreeBSD. Signed-off-by: Andrea Bolognani Reviewed-by: J=EF=BF=BDn Tomko --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 8722255..ccb02a4 100644 --- a/configure.ac +++ b/configure.ac @@ -36,7 +36,7 @@ AC_PROG_MKDIR_P AM_PROG_CC_C_O AC_PROG_CC_STDC AC_PROG_LIBTOOL -AC_PATH_PROGS([FLAKE8], [flake8]) +AC_PATH_PROGS([FLAKE8], [flake8 flake8-3.6]) =20 PKG_CHECK_MODULES([GIO2], [gio-unix-2.0 >=3D $GLIB2_REQUIRED]) PKG_CHECK_MODULES([GLIB2], [glib-2.0 >=3D $GLIB2_REQUIRED]) --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list