In what is perhaps a couple lifetimes ago at this point, patches were posted and "mostly" all eventually accepted upstream to support unpriv_sgio on SCSI generic hostdev devices. Since the needed parts of the functionality from the kernel perspective were not yet present upstream, a couple of the patches were not accepted. See: https://www.redhat.com/archives/libvir-list/2015-July/msg00204.html and in particular patches 9 and 10. Since that time it seems things have changed and this essentially reposts those two patches with some minor adjustments in logic in order to "restore" the support. There are lots of interesting tidbits in unreadable by the general public bz's, so I won't include links here. John Ferlan (2): qemu: Add ability to set sgio values for hostdev qemu: Add check for unpriv sgio for SCSI generic host device src/qemu/qemu_conf.c | 34 ++++++++++++++++++++++++---------- 1 file changed, 24 insertions(+), 10 deletions(-) -- 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, Aug 23, 2018 at 11:50:00AM -0400, John Ferlan wrote: >In what is perhaps a couple lifetimes ago at this point, patches >were posted and "mostly" all eventually accepted upstream to support >unpriv_sgio on SCSI generic hostdev devices. Since the needed parts >of the functionality from the kernel perspective were not yet present >upstream, a couple of the patches were not accepted. See: > >https://www.redhat.com/archives/libvir-list/2015-July/msg00204.html > >and in particular patches 9 and 10. Since that time it seems things >have changed Nice! Do you have the kernel commit IDs? Jano >and this essentially reposts those two patches with >some minor adjustments in logic in order to "restore" the support. >There are lots of interesting tidbits in unreadable by the general >public bz's, so I won't include links here. > >John Ferlan (2): > qemu: Add ability to set sgio values for hostdev > qemu: Add check for unpriv sgio for SCSI generic host device > > src/qemu/qemu_conf.c | 34 ++++++++++++++++++++++++---------- > 1 file changed, 24 insertions(+), 10 deletions(-) > >-- >2.17.1 > >-- >libvir-list mailing list >libvir-list@redhat.com >https://www.redhat.com/mailman/listinfo/libvir-list -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, Aug 24, 2018 at 01:32:41PM +0200, Ján Tomko wrote: > On Thu, Aug 23, 2018 at 11:50:00AM -0400, John Ferlan wrote: > > In what is perhaps a couple lifetimes ago at this point, patches > > were posted and "mostly" all eventually accepted upstream to support > > unpriv_sgio on SCSI generic hostdev devices. Since the needed parts > > of the functionality from the kernel perspective were not yet present > > upstream, a couple of the patches were not accepted. See: > > > > https://www.redhat.com/archives/libvir-list/2015-July/msg00204.html > > > > and in particular patches 9 and 10. Since that time it seems things > > have changed > > Nice! > > Do you have the kernel commit IDs? I've not found any sign of the "unpriv_sgio" sysfs file existing in today's upstream LKML tree, so I'm not sure this is correct. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 08/24/2018 09:02 AM, Daniel P. Berrangé wrote: > On Fri, Aug 24, 2018 at 01:32:41PM +0200, Ján Tomko wrote: >> On Thu, Aug 23, 2018 at 11:50:00AM -0400, John Ferlan wrote: >>> In what is perhaps a couple lifetimes ago at this point, patches >>> were posted and "mostly" all eventually accepted upstream to support >>> unpriv_sgio on SCSI generic hostdev devices. Since the needed parts >>> of the functionality from the kernel perspective were not yet present >>> upstream, a couple of the patches were not accepted. See: >>> >>> https://www.redhat.com/archives/libvir-list/2015-July/msg00204.html >>> >>> and in particular patches 9 and 10. Since that time it seems things >>> have changed >> >> Nice! >> >> Do you have the kernel commit IDs? > > I've not found any sign of the "unpriv_sgio" sysfs file existing > in today's upstream LKML tree, so I'm not sure this is correct. > OK then, so much for assumptions... Well then we'll ignore this for now.. It's rather a painful to follow all the links in the private bz's on this. John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
© 2016 - 2024 Red Hat, Inc.