[libvirt] [PATCH] vsh: Fix broken build on mingw

Simon Kobyda posted 1 patch 5 years, 7 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180827154429.11094-1-skobyda@redhat.com
Test syntax-check passed
bootstrap.conf | 1 +
1 file changed, 1 insertion(+)
[libvirt] [PATCH] vsh: Fix broken build on mingw
Posted by Simon Kobyda 5 years, 7 months ago
The function wcwidth() doesn't exist on mingw. However we can
implement this function from gnulib.
Broken gnulib on CentOS and RHEL still persists.

Signed-off-by: Simon Kobyda <skobyda@redhat.com>
---
 bootstrap.conf | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bootstrap.conf b/bootstrap.conf
index 698a52216b..d9e2b0662c 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -126,6 +126,7 @@ vc-list-files
 vsnprintf
 waitpid
 warnings
+wcwidth
 '
 
 SKIP_PO=true
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] vsh: Fix broken build on mingw
Posted by Erik Skultety 5 years, 7 months ago
On Mon, Aug 27, 2018 at 05:44:29PM +0200, Simon Kobyda wrote:
> The function wcwidth() doesn't exist on mingw. However we can
> implement this function from gnulib.
> Broken gnulib on CentOS and RHEL still persists.

^This fact is irrelevant to this patch. I dropped the sentence, reworded the
rest a tiny bit and pushed.

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list