[libvirt] [snmp PATCH] Fix wrong object OIDs sent by libvirtMib_subagent

Miguel Martin posted 1 patch 5 years, 6 months ago
Failed in applying to current master (apply log)
src/libvirtNotifications.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[libvirt] [snmp PATCH] Fix wrong object OIDs sent by libvirtMib_subagent
Posted by Miguel Martin 5 years, 6 months ago
The objects OIDs sent by the guest agent are:
libvirtGuestName.0
libvirtGuestUUID.1
libvirtGuestState.2
libvirtGuestRowStatus.3

The expected libvirtGuestNotif objects OID would be:
libvirtGuestName.0
libvirtGuestUUID.0
libvirtGuestState.0
libvirtGuestRowStatus.0

Signed-off-by: Miguel Martin <mmartinv@redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1624839
---
 src/libvirtNotifications.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/libvirtNotifications.c b/src/libvirtNotifications.c
index 135f177..0522d54 100644
--- a/src/libvirtNotifications.c
+++ b/src/libvirtNotifications.c
@@ -38,11 +38,11 @@ send_libvirtGuestNotif_trap(virDomainPtr dom)
     const oid libvirtGuestName_oid[] =
         { 1, 3, 6, 1, 4, 1, 36957, 1, 1, 1, 2, 0 };
     const oid libvirtGuestUUID_oid[] =
-        { 1, 3, 6, 1, 4, 1, 36957, 1, 1, 1, 1, 1 };
+        { 1, 3, 6, 1, 4, 1, 36957, 1, 1, 1, 1, 0 };
     const oid libvirtGuestState_oid[] =
-        { 1, 3, 6, 1, 4, 1, 36957, 1, 1, 1, 3, 2 };
+        { 1, 3, 6, 1, 4, 1, 36957, 1, 1, 1, 3, 0 };
     const oid libvirtGuestRowStatus_oid[] =
-        { 1, 3, 6, 1, 4, 1, 36957, 1, 1, 1, 9, 3 };
+        { 1, 3, 6, 1, 4, 1, 36957, 1, 1, 1, 9, 0 };
 
 
     const char *domName = virDomainGetName(dom);
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [snmp PATCH] Fix wrong object OIDs sent by libvirtMib_subagent
Posted by Michal Privoznik 5 years, 6 months ago
On 09/03/2018 02:44 PM, Miguel Martin wrote:
> The objects OIDs sent by the guest agent are:
> libvirtGuestName.0
> libvirtGuestUUID.1
> libvirtGuestState.2
> libvirtGuestRowStatus.3
> 
> The expected libvirtGuestNotif objects OID would be:
> libvirtGuestName.0
> libvirtGuestUUID.0
> libvirtGuestState.0
> libvirtGuestRowStatus.0
> 
> Signed-off-by: Miguel Martin <mmartinv@redhat.com>
> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1624839
> ---
>  src/libvirtNotifications.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)


ACKed and pushed.

Congratulations on your first libvirt-snmp contribution!

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list