[libvirt] [PATCH 0/2] tests: Add QEMU 3.0.0 capability tests for s390x

Boris Fiuczynski posted 2 patches 5 years, 6 months ago
Failed in applying to current master (apply log)
.../domaincapsschemadata/qemu_3.0.0.s390x.xml |   183 +
tests/domaincapstest.c                        |     4 +
.../caps_3.0.0.s390x.replies                  | 20530 ++++++++++++++++
.../qemucapabilitiesdata/caps_3.0.0.s390x.xml |  2691 ++
tests/qemucapabilitiestest.c                  |     1 +
5 files changed, 23409 insertions(+)
create mode 100644 tests/domaincapsschemadata/qemu_3.0.0.s390x.xml
create mode 100644 tests/qemucapabilitiesdata/caps_3.0.0.s390x.replies
create mode 100644 tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml
[libvirt] [PATCH 0/2] tests: Add QEMU 3.0.0 capability tests for s390x
Posted by Boris Fiuczynski 5 years, 6 months ago
Add capability and domcaps tests for QEMU 3.0.0 on s390x.

Boris Fiuczynski (2):
  tests: Add capabilities data for QEMU 3.0.0 on s390x
  tests: domaincaps: Add QEMU 3.0 for s390x

 .../domaincapsschemadata/qemu_3.0.0.s390x.xml |   183 +
 tests/domaincapstest.c                        |     4 +
 .../caps_3.0.0.s390x.replies                  | 20530 ++++++++++++++++
 .../qemucapabilitiesdata/caps_3.0.0.s390x.xml |  2691 ++
 tests/qemucapabilitiestest.c                  |     1 +
 5 files changed, 23409 insertions(+)
 create mode 100644 tests/domaincapsschemadata/qemu_3.0.0.s390x.xml
 create mode 100644 tests/qemucapabilitiesdata/caps_3.0.0.s390x.replies
 create mode 100644 tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml

-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/2] tests: Add QEMU 3.0.0 capability tests for s390x
Posted by John Ferlan 5 years, 6 months ago

On 09/20/2018 06:20 AM, Boris Fiuczynski wrote:
> Add capability and domcaps tests for QEMU 3.0.0 on s390x.
> 
> Boris Fiuczynski (2):
>   tests: Add capabilities data for QEMU 3.0.0 on s390x
>   tests: domaincaps: Add QEMU 3.0 for s390x
> 
>  .../domaincapsschemadata/qemu_3.0.0.s390x.xml |   183 +
>  tests/domaincapstest.c                        |     4 +
>  .../caps_3.0.0.s390x.replies                  | 20530 ++++++++++++++++
>  .../qemucapabilitiesdata/caps_3.0.0.s390x.xml |  2691 ++
>  tests/qemucapabilitiestest.c                  |     1 +
>  5 files changed, 23409 insertions(+)
>  create mode 100644 tests/domaincapsschemadata/qemu_3.0.0.s390x.xml
>  create mode 100644 tests/qemucapabilitiesdata/caps_3.0.0.s390x.replies
>  create mode 100644 tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>
(series)

and pushed,

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/2] tests: Add QEMU 3.0.0 capability tests for s390x
Posted by Bjoern Walk 5 years, 6 months ago
John Ferlan <jferlan@redhat.com> [2018-09-20, 04:30PM -0400]:
> 
> 
> On 09/20/2018 06:20 AM, Boris Fiuczynski wrote:
> > Add capability and domcaps tests for QEMU 3.0.0 on s390x.
> > 
> > Boris Fiuczynski (2):
> >   tests: Add capabilities data for QEMU 3.0.0 on s390x
> >   tests: domaincaps: Add QEMU 3.0 for s390x
> > 
> >  .../domaincapsschemadata/qemu_3.0.0.s390x.xml |   183 +
> >  tests/domaincapstest.c                        |     4 +
> >  .../caps_3.0.0.s390x.replies                  | 20530 ++++++++++++++++
> >  .../qemucapabilitiesdata/caps_3.0.0.s390x.xml |  2691 ++
> >  tests/qemucapabilitiestest.c                  |     1 +
> >  5 files changed, 23409 insertions(+)
> >  create mode 100644 tests/domaincapsschemadata/qemu_3.0.0.s390x.xml
> >  create mode 100644 tests/qemucapabilitiesdata/caps_3.0.0.s390x.replies
> >  create mode 100644 tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml
> > 
> 
> Reviewed-by: John Ferlan <jferlan@redhat.com>
> (series)
> 
> and pushed,

Thanks, but just for interest, tracking Reviewed-by and other tags is a
thing in libvirt or not?

> 
> John
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
> 

-- 
IBM Systems
Linux on Z & Virtualization Development
------------------------------------------------------------------------
IBM Deutschland Research & Development GmbH
Schönaicher Str. 220, 71032 Böblingen
Phone: +49 7031 16 1819
------------------------------------------------------------------------
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294 
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/2] tests: Add QEMU 3.0.0 capability tests for s390x
Posted by John Ferlan 5 years, 6 months ago

On 09/21/2018 01:13 AM, Bjoern Walk wrote:
> John Ferlan <jferlan@redhat.com> [2018-09-20, 04:30PM -0400]:
>>
>>
>> On 09/20/2018 06:20 AM, Boris Fiuczynski wrote:
>>> Add capability and domcaps tests for QEMU 3.0.0 on s390x.
>>>
>>> Boris Fiuczynski (2):
>>>   tests: Add capabilities data for QEMU 3.0.0 on s390x
>>>   tests: domaincaps: Add QEMU 3.0 for s390x
>>>
>>>  .../domaincapsschemadata/qemu_3.0.0.s390x.xml |   183 +
>>>  tests/domaincapstest.c                        |     4 +
>>>  .../caps_3.0.0.s390x.replies                  | 20530 ++++++++++++++++
>>>  .../qemucapabilitiesdata/caps_3.0.0.s390x.xml |  2691 ++
>>>  tests/qemucapabilitiestest.c                  |     1 +
>>>  5 files changed, 23409 insertions(+)
>>>  create mode 100644 tests/domaincapsschemadata/qemu_3.0.0.s390x.xml
>>>  create mode 100644 tests/qemucapabilitiesdata/caps_3.0.0.s390x.replies
>>>  create mode 100644 tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml
>>>
>>
>> Reviewed-by: John Ferlan <jferlan@redhat.com>
>> (series)
>>
>> and pushed,
> 
> Thanks, but just for interest, tracking Reviewed-by and other tags is a
> thing in libvirt or not?
> 

<face-palm> - totally forgot to do that on this series - my apologies...
I still haven't succumbed to figuring out a way to make the R-B add
happen automagically.... And our hook only cares to see the S-O-B.

To answer the question - there's no "official" tracking. Some people
still use ACK while others use R-By. It was hard enough to jump the
hurdle for S-O-B.

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/2] tests: Add QEMU 3.0.0 capability tests for s390x
Posted by Bjoern Walk 5 years, 6 months ago
John Ferlan <jferlan@redhat.com> [2018-09-21, 07:46AM -0400]:
> 
> 
> On 09/21/2018 01:13 AM, Bjoern Walk wrote:
> > John Ferlan <jferlan@redhat.com> [2018-09-20, 04:30PM -0400]:
> >>
> >>
> >> On 09/20/2018 06:20 AM, Boris Fiuczynski wrote:
> >>> Add capability and domcaps tests for QEMU 3.0.0 on s390x.
> >>>
> >>> Boris Fiuczynski (2):
> >>>   tests: Add capabilities data for QEMU 3.0.0 on s390x
> >>>   tests: domaincaps: Add QEMU 3.0 for s390x
> >>>
> >>>  .../domaincapsschemadata/qemu_3.0.0.s390x.xml |   183 +
> >>>  tests/domaincapstest.c                        |     4 +
> >>>  .../caps_3.0.0.s390x.replies                  | 20530 ++++++++++++++++
> >>>  .../qemucapabilitiesdata/caps_3.0.0.s390x.xml |  2691 ++
> >>>  tests/qemucapabilitiestest.c                  |     1 +
> >>>  5 files changed, 23409 insertions(+)
> >>>  create mode 100644 tests/domaincapsschemadata/qemu_3.0.0.s390x.xml
> >>>  create mode 100644 tests/qemucapabilitiesdata/caps_3.0.0.s390x.replies
> >>>  create mode 100644 tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml
> >>>
> >>
> >> Reviewed-by: John Ferlan <jferlan@redhat.com>
> >> (series)
> >>
> >> and pushed,
> > 
> > Thanks, but just for interest, tracking Reviewed-by and other tags is a
> > thing in libvirt or not?
> > 
> 
> <face-palm> - totally forgot to do that on this series - my apologies...
> I still haven't succumbed to figuring out a way to make the R-B add
> happen automagically.... And our hook only cares to see the S-O-B.

No worries. Normally we review our stuff internally first, so the rev-bys
are added to the upstream patch. For more complex patches I think we
will continue this way.

> To answer the question - there's no "official" tracking. Some people
> still use ACK while others use R-By. It was hard enough to jump the
> hurdle for S-O-B.

Ok, good to know.

-- 
IBM Systems
Linux on Z & Virtualization Development
------------------------------------------------------------------------
IBM Deutschland Research & Development GmbH
Schönaicher Str. 220, 71032 Böblingen
Phone: +49 7031 16 1819
------------------------------------------------------------------------
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294 
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/2] tests: Add QEMU 3.0.0 capability tests for s390x
Posted by Boris Fiuczynski 5 years, 6 months ago
Thanks for the review and push.


On 9/20/18 10:30 PM, John Ferlan wrote:
> 
> 
> On 09/20/2018 06:20 AM, Boris Fiuczynski wrote:
>> Add capability and domcaps tests for QEMU 3.0.0 on s390x.
>>
>> Boris Fiuczynski (2):
>>    tests: Add capabilities data for QEMU 3.0.0 on s390x
>>    tests: domaincaps: Add QEMU 3.0 for s390x
>>
>>   .../domaincapsschemadata/qemu_3.0.0.s390x.xml |   183 +
>>   tests/domaincapstest.c                        |     4 +
>>   .../caps_3.0.0.s390x.replies                  | 20530 ++++++++++++++++
>>   .../qemucapabilitiesdata/caps_3.0.0.s390x.xml |  2691 ++
>>   tests/qemucapabilitiestest.c                  |     1 +
>>   5 files changed, 23409 insertions(+)
>>   create mode 100644 tests/domaincapsschemadata/qemu_3.0.0.s390x.xml
>>   create mode 100644 tests/qemucapabilitiesdata/caps_3.0.0.s390x.replies
>>   create mode 100644 tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml
>>
> 
> Reviewed-by: John Ferlan <jferlan@redhat.com>
> (series)
> 
> and pushed,
> 
> John
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
> 


-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/2] tests: Add QEMU 3.0.0 capability tests for s390x
Posted by Bjoern Walk 5 years, 6 months ago
Boris Fiuczynski <fiuczy@linux.ibm.com> [2018-09-20, 12:20PM +0200]:
> Add capability and domcaps tests for QEMU 3.0.0 on s390x.
> 
> Boris Fiuczynski (2):
>   tests: Add capabilities data for QEMU 3.0.0 on s390x
>   tests: domaincaps: Add QEMU 3.0 for s390x
> 
>  .../domaincapsschemadata/qemu_3.0.0.s390x.xml |   183 +
>  tests/domaincapstest.c                        |     4 +
>  .../caps_3.0.0.s390x.replies                  | 20530 ++++++++++++++++
>  .../qemucapabilitiesdata/caps_3.0.0.s390x.xml |  2691 ++
>  tests/qemucapabilitiestest.c                  |     1 +
>  5 files changed, 23409 insertions(+)
>  create mode 100644 tests/domaincapsschemadata/qemu_3.0.0.s390x.xml
>  create mode 100644 tests/qemucapabilitiesdata/caps_3.0.0.s390x.replies
>  create mode 100644 tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml

Reviewed-by: Bjoern Walk <bwalk@linux.ibm.com> series, even the patch that
only found it's way through internal channels. Let's hope the mailing list
will catch up.

-- 
IBM Systems
Linux on Z & Virtualization Development
------------------------------------------------------------------------
IBM Deutschland Research & Development GmbH
Schönaicher Str. 220, 71032 Böblingen
Phone: +49 7031 16 1819
------------------------------------------------------------------------
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294 
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/2] tests: Add QEMU 3.0.0 capability tests for s390x
Posted by John Ferlan 5 years, 6 months ago

On 09/20/2018 07:20 AM, Bjoern Walk wrote:
> Boris Fiuczynski <fiuczy@linux.ibm.com> [2018-09-20, 12:20PM +0200]:
>> Add capability and domcaps tests for QEMU 3.0.0 on s390x.
>>
>> Boris Fiuczynski (2):
>>   tests: Add capabilities data for QEMU 3.0.0 on s390x
>>   tests: domaincaps: Add QEMU 3.0 for s390x
>>
>>  .../domaincapsschemadata/qemu_3.0.0.s390x.xml |   183 +
>>  tests/domaincapstest.c                        |     4 +
>>  .../caps_3.0.0.s390x.replies                  | 20530 ++++++++++++++++
>>  .../qemucapabilitiesdata/caps_3.0.0.s390x.xml |  2691 ++
>>  tests/qemucapabilitiestest.c                  |     1 +
>>  5 files changed, 23409 insertions(+)
>>  create mode 100644 tests/domaincapsschemadata/qemu_3.0.0.s390x.xml
>>  create mode 100644 tests/qemucapabilitiesdata/caps_3.0.0.s390x.replies
>>  create mode 100644 tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml
> 
> Reviewed-by: Bjoern Walk <bwalk@linux.ibm.com> series, even the patch that
> only found it's way through internal channels. Let's hope the mailing list
> will catch up.
> 

I'm assuming it's stuck in moderation because of size.  Someone will
"free" it from it's purgatory - hopefully today. I've pinged on our
internal IRC - I always forget "who" is "on the list"...

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list