[libvirt] [libvirt PATCH v7 0/6] Finish the conversion to virConfGetValue* functions

Fabiano Fidêncio posted 6 patches 5 years, 6 months ago
Failed in applying to current master (apply log)
src/xenconfig/xen_common.c | 202 ++++++++++++++++++++-----------------
src/xenconfig/xen_common.h |   2 +-
src/xenconfig/xen_xl.c     |  10 +-
src/xenconfig/xen_xm.c     |   7 +-
4 files changed, 120 insertions(+), 101 deletions(-)
[libvirt] [libvirt PATCH v7 0/6] Finish the conversion to virConfGetValue* functions
Posted by Fabiano Fidêncio 5 years, 6 months ago
This patchset finishes the conversion to virConfGetValue* functions,
started by Daniel Berrange a few months ago.

Please, mind that although we could make virConfGetValue* functions more
generic in order to support numbers and booleans as strings, that
doesn't seem the safest path to take. The side-effect of this is that we
will have to live with some specific code doing that as part of vmx and
xen_common.

Once this patchset gets merged,
https://wiki.libvirt.org/page/BiteSizedTasks#Finish_conversion_to_virConfGetValue.2A_functions
can be removed.

- Changes since v1:
  All the "values" from virConfGetValueString() are freed

- Changes since v2:
  All comments from Ján Tomko have been addressed;
  A few leaks were (possibly) found and they're addressed in the last
  patch of the series;

- Changes since v3:
  All comments from Ján Tomko have been addressed in order to lower the
  non-whitespace changes in the first patch;

- Changes since v4:
  All comments from Ján Tomko have been addressed (hopefully, they
  actually were this time :-));

- Changes since v5:
  All comments from John Ferlan have been addressed, including splitting
  the patches per "function" touched. Some new patches were also needed
  due to a behaviour change introduced by the "xen_common: Change
  xenParsePCIList to using virConfGetValueStringList" patch.

- Changes since v6:
  Actually properly building the code /o\ (John, --with-libxl is what
  you need!)
  Squashed all the patches fixing the leak with the patch that
  introduces the leak
  Followed John's suggestions and comments in order to try to keep the
  new checks as close as possible to the old ones.


Fabiano Fidêncio (6):
  xen_common: Change xenConfigCopyStringInternal to using
    virConfGetValueString
  xen_common: Change xenConfigGetUUID to using virConfGetValueString
  xen_common: Change xenConfigGetString to using virConfGetValueString
  xen_common: Change xenParsePCIList to using virConfGetValueStringList
  xen_common: Change xenParseVfbs to using virConfGetValueStringList
  xen_common: Change xenParseCharDev to using virConfGetValueStringList

 src/xenconfig/xen_common.c | 202 ++++++++++++++++++++-----------------
 src/xenconfig/xen_common.h |   2 +-
 src/xenconfig/xen_xl.c     |  10 +-
 src/xenconfig/xen_xm.c     |   7 +-
 4 files changed, 120 insertions(+), 101 deletions(-)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list