[libvirt] [PATCH v2 00/13] Implement vsh-table API to virsh and virt-admin

Simon Kobyda posted 13 patches 5 years, 7 months ago
Failed in applying to current master (apply log)
tools/virsh-domain-monitor.c | 147 ++++++++++++++++---------------
tools/virsh-domain.c         |  98 +++++++++++++++------
tools/virsh-interface.c      |  27 ++++--
tools/virsh-network.c        |  59 ++++++++-----
tools/virsh-nwfilter.c       |  47 +++++++---
tools/virsh-pool.c           | 162 +++++++----------------------------
tools/virsh-secret.c         |  28 ++++--
tools/virsh-snapshot.c       |  33 ++++---
tools/virsh-volume.c         | 129 ++++++----------------------
tools/virt-admin.c           |  47 +++++++---
10 files changed, 371 insertions(+), 406 deletions(-)
[libvirt] [PATCH v2 00/13] Implement vsh-table API to virsh and virt-admin
Posted by Simon Kobyda 5 years, 7 months ago
API is implemented in virsh and virt-admin. It fixes problems with
table-alignment, makes tables more readable and deals with unicode.
Table however could not be implemented in places, which do use simple
lists, or table implementation would change content of output,
which users might rely on.
If you know about other place where it could be implemented,
let me know.

https://bugzilla.redhat.com/show_bug.cgi?id=1574624
https://bugzilla.redhat.com/show_bug.cgi?id=1584630

Changes in v2:
- Implemented gettext function
- Fixed few possible leaks caused by inserting "goto cleanup" statements
- Implemented VIR_AUTOFREE where it's appropriate

Simon Kobyda (13):
  virsh: Implement vsh-table to iface-list
  virsh: Implement vshTable API to net-list and net-dhcp-leases
  virsh: Implement vshTable API to secret-list
  virsh: Implement vshTable API to nwfilter-list and
    nwfilterbinding-list
  virsh: Implement vshTable API to snapshot-list.
  virsh: Set up cmdDomblkinfo() and cmdDomblkinfoPrint() for vshTable
    API implementation
  virsh: Implement vshTable API to domblkinfo
  virsh: Implement vshTable API to domblklist
  virsh: Implement vshTable API to domiflist
  virsh: Implement vshTable API to vcpupin, iothreadinfo, domfsinfo
  virsh: Implement vshTable API to pool-list
  virsh: Implement vshTable API to vol-list
  virt-admin: Implement vshTable API to server-list and client-list

 tools/virsh-domain-monitor.c | 147 ++++++++++++++++---------------
 tools/virsh-domain.c         |  98 +++++++++++++++------
 tools/virsh-interface.c      |  27 ++++--
 tools/virsh-network.c        |  59 ++++++++-----
 tools/virsh-nwfilter.c       |  47 +++++++---
 tools/virsh-pool.c           | 162 +++++++----------------------------
 tools/virsh-secret.c         |  28 ++++--
 tools/virsh-snapshot.c       |  33 ++++---
 tools/virsh-volume.c         | 129 ++++++----------------------
 tools/virt-admin.c           |  47 +++++++---
 10 files changed, 371 insertions(+), 406 deletions(-)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 00/13] Implement vsh-table API to virsh and virt-admin
Posted by Michal Privoznik 5 years, 7 months ago
On 09/21/2018 04:17 PM, Simon Kobyda wrote:
> API is implemented in virsh and virt-admin. It fixes problems with
> table-alignment, makes tables more readable and deals with unicode.
> Table however could not be implemented in places, which do use simple
> lists, or table implementation would change content of output,
> which users might rely on.
> If you know about other place where it could be implemented,
> let me know.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1574624
> https://bugzilla.redhat.com/show_bug.cgi?id=1584630
> 
> Changes in v2:
> - Implemented gettext function
> - Fixed few possible leaks caused by inserting "goto cleanup" statements
> - Implemented VIR_AUTOFREE where it's appropriate
> 
> Simon Kobyda (13):
>   virsh: Implement vsh-table to iface-list
>   virsh: Implement vshTable API to net-list and net-dhcp-leases
>   virsh: Implement vshTable API to secret-list
>   virsh: Implement vshTable API to nwfilter-list and
>     nwfilterbinding-list
>   virsh: Implement vshTable API to snapshot-list.
>   virsh: Set up cmdDomblkinfo() and cmdDomblkinfoPrint() for vshTable
>     API implementation
>   virsh: Implement vshTable API to domblkinfo
>   virsh: Implement vshTable API to domblklist
>   virsh: Implement vshTable API to domiflist
>   virsh: Implement vshTable API to vcpupin, iothreadinfo, domfsinfo
>   virsh: Implement vshTable API to pool-list
>   virsh: Implement vshTable API to vol-list
>   virt-admin: Implement vshTable API to server-list and client-list
> 
>  tools/virsh-domain-monitor.c | 147 ++++++++++++++++---------------
>  tools/virsh-domain.c         |  98 +++++++++++++++------
>  tools/virsh-interface.c      |  27 ++++--
>  tools/virsh-network.c        |  59 ++++++++-----
>  tools/virsh-nwfilter.c       |  47 +++++++---
>  tools/virsh-pool.c           | 162 +++++++----------------------------
>  tools/virsh-secret.c         |  28 ++++--
>  tools/virsh-snapshot.c       |  33 ++++---
>  tools/virsh-volume.c         | 129 ++++++----------------------
>  tools/virt-admin.c           |  47 +++++++---
>  10 files changed, 371 insertions(+), 406 deletions(-)
> 

ACKed and pushed.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list