Update 'Device address' section to describe 'zpci' element and
its two attributes 'uid' and 'fid'.

Signed-off-by: Yi Min Zhao <zyimin@linux.ibm.com>
Reviewed-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
Reviewed-by: Stefan Zimmermann <stzi@linux.ibm.com>
---
 docs/formatdomain.html.in | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 8189959773..a6e07e4a8a 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -3925,7 +3925,14 @@
         (<span class="since">since 0.9.7, requires QEMU
         0.13</span>). <code>multifunction</code> defaults to 'off',
         but should be set to 'on' for function 0 of a slot that will
-        have multiple functions used.<br/>
+        have multiple functions used.
+        (<span class="since">Since 4.8.0 </span>), PCI address extensions
+        depending on the architecture are supported. E.g. for S390 guests,
+        PCI addresses have child element: <code>zpci</code>, which has
+        two attributes <code>uid</code> (a hex value between 0x0001 and
+        0xffff, inclusive), and <code>fid</code> (a hex value between
+        0x00000000 and 0xffffffff, inclusive) used by PCI devices on S390
+        for User-defined Identifiers and Function Identifiers.<br/>
         <span class="since">Since 1.3.5</span>, some hypervisor
         drivers may accept an <code>&lt;address type='pci'/&gt;</code>
         element with no other attributes as an explicit request to
-- 
Yi Min

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote:
[...]
> @@ -3925,7 +3925,14 @@
>          (<span class="since">since 0.9.7, requires QEMU
>          0.13</span>). <code>multifunction</code> defaults to 'off',
>          but should be set to 'on' for function 0 of a slot that will
> -        have multiple functions used.<br/>
> +        have multiple functions used.
> +        (<span class="since">Since 4.8.0 </span>), PCI address extensions

No space after 4.8.0; also it should read 4.9.0 now ;)

> +        depending on the architecture are supported. E.g. for S390 guests,
> +        PCI addresses have child element: <code>zpci</code>, which has
> +        two attributes <code>uid</code> (a hex value between 0x0001 and

  "[...] are supported. For example, PCI addresses for S390 guests
   will have a <code>zpci</code> child element, with two attributes:
   <code>uid</code> [...]"

With the above,

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

在 2018/10/12 下午11:03, Andrea Bolognani 写道:
> On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote:
> [...]
>> @@ -3925,7 +3925,14 @@
>>           (<span class="since">since 0.9.7, requires QEMU
>>           0.13</span>). <code>multifunction</code> defaults to 'off',
>>           but should be set to 'on' for function 0 of a slot that will
>> -        have multiple functions used.<br/>
>> +        have multiple functions used.
>> +        (<span class="since">Since 4.8.0 </span>), PCI address extensions
> No space after 4.8.0; also it should read 4.9.0 now ;)
This patch set was posted before 4.9.0. Now it should be 4.9.0.
Thanks for your reminder.
>
>> +        depending on the architecture are supported. E.g. for S390 guests,
>> +        PCI addresses have child element: <code>zpci</code>, which has
>> +        two attributes <code>uid</code> (a hex value between 0x0001 and
>    "[...] are supported. For example, PCI addresses for S390 guests
>     will have a <code>zpci</code> child element, with two attributes:
>     <code>uid</code> [...]"
>
> With the above,
>
>    Reviewed-by: Andrea Bolognani <abologna@redhat.com>
>
Thanks!

-- 
Yi Min

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list