[libvirt] [PATCH v2] news: Update for 4.8.0 release

Fabiano Fidêncio posted 1 patch 5 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20181001105718.20705-1-fidencio@redhat.com
There is a newer version of this series
docs/news.xml | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 69 insertions(+)
[libvirt] [PATCH v2] news: Update for 4.8.0 release
Posted by Fabiano Fidêncio 5 years, 6 months ago
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
---
I went through the commits since last release and added a few notes
which seem to be relevant for the news.

In case you notice there's something missing, please, either send me the
text to add it (and I'll re-sping this patch) and add the text before
merging this one.

Changes since v1:
- Actually run make-check in order to be sure the changes are fine.
---
 docs/news.xml | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 69 insertions(+)

diff --git a/docs/news.xml b/docs/news.xml
index 3ed6ff8aeb..62148d28af 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -44,6 +44,26 @@
           and virDomainPMWakeup APIs.
         </description>
       </change>
+      <change>
+        <summary>
+          utils: Introduce monitor capability interface
+        </summary>
+        <description>
+          The resource monitor has been introduces and it creates the interface
+          for getting the host capability of the resource monitor from the system
+          resource control.
+          The resource monitor takes the role of RDT monitoring groups and could
+          be used to monitor the resource consumption information.
+        </description>
+      </change>
+      <change>
+        <summary>
+          conf: Introduce RDT monitor host capability
+        </summary>
+        <description>
+          Introduce cache monitor (CMT) and memory bandwidth monitor (MBM).
+        </description>
+      </change>
     </section>
     <section title="Removed features">
       <change>
@@ -55,6 +75,15 @@
           Drop support for these older versions and require Xen >= 4.6.
         </description>
       </change>
+      <change>
+        <summary>
+          nwfilter: Disallow binding creation in session mode
+        </summary>
+        <description>
+          Ensure that a filter binding creation is not attempted in session
+          mode and generate the proper error message.
+        </description>
+      </change>
     </section>
     <section title="Improvements">
       <change>
@@ -68,8 +97,48 @@
           Guest Agent.
         </description>
       </change>
+      <change>
+        <summary>
+          storage: Allow to use any format as input volume for encryption
+        </summary>
+        <description>
+          Since v4.5.0 libvirt has support to use a 'raw' input volume for
+          encryption. From now on, let's not limit this to 'raw' only.
+        </description>
+      </change>
+      <change>
+        <summary>
+          libxl: Add support to set shadow memory for any guest type
+        </summary>
+        <description>
+          PVH guests now can take advantage of using shadow memory.
+        </description>
+      </change>
     </section>
     <section title="Bug fixes">
+      <change>
+        <summary>
+          virsh: Require explicit --domain for domxml-to-native
+        </summary>
+        <description>
+          The domxml-to-native virsh command accepts either --xml or --domain
+          option followed by a file or domain name respectively, The --domain
+          option is documented as required, which means an argument with no
+          option is treated as --xml. Commit v4.3.0-127-gd86531daf2 broke this
+          by making --domain optional and thus an argument with no option was
+          treated as --domain.
+        </description>
+      </change>
+      <change>
+        <summary>
+          lxc_monitor: Avoid AB / BA lock race
+        </summary>
+        <description>
+          A dealock situation could occur when autostarting a LXC domain 'guest'
+          due to two threads attempting to take opposing locks while holding
+          opposing locks (AB BA problem).
+        </description>
+      </change>
     </section>
   </release>
   <release version="v4.7.0" date="2018-09-03">
-- 
2.19.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2] news: Update for 4.8.0 release
Posted by Erik Skultety 5 years, 6 months ago
On Mon, Oct 01, 2018 at 12:57:18PM +0200, Fabiano Fidêncio wrote:
> Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
> ---
> I went through the commits since last release and added a few notes
> which seem to be relevant for the news.
>
> In case you notice there's something missing, please, either send me the
> text to add it (and I'll re-sping this patch) and add the text before
> merging this one.
>
> Changes since v1:
> - Actually run make-check in order to be sure the changes are fine.
> ---
>  docs/news.xml | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 69 insertions(+)
>
> diff --git a/docs/news.xml b/docs/news.xml
> index 3ed6ff8aeb..62148d28af 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -44,6 +44,26 @@
>            and virDomainPMWakeup APIs.
>          </description>
>        </change>
> +      <change>
> +        <summary>
> +          utils: Introduce monitor capability interface
> +        </summary>
> +        <description>
> +          The resource monitor has been introduces and it creates the interface
> +          for getting the host capability of the resource monitor from the system
> +          resource control.
> +          The resource monitor takes the role of RDT monitoring groups and could
> +          be used to monitor the resource consumption information.
> +        </description>

I think ^this is related to the entry below, so that would IMHO suffice.

> +      </change>
> +      <change>
> +        <summary>
> +          conf: Introduce RDT monitor host capability
> +        </summary>
> +        <description>
> +          Introduce cache monitor (CMT) and memory bandwidth monitor (MBM).
> +        </description>
> +      </change>
>      </section>
>      <section title="Removed features">
>        <change>
> @@ -55,6 +75,15 @@
>            Drop support for these older versions and require Xen >= 4.6.
>          </description>
>        </change>
> +      <change>
> +        <summary>
> +          nwfilter: Disallow binding creation in session mode
> +        </summary>
> +        <description>
> +          Ensure that a filter binding creation is not attempted in session
> +          mode and generate the proper error message.

s/the proper/a proper

> +        </description>
> +      </change>
>      </section>
>      <section title="Improvements">
>        <change>
> @@ -68,8 +97,48 @@
>            Guest Agent.
>          </description>
>        </change>
> +      <change>
> +        <summary>
> +          storage: Allow to use any format as input volume for encryption
> +        </summary>
> +        <description>
> +          Since v4.5.0 libvirt has support to use a 'raw' input volume for
> +          encryption. From now on, let's not limit this to 'raw' only.

I'd say:
Libvirt has supported 'raw' input volumes for encryption since 4.5.0. Now, it's
not going to limit the usage to 'raw' only anymore.

> +        </description>
> +      </change>
> +      <change>
> +        <summary>
> +          libxl: Add support to set shadow memory for any guest type
> +        </summary>
> +        <description>
> +          PVH guests now can take advantage of using shadow memory.
> +        </description>
> +      </change>
>      </section>
>      <section title="Bug fixes">
> +      <change>
> +        <summary>
> +          virsh: Require explicit --domain for domxml-to-native
> +        </summary>
> +        <description>
> +          The domxml-to-native virsh command accepts either --xml or --domain
> +          option followed by a file or domain name respectively, The --domain
> +          option is documented as required, which means an argument with no
> +          option is treated as --xml. Commit v4.3.0-127-gd86531daf2 broke this
> +          by making --domain optional and thus an argument with no option was
> +          treated as --domain.

Too verbose, how about:
The --domain option for domxml-to-native virsh command has always been
documented as required, but commit v4.3.0-127-gd86531daf2 accidentally made it
optional.

> +        </description>
> +      </change>
> +      <change>
> +        <summary>
> +          lxc_monitor: Avoid AB / BA lock race
> +        </summary>
> +        <description>
> +          A dealock situation could occur when autostarting a LXC domain 'guest'
> +          due to two threads attempting to take opposing locks while holding
> +          opposing locks (AB BA problem).
> +        </description>
> +      </change>
>      </section>
>    </release>
>    <release version="v4.7.0" date="2018-09-03">

Now, this is just a matter of preference, you did a good job, but I'd probably
also mention the following:
09d35afd2c util: file: introduce VIR_AUTOCLOSE macro to close fd of the file automatic
ally
0396cf5336 virsh: Implement vsh-table to iface-list (basically extending it to
the whole virsh)

your call...with the grammar adjustments mentioned above:
Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2] news: Update for 4.8.0 release
Posted by Michal Privoznik 5 years, 6 months ago
On 10/01/2018 01:58 PM, Erik Skultety wrote:
> On Mon, Oct 01, 2018 at 12:57:18PM +0200, Fabiano Fidêncio wrote:
>> Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
>> ---
>> I went through the commits since last release and added a few notes
>> which seem to be relevant for the news.
>>
>> In case you notice there's something missing, please, either send me the
>> text to add it (and I'll re-sping this patch) and add the text before
>> merging this one.
>>
>> Changes since v1:
>> - Actually run make-check in order to be sure the changes are fine.
>> ---
>>  docs/news.xml | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 69 insertions(+)
>>


> Now, this is just a matter of preference, you did a good job, but I'd probably
> also mention the following:
> 09d35afd2c util: file: introduce VIR_AUTOCLOSE macro to close fd of the file automatic

Is it something that should interest our users? In my view it's just a
matter of our internal implementation. We haven't mention VIR_AUTOFREE()
back in the day.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2] news: Update for 4.8.0 release
Posted by John Ferlan 5 years, 6 months ago

On 10/1/18 6:57 AM, Fabiano Fidêncio wrote:
> Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
> ---
> I went through the commits since last release and added a few notes
> which seem to be relevant for the news.
> 
> In case you notice there's something missing, please, either send me the
> text to add it (and I'll re-sping this patch) and add the text before
> merging this one.
> 
> Changes since v1:
> - Actually run make-check in order to be sure the changes are fine.
> ---
>  docs/news.xml | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 69 insertions(+)
> 
> diff --git a/docs/news.xml b/docs/news.xml
> index 3ed6ff8aeb..62148d28af 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -44,6 +44,26 @@
>            and virDomainPMWakeup APIs.
>          </description>
>        </change>
> +      <change>
> +        <summary>
> +          utils: Introduce monitor capability interface
> +        </summary>
> +        <description>
> +          The resource monitor has been introduces and it creates the interface

*introduced

But I agree w/ Erik, this is the same as the following.

> +          for getting the host capability of the resource monitor from the system
> +          resource control.
> +          The resource monitor takes the role of RDT monitoring groups and could
> +          be used to monitor the resource consumption information.
> +        </description>
> +      </change>
> +      <change>
> +        <summary>
> +          conf: Introduce RDT monitor host capability
> +        </summary>
> +        <description>
> +          Introduce cache monitor (CMT) and memory bandwidth monitor (MBM).
> +        </description>
> +      </change>

This is all for the Resource Control util subsystem. Essentially a way
to monitor the Cache and Memory Bandwidth and provide capabilities to
know what type of data points are available through the domain capabilities.


>      </section>
>      <section title="Removed features">
>        <change>
> @@ -55,6 +75,15 @@
>            Drop support for these older versions and require Xen >= 4.6.
>          </description>
>        </change>
> +      <change>
> +        <summary>
> +          nwfilter: Disallow binding creation in session mode
> +        </summary>
> +        <description>
> +          Ensure that a filter binding creation is not attempted in session
> +          mode and generate the proper error message.
> +        </description>
> +      </change>

FWIW:

IDC - but I guess a long time ago I got conditioned to not supply
news.xml articles for every bz fixed. I'd be more inclined to just drop
this one especially since nwfilter binding is so new, but I'm also fine
with noting it.

>      </section>
>      <section title="Improvements">
>        <change>
> @@ -68,8 +97,48 @@
>            Guest Agent.
>          </description>
>        </change>
> +      <change>
> +        <summary>
> +          storage: Allow to use any format as input volume for encryption
> +        </summary>
> +        <description>
> +          Since v4.5.0 libvirt has support to use a 'raw' input volume for
> +          encryption. From now on, let's not limit this to 'raw' only.
> +        </description>
> +      </change>

This is all about LUKS encryption... Prior to 4.5 encrypted volumes was
supported though - so I'd be careful to note a version. The 4.5 change
was to "fix" the code in order to handle the multi-step processing that
qemu-img now needs to encrypt a LUKS volume. At best this is a we're now
allowing the input volume to be encrypted.

> +      <change>
> +        <summary>
> +          libxl: Add support to set shadow memory for any guest type
> +        </summary>
> +        <description>
> +          PVH guests now can take advantage of using shadow memory.
> +        </description>
> +      </change>
>      </section>
>      <section title="Bug fixes">
> +      <change>
> +        <summary>
> +          virsh: Require explicit --domain for domxml-to-native
> +        </summary>
> +        <description>
> +          The domxml-to-native virsh command accepts either --xml or --domain
> +          option followed by a file or domain name respectively, The --domain
> +          option is documented as required, which means an argument with no
> +          option is treated as --xml. Commit v4.3.0-127-gd86531daf2 broke this
> +          by making --domain optional and thus an argument with no option was
> +          treated as --domain.
> +        </description>
> +      </change>
> +      <change>
> +        <summary>
> +          lxc_monitor: Avoid AB / BA lock race
> +        </summary>
> +        <description>
> +          A dealock situation could occur when autostarting a LXC domain 'guest'

deadlock



John

> +          due to two threads attempting to take opposing locks while holding
> +          opposing locks (AB BA problem).
> +        </description>
> +      </change>
>      </section>
>    </release>
>    <release version="v4.7.0" date="2018-09-03">
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list