[libvirt] [libvirt PATCH v3] news: Update for 4.8.0 release

Fabiano Fidêncio posted 1 patch 5 years, 4 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20181001130437.23144-1-fidencio@redhat.com
There is a newer version of this series
docs/news.xml | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 77 insertions(+)
[libvirt] [libvirt PATCH v3] news: Update for 4.8.0 release
Posted by Fabiano Fidêncio 5 years, 4 months ago
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
---
I went through the commits since last release and added a few notes
which seem to be relevant for the news.

In case you notice there's something missing, please, either send me the
text to add it (and I'll re-sping this patch) and add the text before
merging this one.

Changes since v1:
- Actually run make-check in order to be sure the changes are fine.

Changes since v2:
- Fixed and reworded some parts according to John's and Erik's
  suggestions.
- Added, according to Erik's suggestion:
  - util: Introduce VIR_AUTOCLOSE macro to automatically close files' fds
  - virsh: Implement vsh-table in virsh and virsh-admin
---
 docs/news.xml | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 77 insertions(+)

diff --git a/docs/news.xml b/docs/news.xml
index 3ed6ff8aeb..36692ba456 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -44,6 +44,18 @@
           and virDomainPMWakeup APIs.
         </description>
       </change>
+      <change>
+        <summary>
+          utils: Introduce monitor capability interface
+        </summary>
+        <description>
+          The resource monitor has been introduced and it creates the interface
+          for getting the host capability of the resource monitor from the system
+          resource control.
+          The resource monitor takes the role of RDT monitoring groups and could
+          be used to monitor the resource consumption information.
+        </description>
+      </change>
     </section>
     <section title="Removed features">
       <change>
@@ -55,6 +67,15 @@
           Drop support for these older versions and require Xen >= 4.6.
         </description>
       </change>
+      <change>
+        <summary>
+          nwfilter: Disallow binding creation in session mode
+        </summary>
+        <description>
+          Ensure that a filter binding creation is not attempted in session
+          mode and generates a proper error message.
+        </description>
+      </change>
     </section>
     <section title="Improvements">
       <change>
@@ -68,8 +89,64 @@
           Guest Agent.
         </description>
       </change>
+      <change>
+        <summary>
+          storage: Allow to use any format as input volume for encryption
+        </summary>
+        <description>
+          Libvirt has supported 'raw' input volumes for encryption since 4.5.0.
+          Now, it's not going to limit the usage to 'raw' only anymore.
+        </description>
+      </change>
+      <change>
+        <summary>
+          libxl: Add support to set shadow memory for any guest type
+        </summary>
+        <description>
+          PVH guests now can take advantage of using shadow memory.
+        </description>
+      </change>
+      <change>
+        <summary>
+          util: Introduce VIR_AUTOCLOSE macro to automatically close files' fds
+        </summary>
+        <description>
+          The Macro automatically force closes the fds by calling
+          <code>virForceCloseHelper</code> when the fd goes out of scope and is
+          used to eliminate <code>VIR_FORCE_CLOSE</code> in cleanup sections.
+        </description>
+      </change>
+      <change>
+        <summary>
+          virsh: Implement vsh-table in virsh and virsh-admin
+        </summary>
+        <description>
+          The new API fixes problems with table-alignment, making the tables
+          more readable and deals with unicode.
+        </description>
+      </change>
     </section>
     <section title="Bug fixes">
+      <change>
+        <summary>
+          virsh: Require explicit --domain for domxml-to-native
+        </summary>
+        <description>
+          The --domain option for domxml-to-native virsh command has always
+          been documented as required, but commit v4.3.0-127-gd86531daf2
+          accidentally made it optional.
+        </description>
+      </change>
+      <change>
+        <summary>
+          lxc_monitor: Avoid AB / BA lock race
+        </summary>
+        <description>
+          A deadlock situation could occur when autostarting a LXC domain
+          'guest' due to two threads attempting to take opposing locks while
+          holding opposing locks (AB BA problem).
+        </description>
+      </change>
     </section>
   </release>
   <release version="v4.7.0" date="2018-09-03">
-- 
2.19.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [libvirt PATCH v3] news: Update for 4.8.0 release
Posted by Peter Krempa 5 years, 4 months ago
On Mon, Oct 01, 2018 at 15:04:37 +0200, Fabiano Fidêncio wrote:
> Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
> ---
> I went through the commits since last release and added a few notes
> which seem to be relevant for the news.
> 
> In case you notice there's something missing, please, either send me the
> text to add it (and I'll re-sping this patch) and add the text before
> merging this one.
> 
> Changes since v1:
> - Actually run make-check in order to be sure the changes are fine.
> 
> Changes since v2:
> - Fixed and reworded some parts according to John's and Erik's
>   suggestions.
> - Added, according to Erik's suggestion:
>   - util: Introduce VIR_AUTOCLOSE macro to automatically close files' fds
>   - virsh: Implement vsh-table in virsh and virsh-admin
> ---
>  docs/news.xml | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 77 insertions(+)
> 
> diff --git a/docs/news.xml b/docs/news.xml
> index 3ed6ff8aeb..36692ba456 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -44,6 +44,18 @@
>            and virDomainPMWakeup APIs.
>          </description>
>        </change>
> +      <change>
> +        <summary>
> +          utils: Introduce monitor capability interface

Missing word 'resource'

> +        </summary>
> +        <description>
> +          The resource monitor has been introduced and it creates the interface
> +          for getting the host capability of the resource monitor from the system
> +          resource control.
> +          The resource monitor takes the role of RDT monitoring groups and could
> +          be used to monitor the resource consumption information.

Not quite sure that this helps anybody in understanding the new feature.

> +        </description>
> +      </change>
>      </section>
>      <section title="Removed features">
>        <change>

[...]

> @@ -68,8 +89,64 @@
>            Guest Agent.
>          </description>
>        </change>
> +      <change>
> +        <summary>
> +          storage: Allow to use any format as input volume for encryption
> +        </summary>
> +        <description>
> +          Libvirt has supported 'raw' input volumes for encryption since 4.5.0.
> +          Now, it's not going to limit the usage to 'raw' only anymore.
> +        </description>
> +      </change>
> +      <change>
> +        <summary>
> +          libxl: Add support to set shadow memory for any guest type
> +        </summary>
> +        <description>
> +          PVH guests now can take advantage of using shadow memory.

I'm not quite sure the users will know what this means.

> +        </description>
> +      </change>
> +      <change>
> +        <summary>
> +          util: Introduce VIR_AUTOCLOSE macro to automatically close files' fds
> +        </summary>
> +        <description>
> +          The Macro automatically force closes the fds by calling
> +          <code>virForceCloseHelper</code> when the fd goes out of scope and is
> +          used to eliminate <code>VIR_FORCE_CLOSE</code> in cleanup sections.
> +        </description>

This is internal stuff not really worth mentioning in the news.

> +      </change>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [libvirt PATCH v3] news: Update for 4.8.0 release
Posted by Fabiano Fidêncio 5 years, 4 months ago
On Mon, 2018-10-01 at 15:22 +0200, Peter Krempa wrote:
> On Mon, Oct 01, 2018 at 15:04:37 +0200, Fabiano Fidêncio wrote:
> > Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
> > ---
> > I went through the commits since last release and added a few notes
> > which seem to be relevant for the news.
> > 
> > In case you notice there's something missing, please, either send
> > me the
> > text to add it (and I'll re-sping this patch) and add the text
> > before
> > merging this one.
> > 
> > Changes since v1:
> > - Actually run make-check in order to be sure the changes are fine.
> > 
> > Changes since v2:
> > - Fixed and reworded some parts according to John's and Erik's
> >   suggestions.
> > - Added, according to Erik's suggestion:
> >   - util: Introduce VIR_AUTOCLOSE macro to automatically close
> > files' fds
> >   - virsh: Implement vsh-table in virsh and virsh-admin
> > ---
> >  docs/news.xml | 77
> > +++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 77 insertions(+)
> > 
> > diff --git a/docs/news.xml b/docs/news.xml
> > index 3ed6ff8aeb..36692ba456 100644
> > --- a/docs/news.xml
> > +++ b/docs/news.xml
> > @@ -44,6 +44,18 @@
> >            and virDomainPMWakeup APIs.
> >          </description>
> >        </change>
> > +      <change>
> > +        <summary>
> > +          utils: Introduce monitor capability interface
> 
> Missing word 'resource'
> 
> > +        </summary>
> > +        <description>
> > +          The resource monitor has been introduced and it creates
> > the interface
> > +          for getting the host capability of the resource monitor
> > from the system
> > +          resource control.
> > +          The resource monitor takes the role of RDT monitoring
> > groups and could
> > +          be used to monitor the resource consumption information.
> 
> Not quite sure that this helps anybody in understanding the new
> feature.

May I ask for some help here to have it in a way that it would actually
help someone to understand the new feature?

> 
> > +        </description>
> > +      </change>
> >      </section>
> >      <section title="Removed features">
> >        <change>
> 
> [...]
> 
> > @@ -68,8 +89,64 @@
> >            Guest Agent.
> >          </description>
> >        </change>
> > +      <change>
> > +        <summary>
> > +          storage: Allow to use any format as input volume for
> > encryption
> > +        </summary>
> > +        <description>
> > +          Libvirt has supported 'raw' input volumes for encryption
> > since 4.5.0.
> > +          Now, it's not going to limit the usage to 'raw' only
> > anymore.
> > +        </description>
> > +      </change>
> > +      <change>
> > +        <summary>
> > +          libxl: Add support to set shadow memory for any guest
> > type
> > +        </summary>
> > +        <description>
> > +          PVH guests now can take advantage of using shadow
> > memory.
> 
> I'm not quite sure the users will know what this means.


And here as well?

> 
> > +        </description>
> > +      </change>
> > +      <change>
> > +        <summary>
> > +          util: Introduce VIR_AUTOCLOSE macro to automatically
> > close files' fds
> > +        </summary>
> > +        <description>
> > +          The Macro automatically force closes the fds by calling
> > +          <code>virForceCloseHelper</code> when the fd goes out of
> > scope and is
> > +          used to eliminate <code>VIR_FORCE_CLOSE</code> in
> > cleanup sections.
> > +        </description>
> 
> This is internal stuff not really worth mentioning in the news.

Okay, I'll drop this one.

> 
> > +      </change>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [libvirt PATCH v3] news: Update for 4.8.0 release
Posted by Erik Skultety 5 years, 4 months ago
On Mon, Oct 01, 2018 at 03:04:37PM +0200, Fabiano Fidêncio wrote:
> Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
> ---
> I went through the commits since last release and added a few notes
> which seem to be relevant for the news.
>
> In case you notice there's something missing, please, either send me the
> text to add it (and I'll re-sping this patch) and add the text before
> merging this one.
>
> Changes since v1:
> - Actually run make-check in order to be sure the changes are fine.
>
> Changes since v2:
> - Fixed and reworded some parts according to John's and Erik's
>   suggestions.
> - Added, according to Erik's suggestion:
>   - util: Introduce VIR_AUTOCLOSE macro to automatically close files' fds
>   - virsh: Implement vsh-table in virsh and virsh-admin
> ---
>  docs/news.xml | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 77 insertions(+)
>
> diff --git a/docs/news.xml b/docs/news.xml
> index 3ed6ff8aeb..36692ba456 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -44,6 +44,18 @@
>            and virDomainPMWakeup APIs.
>          </description>
>        </change>
> +      <change>
> +        <summary>
> +          utils: Introduce monitor capability interface
> +        </summary>
> +        <description>
> +          The resource monitor has been introduced and it creates the interface
> +          for getting the host capability of the resource monitor from the system
> +          resource control.
> +          The resource monitor takes the role of RDT monitoring groups and could
> +          be used to monitor the resource consumption information.
> +        </description>
> +      </change>
>      </section>
>      <section title="Removed features">
>        <change>
> @@ -55,6 +67,15 @@
>            Drop support for these older versions and require Xen >= 4.6.
>          </description>
>        </change>
> +      <change>
> +        <summary>
> +          nwfilter: Disallow binding creation in session mode
> +        </summary>
> +        <description>
> +          Ensure that a filter binding creation is not attempted in session
> +          mode and generates a proper error message.
> +        </description>
> +      </change>
>      </section>
>      <section title="Improvements">
>        <change>
> @@ -68,8 +89,64 @@
>            Guest Agent.
>          </description>
>        </change>
> +      <change>
> +        <summary>
> +          storage: Allow to use any format as input volume for encryption
> +        </summary>
> +        <description>
> +          Libvirt has supported 'raw' input volumes for encryption since 4.5.0.
> +          Now, it's not going to limit the usage to 'raw' only anymore.
> +        </description>

So I followed John's comments and looked at the stuff more thoroughly. First of
all, you probably want to reference commit b975afc7 instead of ^this one, since
that has the actual bugzilla on it + the other 2 patches in that series did
some necessary preparations. After reading the bugzilla and going through the
code, it truly is a bugfix rather than an improvement and my wording would
simply be:

When creating a storage volume based on another volume, the base input volume
is allowed to be encrypted.

I don't have any further comments, since you already got some from Peter.

Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list