From nobody Sat Apr 20 12:58:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1538489722486713.6727038969042; Tue, 2 Oct 2018 07:15:22 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D6D3530833C2; Tue, 2 Oct 2018 14:15:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8D5602C8B0; Tue, 2 Oct 2018 14:15:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3BEC8180BAD2; Tue, 2 Oct 2018 14:15:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w92EF97u020254 for ; Tue, 2 Oct 2018 10:15:09 -0400 Received: by smtp.corp.redhat.com (Postfix) id 87F381C945; Tue, 2 Oct 2018 14:15:09 +0000 (UTC) Received: from kinshicho.redhat.com (unknown [10.40.205.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 80FA61C939 for ; Tue, 2 Oct 2018 14:15:08 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Tue, 2 Oct 2018 16:14:42 +0200 Message-Id: <20181002141446.20943-4-abologna@redhat.com> In-Reply-To: <20181002141446.20943-1-abologna@redhat.com> References: <20181002141446.20943-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [RFC 3/7] tools: Print warnings in virsh X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Tue, 02 Oct 2018 14:15:21 +0000 (UTC) X-ZohoMail: RDMRC_0 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" We delay dealing with actual errors until a later, more appropriate time in general, but if we wanted to do the same with warnings we'd have to introduce a lot of duplicated handling in virsh, so we just print them right away and move on with the usual processing instead. Signed-off-by: Andrea Bolognani --- tools/vsh.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/vsh.c b/tools/vsh.c index 9ea3c4b96a..2ebd11d09f 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -242,6 +242,9 @@ vshErrorHandler(void *opaque ATTRIBUTE_UNUSED, { virFreeError(last_error); last_error =3D virSaveLastError(); + + if (last_error && last_error->level =3D=3D VIR_ERR_WARNING) + fprintf(stderr, "Warning: %s\n", NULLSTR(last_error->message)); } =20 /* Store a libvirt error that is from a helper API that doesn't raise erro= rs --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list