From nobody Fri May 9 19:03:45 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1538489729696920.4406902050556; Tue, 2 Oct 2018 07:15:29 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6143E300187D; Tue, 2 Oct 2018 14:15:27 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1EE995D6A6; Tue, 2 Oct 2018 14:15:27 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A6A5D4CAA0; Tue, 2 Oct 2018 14:15:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w92EFEMo020285 for ; Tue, 2 Oct 2018 10:15:14 -0400 Received: by smtp.corp.redhat.com (Postfix) id 124B026570; Tue, 2 Oct 2018 14:15:14 +0000 (UTC) Received: from kinshicho.redhat.com (unknown [10.40.205.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 22BAF1C939 for ; Tue, 2 Oct 2018 14:15:12 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Tue, 2 Oct 2018 16:14:45 +0200 Message-Id: <20181002141446.20943-7-abologna@redhat.com> In-Reply-To: <20181002141446.20943-1-abologna@redhat.com> References: <20181002141446.20943-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [RFC 6/7] Deprecate missing machine type in virDomainDefineXMLFlags() X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Tue, 02 Oct 2018 14:15:28 +0000 (UTC) X-ZohoMail: RDMRC_0 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" This time we don't want to deprecate the API itself; instead, we want warning to be reported whenever some specific condition is met. Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c | 11 ++++++++--- src/libvirt-domain.c | 1 + 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9911d56130..da0f1ed025 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -19114,9 +19114,14 @@ virDomainDefParseCaps(virDomainDefPtr def, } else { if (!def->os.arch) def->os.arch =3D capsdata->arch; - if ((!def->os.machine && - VIR_STRDUP(def->os.machine, capsdata->machinetype) < 0)) - goto cleanup; + if (!def->os.machine) { + virReportWarning(VIR_ERR_DEPRECATED_FEATURE, + "%s", + _("Missing machine type")); + + if (VIR_STRDUP(def->os.machine, capsdata->machinetype) < 0) + goto cleanup; + } } =20 ret =3D 0; diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index a758539b6d..be1a67d8f6 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -6216,6 +6216,7 @@ virDomainDefineXMLFlags(virConnectPtr conn, const cha= r *xml, unsigned int flags) ret =3D conn->driver->domainDefineXMLFlags(conn, xml, flags); if (!ret) goto error; + virDispatchError(conn); return ret; } =20 --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list